armedbear-devel October 2009

armedbear-devel@common-lisp.net

13 participants
33 discussions

[armedbear-devel] CLOS optimizations
by Erik Huelsmann 15 Oct '09

15 Oct '09

This weekend, I committed an optimization which shows 4 - 12% performance gain on the CL-BENCH common lisp benchmarking toolset tests for CLOS. However, the test collects performance results from a high number of invocations. Low numbers of invocations should show even better improvements. Profiling one of the performance tests for CL-BENCH which shows huge difference with CLISP, it turned out that our CHECK-INITARGS function in the MOP package is taking 40% of the object instantiation time consumed by MAKE-INSTANCE. After the first invocation, it's possible to replace this function by a lookup in a cache. The same applies to args checking for some of the other functions defined to object instantiation and class modification. However, the time required to build this into our CLOS in a structured manner, exceeds "just" a few evenings, meaning that I probably will be delaying this task until I have a more time to undertake this effort. Ofcourse, I remain on the look out for possibilities to increase the performance of our clos implementation. An important input are the issues you experience with our performance, especially if you have example code to demonstrate it. Bye, Erik.

3 4

[armedbear-devel] Implementing non local exits in a runtime with structured exception handling
by Matthew D. Swank 15 Oct '09

15 Oct '09

I am playing with a lisp dialect (at least in my head) that I am thinking about implementing on the CLR. Like Java the CLR requires jumps across method call boundaries to be done using the exception handling mechanism. If I have code like the following in abcl: (block foo (flet ((callback () (return-from foo t))) (something-that-calls-into-java #'callback) ... stuff that won't happen if the callback is invoked)) And the plain old Java I'm calling into is pathological and catches the exception raised by calling the callback without re-throwing it, the non-local return never happens. Is that correct? If so, is there no way around it? Matt -- "You do not really understand something unless you can explain it to your grandmother." -- Albert Einstein.

2 1

[armedbear-devel] Java callbacks
by Alessio Stalla 14 Oct '09

14 Oct '09

Hello, I was thinking about the integration of lisp and java with abcl and it struck me that we don't have an easy way to pass a callback from Java to Lisp (e.g. a function acting as a factory of objects): one can extend Function, Primitive or even LispObject and implement the appropriate execute() method overload; however, one must perform conversion to/from Lisp objects manually, and while this is a minor inconvenience, it adds boilerplate code that could be easily avoided. So I was thinking about adding a Callback class extending Function, with overloads for execute() taking and returning regular java.lang.Object instances, and corresponding execute() based on LispObjects that perform the necessary conversions and call the Java-friendly versions. Example: public LispObject execute(LispObject arg0) { return JavaObject.getInstance(execute(arg0.javaInstance())); } /** To be overridden by the implementing subclass */ protected Object execute(Object arg0) { return error(new WrongNumberOfArgumentsException(this)); } Such a class could have convenience factory methods taking Runnables, Callables and other popular kinds of Java callback objects. Thoughts? Ale

2 2

Re: [armedbear-devel] [armedbear-cvs] r12183 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 10 Oct '09

10 Oct '09

Mark, The commit below should enable the use of Gray streams with ABCL. I think this means SLIME can now switch to its normal pattern of using Gray streams to wrap its input and output processors. At least, I'd like to remove the SlimeInputStream and SlimeOutputStream Java classes and move the problem to SLIME, if that's possible. Maybe I want to do the same thing for socket streams. Bye, Erik. On Fri, Oct 9, 2009 at 11:31 PM, Erik Huelsmann <ehuelsmann(a)common-lisp.net> wrote: > Author: ehuelsmann > Date: Fri Oct 9 17:31:50 2009 > New Revision: 12183 > > Log: > Fix last Gray stream incompatibilities: generic functions > overlapping with CL functions are no longer have the STREAM- prefix. > > Note: this commit also removes gray stream testing code which does > not belong in the "production" image of our software. > > Modified: > trunk/abcl/src/org/armedbear/lisp/gray-streams.lisp > > Modified: trunk/abcl/src/org/armedbear/lisp/gray-streams.lisp > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/gray-streams.lisp (original) > +++ trunk/abcl/src/org/armedbear/lisp/gray-streams.lisp Fri Oct 9 17:31:50 2009 > @@ -94,25 +94,7 @@ > ;;;; > ;;;; Notes > ;;;; ===== > -;;;; CLOSE is not a generic function in this implementation. Instead, > -;;;; the generic is called STREAM-CLOSE and the function CLOSE calls > -;;;; STREAM-CLOSE. The same goes for STREAMP, INPUT-STREAM-P, > -;;;; OUTPUT-STREAM-P and STREAM-ELEMENT-TYPE. The generic functions for > -;;;; these are STREAM-STREAMP, STREAM-INPUT-STREAM-P, > -;;;; STREAM-OUTPUT-STREAM-P and STREAM-STREAM-ELEMENT-TYPE. > ;;;; > -;;;; The standard Corman Lisp streams are not derived from > -;;;; FUNDAMENTAL-STREAM. All the stream functions check to see if the > -;;;; stream is an original Corman Lisp stream and forward on to the > -;;;; original function implementations. > -;;;; > -;;;; The string streams are implemented in this file as Gray streams > -;;;; but do not replace the Corman Lisp string streams. They are only > -;;;; implemented here to test the Gray stream functionality. These methods > -;;;; are called: > -;;;; GRAY-MAKE-STRING-OUTPUT-STREAM > -;;;; GRAY-GET-OUTPUT-STREAM-STRING > -;;;; GRAY-MAKE-STRING-INPUT-STREAM > ;;;; > ;;;; Much of the implementation of the Gray streams below is from the > ;;;; document referenced earlier. > @@ -123,7 +105,6 @@ > (:nicknames "GS") ;; # fb 1.01 > (:export > "FUNDAMENTAL-STREAM" > - "STREAM-CLOSE" > "STREAM-OPEN-STREAM-P" > "STREAM-STREAMP" > "STREAM-INPUT-STREAM-P" > @@ -200,21 +181,14 @@ > > (defclass fundamental-stream ()) > > -(defgeneric stream-close (stream &key abort)) > -(defgeneric stream-open-stream-p (stream)) > -(defgeneric stream-streamp (stream)) > -(defgeneric stream-input-stream-p (stream)) > -(defgeneric stream-input-character-stream-p (stream)) ;; # fb 1.01 > -(defgeneric stream-output-stream-p (stream)) > -(defgeneric stream-stream-element-type (stream)) > +(defgeneric gray-close (stream &key abort)) > +(defgeneric gray-open-stream-p (stream)) > +(defgeneric gray-streamp (stream)) > +(defgeneric gray-input-stream-p (stream)) > +(defgeneric gray-input-character-stream-p (stream)) ;; # fb 1.01 > +(defgeneric gray-output-stream-p (stream)) > +(defgeneric gray-stream-element-type (stream)) > > -(defmethod stream-close (stream &key abort) > - (declare (ignore stream abort)) > - nil) > - > -(defmethod stream-streamp (s) > - (declare (ignore s)) > - nil) > > (defmethod stream-streamp ((s fundamental-stream)) > s) > @@ -225,20 +199,12 @@ > (and (stream-input-stream-p s) > (eq (stream-stream-element-type s) 'character))) > > -(defmethod stream-input-stream-p (s) > - (declare (ignore s)) > - nil) > - > (defmethod stream-input-stream-p ((s fundamental-input-stream)) > (declare (ignore s)) > t) > > (defclass fundamental-output-stream (fundamental-stream)) > > -(defmethod stream-output-stream-p (s) > - (declare (ignore s)) > - nil) > - > (defmethod stream-output-stream-p ((s fundamental-output-stream)) > (declare (ignore s)) > t) > @@ -539,72 +505,6 @@ > (funcall *old-write-byte* integer binary-output-stream) > (stream-write-byte binary-output-stream integer))) > > -(defclass string-input-stream (fundamental-character-input-stream) > - ((string :initarg :string :type string) > - (index :initarg :start :type fixnum) > - (end :initarg :end :type fixnum))) > - > -(defun gray-make-string-input-stream (string &optional (start 0) end) > - (make-instance 'string-input-stream :string string > - :start start :end (or end (length string)))) > - > -(defmethod stream-read-char ((stream string-input-stream)) > - (with-slots (index end string) stream > - (if (>= index end) > - :eof > - (prog1 > - (char string index) > - (incf index))))) > - > -(defmethod stream-unread-char ((stream string-input-stream) character) > - (with-slots (index end string) stream > - (decf index) > - (assert (eql (char string index) character)) > - nil)) > - > -(defmethod stream-read-line ((stream string-input-stream)) > - (with-slots (index end string) stream > - (let* ((endline (position #\newline string :start index :end end)) > - (line (subseq string index endline))) > - (if endline > - (progn > - (setq index (1+ endline)) > - (values line nil)) > - (progn > - (setq index end) > - (values line t)))))) > - > -(defclass string-output-stream (fundamental-character-output-stream) > - ((string :initform nil :initarg :string))) > - > -(defun gray-make-string-output-stream () > - (make-instance 'string-output-stream)) > - > -(defun gray-get-output-stream-string (stream) > - (with-slots (string) stream > - (if (null string) > - "" > - (prog1 > - (coerce string 'string) > - (setq string nil))))) > - > -(defmethod stream-write-char ((stream string-output-stream) character) > - (with-slots (string) stream > - (when (null string) > - (setq string (make-array 64 :slement-type 'character > - :fill-pointer 0 :adjustable t))) > - (vector-push-extend character string) > - character)) > - > -(defmethod stream-line-column ((stream string-output-stream)) > - (with-slots (string) stream > - (if (null string) > - 0 > - (let ((nx (position #\newline string :from-end t))) > - (if (null nx) > - (length string) > - (- (length string) nx 1)))))) > - > (defmethod stream-line-column ((stream stream)) > nil) > > @@ -614,40 +514,26 @@ > nil ;(funcall *old-stream-column* stream) > (stream-line-column stream)))) > > -(defun gray-stream-element-type (stream) > - (if (old-streamp stream) > - (funcall *old-stream-element-type* stream) > - (stream-stream-element-type stream))) > +(defmethod gray-stream-element-type (stream) > + (funcall *old-stream-element-type* stream)) > > -(defun gray-close (stream &key abort) > - (if (old-streamp stream) > - (funcall *old-close* stream :abort abort) > - (stream-close stream :abort nil))) > +(defmethod gray-close (stream &key abort) > + (funcall *old-close* stream :abort abort)) > > -(defun gray-input-stream-p (stream) > - (if (old-streamp stream) > - (funcall *old-input-stream-p* stream) > - (stream-input-stream-p stream))) > +(defmethod gray-input-stream-p (stream) > + (funcall *old-input-stream-p* stream)) > > -(defun gray-input-character-stream-p (stream) > - (if (old-streamp stream) > - (funcall *old-input-character-stream-p* stream) > - (stream-input-character-stream-p stream))) > +(defmethod gray-input-character-stream-p (stream) > + (funcall *old-input-character-stream-p* stream)) > > -(defun gray-output-stream-p (stream) > - (if (old-streamp stream) > - (funcall *old-output-stream-p* stream) > - (stream-output-stream-p stream))) > +(defmethod gray-output-stream-p (stream) > + (funcall *old-output-stream-p* stream)) > > -(defun gray-open-stream-p (stream) > - (if (old-streamp stream) > - (funcall *old-open-stream-p* stream) > - (stream-open-stream-p stream))) > +(defmethod gray-open-stream-p (stream) > + (funcall *old-open-stream-p* stream)) > > -(defun gray-streamp (stream) > - (if (old-streamp stream) > - (funcall *old-streamp* stream) > - (stream-streamp stream))) > +(defmethod gray-streamp (stream) > + (funcall *old-streamp* stream)) > > (defun gray-write-sequence (sequence stream &key (start 0) end) > (if (old-streamp stream) > @@ -659,24 +545,6 @@ > (funcall *old-read-sequence* sequence stream :start start :end end) > (stream-read-sequence stream sequence start end))) > > -(defstruct two-way-stream-g > - input-stream output-stream) > - > -(defun gray-make-two-way-stream (in out) > - (if (and (old-streamp in) (old-streamp out)) > - (funcall *old-make-two-way-stream* in out) > - (make-two-way-stream-g :input-stream in :output-stream out))) > - > -(defun gray-two-way-stream-input-stream (stream) > - (if (old-streamp stream) > - (funcall *old-two-way-stream-input-stream* stream) > - (two-way-stream-g-input-stream stream))) > - > -(defun gray-two-way-stream-output-stream (stream) > - (if (old-streamp stream) > - (funcall *old-two-way-stream-output-stream* stream) > - (two-way-stream-g-output-stream stream))) > - > (setf (symbol-function 'common-lisp::read-char) #'gray-read-char) > (setf (symbol-function 'common-lisp::peek-char) #'gray-peek-char) > (setf (symbol-function 'common-lisp::unread-char) #'gray-unread-char) > @@ -703,8 +571,5 @@ > (setf (symbol-function 'common-lisp::streamp) #'gray-streamp) > (setf (symbol-function 'common-lisp::read-sequence) #'gray-read-sequence) > (setf (symbol-function 'common-lisp::write-sequence) #'gray-write-sequence) > -(setf (symbol-function 'common-lisp::make-two-way-stream) #'gray-make-two-way-stream) > -(setf (symbol-function 'common-lisp::two-way-stream-input-stream) #'gray-two-way-stream-input-stream) > -(setf (symbol-function 'common-lisp::two-way-stream-output-stream) #'gray-two-way-stream-output-stream) > > (provide 'gray-streams) > > _______________________________________________ > armedbear-cvs mailing list > armedbear-cvs(a)common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-cvs >

3 3

[armedbear-devel] bug with initialize-instance and keyword arguments
by Steve Rolls 10 Oct '09

10 Oct '09

This is present in 0.16 and latest from svn, but not in 0.15. Specifying a keyword arg in an initialize-instance method does not make the keyword a valid initarg for make-instance. Armed Bear Common Lisp 0.16.0 Java 1.6.0_12 Sun Microsystems Inc. Java HotSpot(TM) 64-Bit Server VM Low-level initialization completed in 0.425 seconds. Startup completed in 2.086 seconds. Type ":help" for a list of available commands. CL-USER(1): (defclass c1() (x)) #<STANDARD-CLASS C1 {5A347448}> CL-USER(2): (defmethod initialize-instance :after ((c c1) &key x2) (setf (slot-value c 'x) x2)) #<STANDARD-METHOD INITIALIZE-INSTANCE :AFTER (C1) {79A1EA46}> CL-USER(3): (make-instance 'c1 :x2 1) Debugger invoked on condition of type PROGRAM-ERROR: Invalid initarg :X2. Restarts: 0: TOP-LEVEL Return to top level. [1] CL-USER(4): Works as expected in 0.15 Armed Bear Common Lisp 0.15.0 Java 1.6.0_12 Sun Microsystems Inc. Java HotSpot(TM) 64-Bit Server VM Low-level initialization completed in 0.45 seconds. Startup completed in 2.021 seconds. Type ":help" for a list of available commands. CL-USER(1): (defclass c1() (x)) #<STANDARD-CLASS C1 {615E7597}> CL-USER(2): (defmethod initialize-instance :after ((c c1) &key x2) (setf (slot-value c 'x) x2)) #<STANDARD-METHOD INITIALIZE-INSTANCE :AFTER (C1) {7346B111}> CL-USER(3): (make-instance 'c1 :x2 1) #<C1 {772EDF9A}> CL-USER(4):

3 8

[armedbear-devel] No :DARWIN, "No tag" & no ASDF
by John Pallister 06 Oct '09

06 Oct '09

Hello list, I'm inching my way towards working with ABCL (stupid day job) and I thought I'd mention a few things that have cropped up. I'm running on OS X 10.5.8 using the OpenJDK 6 (for JSR-223, and the server VM). I updated the source from the SVN repo this morning. When I build ABCL, I get the warning "Use of Java version 1.6.0-internal not recommended." Perhaps '<matches string="${java.version}" pattern="1\.6\.0-internal"/>' could be added to the appropriate spot in build.xml to suppress this warning. When I run ABCL, I get :JAVA-1.6 in *FEATURES* but not :DARWIN (or any other OS identifier). (*FEATURES* is (:DARWIN :JAVA-1.6 :ARMEDBEAR :ABCL :COMMON-LISP :ANSI-CL :CDR6). What's :CDR6?) When my '(load ".../start-swank.lisp")' fails, I get an error when I enter ':cont 0': shadow:abcl john$ ./abcl Armed Bear Common Lisp 0.17.0-dev Java 1.6.0-internal Sun Microsystems Inc. OpenJDK Server VM Low-level initialization completed in 1.699 seconds. Startup completed in 8.5 seconds. [on my Dell Mini 9, not real Apple h/w] Type ":help" for a list of available commands. CL-USER(1): (load "/Users/john/src/lisp/abcl/start-swank.lisp") Error loading /Users/john/src/lisp/asdf/asdf.lisp at line 193 (offset 7111) Debugger invoked on condition of type SIMPLE-ERROR: The long form of DEFINE-METHOD-COMBINATION is not implemented. Restarts: 0: TOP-LEVEL Return to top level. [1] ASDF(2): :cont 0 Debugger invoked on condition of type CONTROL-ERROR: No tag named #:G140089 is currently visible Restarts: 0: TOP-LEVEL Return to top level. [1] CL-USER(3): :res CL-USER(4): Which brings me to the last problem: asdf.lisp won't load, since it uses the long form of DEFINE-METHOD-COMBINATION. Is there a workaround for this? If anyone can shed some light on these issues, that would be great. As an aside, does anyone want to share their .emacs settings for Java development? I've installed JDE (which was a PITA FWIW), CC-Mode etc. and I'm curious as to what other (Emacs-minded) people are using. Cheers, John :^P -- John Pallister john(a)johnp.net john(a)synchromesh.com

5 13

Re: [armedbear-devel] [armedbear-cvs] r12153 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 06 Oct '09

06 Oct '09

Hi Mark, On Fri, Sep 18, 2009 at 3:43 PM, Mark Evenson <mevenson(a)common-lisp.net> wrote: > Author: mevenson > Date: Fri Sep 18 09:43:42 2009 > New Revision: 12153 > > Log: > Tenative fix for #63: transform caught Go throwable to LispError. > > Normalized printStackTrace() calls through Debug.trace() interface. > > > > Modified: > trunk/abcl/src/org/armedbear/lisp/Lisp.java > > Modified: trunk/abcl/src/org/armedbear/lisp/Lisp.java > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/Lisp.java (original) > +++ trunk/abcl/src/org/armedbear/lisp/Lisp.java Fri Sep 18 09:43:42 2009 > @@ -123,7 +123,7 @@ > } > catch (Throwable t) > { > - t.printStackTrace(); > + Debug.trace(t); > } > } > > @@ -277,7 +277,7 @@ > } > catch (Go go) > { > - throw go; > + return error(go.getCondition()); > } > catch (Throw t) > { This hunk causes "havoc" with the command line interface where people select the "go to toplevel" restart. I think this is the major change in this commit? If I want to revert this bit, do I have to revert the rest too, or are those just improvements on what was already there? BTW: With my recent changes, I don't think there's anything wrong with re-throwing the Go anymore: we check for a catching environment before throwing now. > @@ -1042,6 +1042,7 @@ > } > catch (Throwable t) > { > + Debug.trace(t); > return null; > } > } > @@ -2586,7 +2587,7 @@ > } > catch (ClassNotFoundException e) > { > - e.printStackTrace(); > + Debug.trace(e); > } > } > > > _______________________________________________ > armedbear-cvs mailing list > armedbear-cvs(a)common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-cvs >

2 1

[armedbear-devel] Fw: SparseChars patch
by logicmoo＠gmail.com 04 Oct '09

04 Oct '09

ABCL, Here is the SparseChars patch. It shouldn't pass more or less ANSI-TESTs. but will improve performance due to the fact it uses less java heap and copies less. The one thing I might do later is stop using the character iterator (CharHashMap would get a copyToOther(CharHashMap)).. but for now its sane.

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

armedbear-devel October 2009