January 2012 - armedbear-devel - mailman3.common-lisp.net

[armedbear-devel] Fwd: [armedbear-cvs] r13787 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 17 Jan '12

17 Jan '12

The commit below reduces the number of ANSI failures on my system from 18 to 14! Bye, Erik. ---------- Forwarded message ---------- From: <ehuelsmann(a)common-lisp.net> Date: Tue, Jan 17, 2012 at 8:39 PM Subject: [armedbear-cvs] r13787 - trunk/abcl/src/org/armedbear/lisp To: armedbear-cvs(a)common-lisp.net Author: ehuelsmann Date: Tue Jan 17 11:39:54 2012 New Revision: 13787 Log: Implement keyword argument verification in the method invocation protocol. Modified: trunk/abcl/src/org/armedbear/lisp/clos.lisp Modified: trunk/abcl/src/org/armedbear/lisp/clos.lisp ============================================================================== --- trunk/abcl/src/org/armedbear/lisp/clos.lisp Tue Jan 17 11:38:01 2012 (r13786) +++ trunk/abcl/src/org/armedbear/lisp/clos.lisp Tue Jan 17 11:39:54 2012 (r13787) @@ -2027,13 +2027,72 @@ (unless (subclassp (car classes) specializer) (return (values nil t))))))) +(defun check-applicable-method-keyword-args (gf args + keyword-args + applicable-keywords) + (when (oddp (length keyword-args)) + (error 'program-error + :format-control "Odd number of keyword arguments in call to ~S ~ +with arguments list ~S" + :format-arguments (list gf args))) + (unless (getf keyword-args :allow-other-keys) + (loop for key in keyword-args by #'cddr + unless (or (member key applicable-keywords) + (eq key :allow-other-keys)) + do (error 'program-error + :format-control "Invalid keyword argument ~S in call ~ +to ~S with argument list ~S." + :format-arguments (list key gf args))))) + +(defun compute-applicable-keywords (gf applicable-methods) + (let ((applicable-keywords + (getf (analyze-lambda-list (generic-function-lambda-list gf)) + :keywords))) + (loop for method in applicable-methods + do (multiple-value-bind + (keywords allow-other-keys) + (function-keywords method) + (when allow-other-keys + (setf applicable-keywords :any) + (return)) + (setf applicable-keywords + (union applicable-keywords keywords)))) + applicable-keywords)) + +(defun wrap-emfun-for-keyword-args-check (gf emfun non-keyword-args + applicable-keywords) + #'(lambda (args) + (check-applicable-method-keyword-args + gf args + (nthcdr non-keyword-args args) applicable-keywords) + (funcall emfun args))) + (defun slow-method-lookup (gf args) (let ((applicable-methods (%compute-applicable-methods gf args))) (if applicable-methods - (let ((emfun (funcall (if (eq (class-of gf) +the-standard-generic-function-class+) - #'std-compute-effective-method-function - #'compute-effective-method-function) - gf applicable-methods))) + (let* ((emfun (funcall (if (eq (class-of gf) +the-standard-generic-function-class+) + #'std-compute-effective-method-function + #'compute-effective-method-function) + gf applicable-methods)) + (non-keyword-args + (+ (length (gf-required-args gf)) + (length (gf-optional-args gf)))) + (gf-lambda-list (generic-function-lambda-list gf)) + (checks-required (and (member '&key gf-lambda-list) + (not (member '&allow-other-keys + gf-lambda-list))) + ) + (applicable-keywords + (when checks-required + ;; Don't do applicable keyword checks when this is + ;; one of the 'exceptional four' or when the gf allows + ;; other keywords. + (compute-applicable-keywords gf applicable-methods)))) + (when (and checks-required + (not (eq applicable-keywords :any))) + (setf emfun + (wrap-emfun-for-keyword-args-check gf emfun non-keyword-args + applicable-keywords))) (cache-emf gf args emfun) (funcall emfun args)) (apply #'no-applicable-method gf args)))) @@ -2407,6 +2466,7 @@ (%set-method-function method function) (%set-method-fast-function method fast-function) (set-reader-method-slot-name method slot-name) + (%set-function-keywords method nil nil) method)) (defun add-reader-method (class function-name slot-name) @@ -2830,8 +2890,7 @@ ((null tail)) (unless (memq initarg allowable-initargs) (error 'program-error - :format-control "Invalid initarg ~S in call to ~S ~ -with arglist ~S." + :format-control "Invalid initarg ~S in call to ~S with arglist ~S." :format-arguments (list initarg call-site args)))))))) (defun merge-initargs-sets (list1 list2) @@ -2949,7 +3008,8 @@ &rest initargs &key &allow-other-keys)) -(defmethod shared-initialize ((instance standard-object) slot-names &rest initargs) +(defmethod shared-initialize ((instance standard-object) slot-names + &rest initargs) (std-shared-initialize instance slot-names initargs)) (defmethod shared-initialize ((slot slot-definition) slot-names @@ -3372,7 +3432,6 @@ (:method ((method standard-method)) (%function-keywords method))) - (setf *gf-initialize-instance* (symbol-function 'initialize-instance)) (setf *gf-allocate-instance* (symbol-function 'allocate-instance)) (setf *gf-shared-initialize* (symbol-function 'shared-initialize)) _______________________________________________ armedbear-cvs mailing list armedbear-cvs(a)common-lisp.net http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-cvs

2 1

[armedbear-devel] ABCL Debug.assertTrue() assertion failed!
by Santiago Carbonell 17 Jan '12

17 Jan '12

Hi, I'm trying to compile and execute a project that was coded in Lisp in Java using ABCL. When I try to execute it, I always obtain this error when try to execute a defstruct sentence: ABCL Debug.assertTrue() assertion failed! Someone can help me? Thanks

3 2

[armedbear-devel] HEADS-UP: Those following trunk need to remove SLIME/ASDF fasls
by Mark Evenson 16 Jan '12

16 Jan '12

With [r13781][], if one is compiling from trunk one will need to clear any intermediate SLIME/ASDF fasls, as the indices of the CLOS slots have been renumbered. [r13781]: http://bit.ly/xPxljS Under 'NIX, the following will reset things: cmd$ rm -rf ~/.slime ~/.cache

2 1

[armedbear-devel] regression of bordeaux-threads tests on ABCL 1.0.1 (comparing to 1.0.0)
by Anton Vodonosov 12 Jan '12

12 Jan '12

Hello. I am running tests of some lisp libraries on various cl implementations. Just noticed a regression. Here are test logs of the same version of bordeaux-threads: Of ABCL 1.0.0 https://cl-test-grid.appspot.com/blob?key=AMIfv959vw8OTYbBwH_qli8d6EeL6-Roh… of ABCL 1.0.1 https://cl-test-grid.appspot.com/blob?key=AMIfv97tbGEUijVGZDqkxNzUOVSNQ_Fr9… As you see, 1.0.0 passes the tests, while 1.0.1 fails to build them. (But I don't know if it's a bug in ABCL 1.0.1, or it's a bug in bordeaux-threads tests which just wasn't detected by old ABCL). Best regards, - Anton

2 6

[armedbear-devel] Armed Bear Common Lisp abcl-1.0.1 maintenance release
by Mark Evenson 12 Jan '12

12 Jan '12

On behalf of the developers of ABCL (Armed Bear Common Lisp) I'm glad to be able to announce the 1.0.1 release. ABCL is a Common Lisp implementation implemented in Java and running on the JVM, featuring both an interpreter and a compiler. The compiler targets the JVM directly meaning that its output is runnable JVM bytecode. The fact that ABCL is written in Java allows for relatively easy embedding in larger applications. For integration with existing applications ABCL implements Java Specification Request (JSR) 223: Java scripting API. This release squashes bugs in the ABCL 1.0 release, most notably it features a working ABCL-CONTRIB symbol to the ANSI REQUIRE mechanism and it ships with ASDF 2.019. You can find more in the release notes at: http://common-lisp.net/project/armedbear/release-notes-1.0.1.shtml and the list of changes at: http://trac.common-lisp.net/armedbear/browser/tags/1.0.1/abcl/CHANGES Source and binary distribution archives with associated cryptographic signatures can be downloaded in ZIP or gzipped tar from: http://common.lisp.net/project/armedbear/releases/1.0.1 If you have questions regarding use or licensing, or you find issues, please report back to the development list: armedbear-devel at common-lisp dot net

2 3

[armedbear-devel] Welcome to the team: Rudi Schlatte
by Erik Huelsmann 10 Jan '12

10 Jan '12

Rudi Schlatte has been working toward getting us AMOP compatibility. That goal hasn't been reached, but he's very much welcome to join the team! Help improve ABCL any way you can! Thanks for your contributions so far and all those which will come. I've added you to the armedbear group, meaning you should now be able to commit to our repository. BTW: If you feel a patch needs review, you can still send your patches to the list for review and discussion. Bye, Erik.

1 0

[armedbear-devel] Patch for bug 172
by Rudolf Schlatte 10 Jan '12

10 Jan '12

Hi, ; SLIME 2012-01-06 CL-USER> (defgeneric foo (x) (:documentation "Hi there!")) #<STANDARD-GENERIC-FUNCTION FOO {78189538}> CL-USER> (documentation 'foo 'function) "Hi there!" CL-USER> LispObject.java didn't know that things other than Function could be in a symbol's function slot. Regards, Rudi Changes in HEAD Modified src/org/armedbear/lisp/LispObject.java diff --git a/src/org/armedbear/lisp/LispObject.java b/src/org/armedbear/lisp/LispObject.java index ce52169..e0d3f35 100644 --- a/src/org/armedbear/lisp/LispObject.java +++ b/src/org/armedbear/lisp/LispObject.java @@ -658,7 +658,7 @@ public class LispObject //extends Lisp return ((Cons)entry).cdr; } if(docType == Symbol.FUNCTION && this instanceof Symbol) { - Object fn = ((Symbol)this).getSymbolFunction(); + LispObject fn = ((Symbol)this).getSymbolFunction(); if(fn instanceof Function) { DocString ds = fn.getClass().getAnnotation(DocString.class); if(ds != null) { @@ -672,6 +672,9 @@ public class LispObject //extends Lisp return doc; } } + } else if (fn instanceof StandardGenericFunction) { + return StandardGenericFunction.checkStandardGenericFunction(fn) + .slots[StandardGenericFunctionClass.SLOT_INDEX_DOCUMENTATION]; } } return NIL;

1 0

[armedbear-devel] Patch for failing ansi method-combination tests
by Rudolf Schlatte 10 Jan '12

10 Jan '12

Hi, Here's a patch for the newly-faililng ansi tests mentioned on irc, moving creation of short-method-combination objects inline. (The same could be done for long-method-combination objects -- the make-long-method-combination function is a remnant of the time when method combinations were implemented as structures.) Rudi

1 0

[armedbear-devel] HEADS-UP: freezing branch soon for abcl-1.0.1
by Mark Evenson 09 Jan '12

09 Jan '12

I'd like to get a release out for abcl-1.0.1, as we shipped with [several things broken][1] notably the ABCL-CONTRIB. Since everyone seems quite busy, I'd like to volunteer to sign and ship this one, helping to strengthen our release process. I've set the milestone in Trac for the middle of January, but would rather this happen on the order of days. It looks like we're going to be able to get to working with closer-mop with abcl-1.1.0, so I want to separate out a stable ABCL that at least works something like what [the Manual][abcl-1.0-user-manual.pdf] describes. [1]: http://trac.common-lisp.net/armedbear/milestone/1.0.1 [abcl-1.0-user-manual.pdf]: http://abcl-dynamic-install.googlecode.com/files/abcl-20111108a.pdf @Erik: I'll merge the byte array bug you addressed. @Alessio: There's a distribution POM for abcl-contrib ('abcl/contrib/pom.xml') that seems to work. Can you eventually ensure that the update is pushed to Sonatype? I assume we can easily add new artifacts under the GroupID we currently push abcl-1.0.0.jar with, right? Fine touches on the Manual; editing CHANGES; testing of the [abcl-1.0.1 branch][2] are all welcome. I will backport any significant contributions from trunk. And patches are always more than welcome. [2]: http://svn.common-lisp.net/armedbear/branches/1.0.x/abcl/ yers in CONS, Mark <evenson(a)panix.com>

1 1

[armedbear-devel] Reworked patch: convert (long|short)-method-combination into CLOS classes
by Rudolf Schlatte 06 Jan '12

06 Jan '12

Hi, After Mark's question about "what are you really trying to do?" I realized that in clos.lisp we have defun and friends available, so the accessor functions for method combinations can be implemented there. Attached is a reworked patch. I believe that the class definitions need to stay inside StandardClass.lisp, since we can't call ensure-class yet. I also attach a patch that gets rid of the ill-fated EqualSpecializerObject.java and replaces it with 3 lines of Lisp code ... (Thanks for tolerating my stumbling-about in your project, guys..) Rudi

1 0