- armedbear-devel - mailman3.common-lisp.net

[armedbear-devel] Saving stackframes?
by Erik Huelsmann 12 Jul '09

12 Jul '09

When looking at numerous backtraces, I find that the pattern LispThread.execute->Symbol.execute->function.execute happens very often. The only thing Symbol.execute does is forward the call to the function in its function slot. Now, we could save ourselves this stackframe by taking "the stack hit" in LispThread.execute the following way: if (function instanceof Symbol) function.getSymbolFunction().execute() else function.execute() where the execute function in LispThread currently only contains function.execute()... I found our implementation uses a *lot* more stack than the average Java application. This may be a way to reduce that a bit. What about it? Bye, Erik.

1 0

[armedbear-devel] Blog to report on ABCL development progress
by Erik Huelsmann 12 Jul '09

12 Jul '09

Yesterday Tobias Rittweiler brought to my attention that all the good work that's being done on the development of ABCL probably has gone unnoticed in the larger Lisp community: we didn't post our release announcements on usenet (comp.lang.lisp) and we don't have a blog to feed the Planet Lisp syndication with. So, as a first step, I created http://abcl-dev.blogspot.com/ seeding it with a first post. A request has been submitted to add the blog to the Planet Lisp feed syndication. Anybody who has an interest in blogging or submitting a blog once in a while, feel free to step up. The blog is intended to be - weekly or bi-weekly, but not high volume - about the highs and lows that make up the ABCL development experience and progress. Bye, Erik.

1 0

[armedbear-devel] [PATCH] Support for SYNCHRONIZED blocks (and company)
by Erik Huelsmann 11 Jul '09

11 Jul '09

Based on discussion earlier this week, I'd like the following patch to get committed to our trunk. It introduces a new block statement SYNCHRONIZED-ON <object> body and next to that a number of functions: object-wait <object> &optional timeout object-notify <object> object-notify-all <object> So, what's the verdict? Anyway, I plan on including some simple test cases, but ofcourse, if someone feels like doing so, please feel free! Bye, Erik.

4 10

[armedbear-devel] [RFC] Support for 'synchronized' blocks in Lisp code
by Erik Huelsmann 07 Jul '09

07 Jul '09

I propose that we introduce a WITH-EXCLUSIVE-ACCESS form in the EXT package, which takes 1 argument (the second value) and a body (the third value). The form makes sure that the body is evaluated as if it had been called with: synchronized (arg1) { body-to-evaluate; } Except that it implements this in Lisp. This way, our Lisp<>Java interoperability would increase. It would also be an efficient way to guarantee exclusive access when modifying a cross-thread shared resource (such as generic functions). Comments? Bye, Erik.

5 7

[armedbear-devel] Extensible sequences
by Alessio Stalla 07 Jul '09

07 Jul '09

Hello, has anyone ever thought of adding extensible sequences[1] to abcl? Given that our implementation of sequences is copied/adapted from CMUCL, and extensible sequences have been implemented in SBCL which is itself a fork of CMUCL, it may be as easy as copy-pasting from SBCL with minor adaptations. Extensible sequences would allow to easily make Java collections first-class citizens in our Lisp world. This would have a number of benefits, last but not least the fact that we could easily use Clojure collections with abcl. Unfortunately I have not the time to do this myself, but if someone likes the idea and is willing to contribute... Cheers, Alessio [1] http://www.doc.gold.ac.uk/~mas01cr/papers/ilc2007/sequences-20070301.pdf

2 2

[armedbear-devel] armedbear-devel@common-lisp.net
by Anton Vodonosov 06 Jul '09

06 Jul '09

Hello, According to the project page, there is ansi test suite. But 0.15.0 package from sourceforge doesn't contain it. Also I can't find on the project page any reference to source code repository. Is it really the current state of affairs, or I missing something? Best regards, - Anton

2 1

[armedbear-devel] ansi tests
by Anton Vodonosov 05 Jul '09

05 Jul '09

on Sunday, July 5, 2009, 3:27:37 PM Ville wrote: > On Sun, Jul 5, 2009 at 1:51 PM, Anton > Vodonosov<avodonosov(a)gmail.com> wrote: >> According to the project page, there is ansi test suite. >> But 0.15.0 package from sourceforge doesn't contain it. > You need to get it separately, from > svn://common-lisp.net/project/ansi-test/svn/trunk/ansi-tests I checked-out the suite, but it seems to be insufficient. How to run the tests? ant in the abcl directory suggest to use "ant acbl.test.java". It fails with: BUILD FAILED C:\usr\unpacked\abcl\abcl-src-0.15.0-original\build.xml:481: srcdir "C:\usr\unpacked\abcl\abcl-src-0.15.0-original\test\src" does not exist! The project page suggests to run ant test.ansi.interpreted ant test.ansi.compiled This fails with [java] Debugger invoked on condition of type FILE-ERROR: [java] File not found: C:\usr\unpacked\abcl\abcl-src-0.15.0-original/test/lisp/ansi/ansi-tests-interpreted.lisp There is indeed no directory "test" in the 0.15.0 package I downloaded from sourceforge. Best regards, - Anton

1 0

[armedbear-devel] Franz-style Gates implementation
by Mark Evenson 04 Jul '09

04 Jul '09

Tobias Rittweiler writes: > The attached patch adds Gates to ABCL, inspired by what Franz Allegro > Common Lisp provides. > > A GATE is an object with two states, open and closed. It is > created with MAKE-GATE. Its state can be opened (OPEN-GATE) or > closed (CLOSE-GATE) and can be explicitly tested with > GATE-OPEN-P. Usually though, a thread awaits the opening of a > gate by WAIT-OPEN-GATE. > > This will be used to implement the threading communication style in > ABCL's Swank backend. > > I'm not particularly good at writing multiprocessing, or Java code. So > please review carefully. Tobias wrote this to support his version of a multi-threaded SLIME backend, and has proposed it for inclusion in ABCL. When I get some time, I'll do some tests, but post the patch here in case it helps someone else out before that time or if their is any feedback. As it stands, the Gates implementation would go in the EXTENSIONS package. Mark -- "A screaming comes across the sky. It has happened before, but there is nothing to compare to it now."

4 6

[armedbear-devel] Threading issue with ERROR (?)
by Erik Huelsmann 04 Jul '09

04 Jul '09

I have an application which uses a combination of DEFINE-CONDITION, ERROR and HANDLER-CASE to handle certain exceptional situations. The call sequence basically looks like this: (when loading the file:) (define-condition model-error (error) ()) (defun foo1 (arg) (if arg (error 'model-error) 3)) (defun foo2 (arg) (handler-case (foo1 arg) (model-error () 0.0d0)) and then, from different threads: (foo2 <some value or NIL>) When I do this in a single-threaded application all goes well. When I do this in a multi threaded application with a single calculation (lisp) thread, all goes well as well. When I do this in a multi threaded application with multiple calculation threads (lisp), I get a NullPointerException somewhere deep in our CLOS code... Has anybody experienced the same? Bye, Erik.

1 0

[armedbear-devel] Patch to add multi-threading to ABCL SLIME CVS HEAD
by Mark Evenson 02 Jul '09

02 Jul '09

Attached is a patch against SLIME CVS HEAD to implement multi-threading (aka the :spawn *COMMUNICATION-STYLE*) as a default in ABCL. In addition this patch muffles various STYLE-WARNING compilation messages via DECLARE forms. Among other things, this seems to fix the fugliness around where *STANDARD-OUTPUT* ends up and the missing CR (or LF) in the NIL *COMMUNICATION-STYLE*. This patch has been tested against ABCL 0.16.0-dev as of [svn r12022] with Emacs 22.3 under OS X. I didn't need to do much to the existing code except fix a typo while comparing against the current 'swank-sbcl.lisp' version, making me somewhat suspicious of why that code was not used in the first place (did someone just cut and paste the SBCL implementation without trying to get it to work? But thanks to whoever got it that far!) -- "A screaming comes across the sky. It has happened before, but there is nothing to compare to it now." diff -r 2225a8f2d322 -r 3c562ce589df swank-abcl.lisp --- a/swank-abcl.lisp Wed Jul 01 05:38:54 2009 +0200 +++ b/swank-abcl.lisp Wed Jul 01 11:06:42 2009 +0200 @@ -17,6 +17,7 @@ (defun sys::break (&optional (format-control "BREAK called") &rest format-arguments) (let ((*saved-backtrace* (backtrace-as-list-ignoring-swank-calls))) + (declare (ignore *saved-backtrace*)) (with-simple-restart (continue "Return from BREAK.") (invoke-debugger (sys::%make-condition 'simple-condition @@ -42,10 +43,16 @@ ;(defun class-finalized-p (class) t) -(defun slot-definition-documentation (slot) #+nil (documentation slot 't)) -(defun slot-definition-type (slot) t) -(defun class-prototype (class)) -(defun generic-function-declarations (gf)) +(defun slot-definition-documentation (slot) + (declare (ignore slot)) + #+nil (documentation slot 't)) +(defun slot-definition-type (slot) + (declare (ignore slot)) + t) +(defun class-prototype (class) + (declare (ignore class))) +(defun generic-function-declarations (gf) + (declare (ignore gf))) (defun specializer-direct-methods (spec) (mop::class-direct-methods spec)) (defun slot-definition-name (slot) @@ -61,9 +68,11 @@ (mop::%method-function method)) (defun slot-boundp-using-class (class object slotdef) + (declare (ignore class)) ; FIXME (system::slot-boundp object (slot-definition-name slotdef))) (defun slot-value-using-class (class object slotdef) + (declare (ignore class)) ; FIXME (system::slot-value object (slot-definition-name slotdef))) (import-to-swank-mop @@ -119,7 +128,7 @@ (defimplementation preferred-communication-style () - nil) + :spawn) (defimplementation create-socket (host port) (ext:make-server-socket port)) @@ -483,8 +492,8 @@ ;;;; Multithreading -(defimplementation startup-multiprocessing () - #+nil(mp:start-scheduler)) +#+nil ; Already started +(defimplementation startup-multiprocessing (continuation)) (defimplementation spawn (fn &key name) (ext:make-thread (lambda () (funcall fn)) :name name)) @@ -513,7 +522,23 @@ (defimplementation thread-status (thread) (format nil "Thread is ~:[dead~;alive~]" (ext:thread-alive-p thread))) +;; XXX should be a weak hash table +(defparameter *thread-description-map* (make-hash-table)) + +(defvar *thread-description-map-lock* + (ext:make-mutex)) + +(defimplementation thread-description (thread) + (ext:with-mutex (*thread-description-map-lock*) + (or (gethash thread *thread-description-map*) + "No description available."))) + +(defimplementation set-thread-description (thread description) + (ext:with-mutex (*thread-description-map-lock*) + (setf (gethash thread *thread-description-map*) description))) + (defimplementation make-lock (&key name) + (declare (ignore name)) (ext:make-thread-lock)) (defimplementation call-with-lock-held (lock function) @@ -525,8 +550,11 @@ (defimplementation all-threads () (copy-list (ext:mapcar-threads #'identity))) +(defimplementation thread-alive-p (thread) + (member thread (all-threads))) + (defimplementation interrupt-thread (thread fn) - (ext:interrupt-thread thread fn)) + (ext:interrupt-thread thread fn)) (defimplementation kill-thread (thread) (ext:destroy-thread thread)) @@ -542,14 +570,13 @@ (setf (getf (gethash thread *thread-props*) 'mailbox) (make-mailbox))))) -(defimplementation send (thread object) +(defimplementation send (thread message) (let ((mbox (mailbox thread))) (ext:with-mutex ((mailbox-mutex mbox)) (setf (mailbox-queue mbox) (nconc (mailbox-queue mbox) (list message)))))) -#+(or) -(defimplementation receive-if (thread &optional timeout) +(defimplementation receive-if (test &optional timeout) (let* ((mbox (mailbox (current-thread)))) (assert (or (not timeout) (eq timeout t))) (loop @@ -561,9 +588,7 @@ (setf (mailbox-queue mbox) (nconc (ldiff q tail) (cdr tail))) (return (car tail)))) (when (eq timeout t) (return (values nil t))) - ;;(java:jcall (java:jmethod "java.lang.Object" "wait") - ;; (mailbox-mutex mbox) 1000) - )))) + (sleep .05))))) (defimplementation quit-lisp () (ext:exit))

2 3