armedbear-devel

armedbear-devel@common-lisp.net

1 participants
1200 discussions

Re: [armedbear-devel] [armedbear-cvs] r13219 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 13 Feb '11

13 Feb '11

Some testing showed that this commit increases instance creation throughput by 100% (ie. doubles the number of instances created in a certain amount of time.) With this change, I was creating 1000 instances of the slot-less class A in 0.020 and 0.018 seconds. That's still way too slow: clisp does it in 0.007s but anyway, before the change it was 0.038. Would be nice to find out how the others get their performance from - which tricks and optimizations. Bye, Erik. On Sun, Feb 13, 2011 at 10:08 PM, Erik Huelsmann <ehuelsmann(a)common-lisp.net> wrote: > Author: ehuelsmann > Date: Sun Feb 13 16:08:31 2011 > New Revision: 13219 > > Log: > Add caching to CHECK-INITARGS: cache sets of allowable initargs > per class. > > Note: This change *only* implements caching for "case 1" out of the 4 > cases that check-initargs now supports. (Case 1 being instance creation.) > > Modified: > trunk/abcl/src/org/armedbear/lisp/clos.lisp > > Modified: trunk/abcl/src/org/armedbear/lisp/clos.lisp > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/clos.lisp (original) > +++ trunk/abcl/src/org/armedbear/lisp/clos.lisp Sun Feb 13 16:08:31 2011 > @@ -693,7 +693,8 @@ > (let ((class (std-allocate-instance +the-standard-class+))) > (check-initargs (list #'allocate-instance #'initialize-instance) > (list* class initargs) > - class t initargs) > + class t initargs > + *make-instance-initargs-cache*) > (%set-class-name name class) > (%set-class-layout nil class) > (%set-class-direct-subclasses () class) > @@ -740,6 +741,10 @@ > (list (find-class 'sequence) > (find-class 'java:java-object))) > > +(defvar *make-instance-initargs-cache* > + (make-hash-table :test #'eq) > + "Cached sets of allowable initargs, keyed on the class they belong to.") > + > (defun ensure-class (name &rest all-keys &key metaclass &allow-other-keys) > ;; Check for duplicate slots. > (remf all-keys :metaclass) > @@ -786,11 +791,14 @@ > new-class)) > (t > ;; We're redefining the class. > + (remhash old-class *make-instance-initargs-cache*) > (%make-instances-obsolete old-class) > (setf (class-finalized-p old-class) nil) > - (check-initargs (list #'allocate-instance #'initialize-instance) > + (check-initargs (list #'allocate-instance > + #'initialize-instance) > (list* old-class all-keys) > - old-class t all-keys) > + old-class t all-keys > + nil) > (apply #'std-after-initialization-for-classes old-class all-keys) > old-class))) > (t > @@ -1585,10 +1593,31 @@ > all of the keyword arguments defined for the ~ > generic function." method-lambda-list name))))) > > +(defvar *gf-initialize-instance* nil > + "Cached value of the INITIALIZE-INSTANCE generic function. > +Initialized with the true value near the end of the file.") > +(defvar *gf-allocate-instance* nil > + "Cached value of the ALLOCATE-INSTANCE generic function. > +Initialized with the true value near the end of the file.") > +(defvar *gf-shared-initialize* nil > + "Cached value of the SHARED-INITIALIZE generic function. > +Initialized with the true value near the end of the file.") > +(defvar *gf-reinitialize-instance* nil > + "Cached value of the REINITIALIZE-INSTANCE generic function. > +Initialized with the true value near the end of the file.") > + > (declaim (ftype (function * method) ensure-method)) > (defun ensure-method (name &rest all-keys) > (let ((method-lambda-list (getf all-keys :lambda-list)) > (gf (find-generic-function name nil))) > + (when (or (eq gf *gf-initialize-instance*) > + (eq gf *gf-allocate-instance*) > + (eq gf *gf-shared-initialize*) > + (eq gf *gf-reinitialize-instance*)) > + ;; ### Clearly, this can be targeted much more exact > + ;; as we only need to remove the specializing class and all > + ;; its subclasses from the hash. > + (clrhash *make-instance-initargs-cache*)) > (if gf > (check-method-lambda-list name method-lambda-list > (generic-function-lambda-list gf)) > @@ -2565,18 +2594,11 @@ > ;; methods, along with the predefined initialization argument :ALLOW-OTHER-KEYS." > ;; 7.1.2 > > -(defun check-initargs (gf-list args instance shared-initialize-param initargs) > - "Checks the validity of `initargs' for the generic functions in `gf-list' when > -called with `args' by calculating the applicable methods for each gf. > -The applicable methods for SHARED-INITIALIZE based on `instance', > -`shared-initialize-param' and `initargs' are added to the list of > -applicable methods." > - (when (oddp (length initargs)) > - (error 'program-error > - :format-control "Odd number of keyword arguments.")) > - (unless (getf initargs :allow-other-keys) > - (let* ((methods > - (nconc > +(defun calculate-allowable-initargs (gf-list args instance > + shared-initialize-param > + initargs) > + (let* ((methods > + (nconc > (compute-applicable-methods #'shared-initialize > (list* instance > shared-initialize-param > @@ -2584,26 +2606,48 @@ > (mapcan #'(lambda (gf) > (compute-applicable-methods gf args)) > gf-list))) > - (method-keyword-args > - (reduce #'merge-initargs-sets > - (mapcar #'method-lambda-list methods) > - :key #'extract-lambda-list-keywords > - :initial-value nil)) > - (slots-initargs > - (mapappend #'slot-definition-initargs > - (class-slots (class-of instance)))) > - (allowable-initargs > - (merge-initargs-sets > - (merge-initargs-sets slots-initargs method-keyword-args) > - '(:allow-other-keys)))) ;; allow-other-keys is always allowed > - (unless (eq t allowable-initargs) > - (do* ((tail initargs (cddr tail)) > - (initarg (car tail) (car tail))) > - ((null tail)) > - (unless (memq initarg allowable-initargs) > - (error 'program-error > - :format-control "Invalid initarg ~S." > - :format-arguments (list initarg)))))))) > + (method-keyword-args > + (reduce #'merge-initargs-sets > + (mapcar #'method-lambda-list methods) > + :key #'extract-lambda-list-keywords > + :initial-value nil)) > + (slots-initargs > + (mapappend #'slot-definition-initargs > + (class-slots (class-of instance))))) > + (merge-initargs-sets > + (merge-initargs-sets slots-initargs method-keyword-args) > + '(:allow-other-keys)))) ;; allow-other-keys is always allowed > + > +(defun check-initargs (gf-list args instance > + shared-initialize-param initargs > + cache) > + "Checks the validity of `initargs' for the generic functions in `gf-list' > +when called with `args' by calculating the applicable methods for each gf. > +The applicable methods for SHARED-INITIALIZE based on `instance', > +`shared-initialize-param' and `initargs' are added to the list of > +applicable methods." > + (when (oddp (length initargs)) > + (error 'program-error > + :format-control "Odd number of keyword arguments.")) > + (unless (getf initargs :allow-other-keys) > + (multiple-value-bind (allowable-initargs present-p) > + (when cache > + (gethash (class-of instance) cache)) > + (unless present-p > + (setf allowable-initargs > + (calculate-allowable-initargs gf-list args instance > + shared-initialize-param initargs)) > + (when cache > + (setf (gethash (class-of instance) cache) > + allowable-initargs))) > + (unless (eq t allowable-initargs) > + (do* ((tail initargs (cddr tail)) > + (initarg (car tail) (car tail))) > + ((null tail)) > + (unless (memq initarg allowable-initargs) > + (error 'program-error > + :format-control "Invalid initarg ~S." > + :format-arguments (list initarg)))))))) > > (defun merge-initargs-sets (list1 list2) > (cond > @@ -2648,7 +2692,8 @@ > (let ((instance (std-allocate-instance class))) > (check-initargs (list #'allocate-instance #'initialize-instance) > (list* instance initargs) > - instance t initargs) > + instance t initargs > + *make-instance-initargs-cache*) > (apply #'initialize-instance instance initargs) > instance)) > > @@ -2670,7 +2715,8 @@ > ;; it received." > (defmethod reinitialize-instance ((instance standard-object) &rest initargs) > (check-initargs (list #'reinitialize-instance) (list* instance initargs) > - instance () initargs) > + instance () initargs > + nil) > (apply #'shared-initialize instance () initargs)) > > (defun std-shared-initialize (instance slot-names all-keys) > @@ -2761,7 +2807,8 @@ > (class-slots (class-of new)))))) > (check-initargs (list #'update-instance-for-different-class) > (list old new initargs) > - new added-slots initargs) > + new added-slots initargs > + nil) > (apply #'shared-initialize new added-slots initargs))) > > ;;; make-instances-obsolete > @@ -2793,7 +2840,8 @@ > (check-initargs (list #'update-instance-for-redefined-class) > (list* instance added-slots discarded-slots > property-list initargs) > - instance added-slots initargs) > + instance added-slots initargs > + nil) > (apply #'shared-initialize instance added-slots initargs)) > > ;;; Methods having to do with class metaobjects. > @@ -3101,6 +3149,11 @@ > ;; FIXME > (defgeneric function-keywords (method)) > > + > +(setf *gf-initialize-instance* (symbol-function 'initialize-instance)) > +(setf *gf-allocate-instance* (symbol-function 'allocate-instance)) > +(setf *gf-shared-initialize* (symbol-function 'shared-initialize)) > +(setf *gf-reinitialize-instance* (symbol-function 'reinitialize-instance)) > (setf *clos-booting* nil) > > (defgeneric class-prototype (class)) > > _______________________________________________ > armedbear-cvs mailing list > armedbear-cvs(a)common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-cvs >

1 0

[armedbear-devel] couple of difficult to debug clos situations
by Alan Ruttenberg 13 Feb '11

13 Feb '11

(defclass a (b)) (make-instance 'a) ; Evaluation aborted on NIL. ;; no backtrace in slime The problem is that b is not defined, but the error makes this difficult to discern. --- Trying to fix the problem in some ways leads to more: (defclass a1 (b1)) (defclass b2 ()) CL-USER> (make-instance 'a1) ; Evaluation aborted on NIL. ;; no backtrace in slime CL-USER> (defclass a1 (b2)) ; Evaluation aborted on NIL. ;; no backtrace in slime --- (defclass a3 (b3)) (mop::class-prototype (find-class 'a3)) ;; here we get a backtrace: #<STANDARD-CLASS A3 {1E8E471}> is not finalized. However it is hard to figure out what the problem is. Now try to fix it: (defclass b3 ()) (mop::class-prototype (find-class 'a3)) ;; still get "is not finalized" error (make-instance 'a3) ;; succeeds (mop::class-prototype (find-class 'a3)) ;; now it succeeds -Alan

2 1

[armedbear-devel] Clarification proposal for CLHS 22.3
by Didier Verna 11 Feb '11

11 Feb '11

Hello, I'm planning to submit a CDR for clarifying some aspects of the syntax and semantics of format directives. As this could involve modifying ABCL's behavior, I'd like to have some comments before I submit a first document. I'm attaching a plain text version below (the source is in Texinfo format). -- Resistance is futile. You will be jazzimilated. Scientific site: http://www.lrde.epita.fr/~didier Music (Jazz) site: http://www.didierverna.com

1 0

[armedbear-devel] Maven & ABCL
by Alessio Stalla 11 Feb '11

11 Feb '11

Hello folks, I'm in the process of integrating Dynaspring [1] in a yet-to-be-released open source utilities project developed together with some (ex-)colleagues. The utilities project is built with Maven, so in order to use Dynaspring (and transitively ABCL) I had to write a simple pom.xml (Maven project descriptor) for ABCL to make it known to Maven (i.e. usable as a dependency in Maven projects). For the other developers' convenience, it would be nice if the poms were available from a publicly accessible Maven repository (Sonatype provides a free one, [2]). I'm going to create one there for Dynaspring, but if you're ok with it, I can create a separate one for ABCL, and from now on, publish ABCL releases there as well. What do you think? Bye, Alessio [1] http://code.google.com/p/dynaspring/ [2] https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+…

4 14

[armedbear-devel] Release signing (was Maven & ABCL)
by Erik Huelsmann 11 Feb '11

11 Feb '11

>> Morale: this is not terribly complicated, and it would make ABCL >> available through another distribution channel. OTOH, I can't hide the >> fact that - besides my own personal convenience for my shared project >> - probably no-one is using ABCL in Maven projects right now, and >> having ABCL released through Maven would complicate its release >> process, not much for technical reasons but for organizational ones >> (e.g. who keeps ABCL's GPG key? How is it managed?). > > Currently Erik maintains the GPG key we currently use for signing. Does > anyone have a model by which we could somehow share it? It might be > nice to start "rotating" the responsibility for the releases among the > four core committers to help take some work off of Erik's plate. Yes. The key I use for signing as really my own though: I use it to sign all packages I put up for distribution: usocket (when I last did), cl-irc, ABCL, Subversion, py-configparser and maybe others. Within the Subversion project we had a discussion about having a project key or not. We considered that a project key would have to be passed from one to another person, increasing chances of the key getting compromised. Also, the process with a single key means single point of failure. What we considered back then - and are still doing today - is that as many committers as possible sign the release. Each committer signs the variants of the release he/she verified and tested to work well. (There is a tgz and a zip release, exactly like ours, one meant for *nix, the other for Windows). Having many committers sign each release reduces the dependency on every single one of them, but also allows others to join in and maybe have some of the older contributors flow out. Due to the fact that the core stays the same from one release to another, the signatures are still very well recognizable as "the official Subversion release with its regular signatures". I'm interested in your opinions (and how this might work with Maven). Do you think this approach would help to lift work off my shoulders? Do you think it's a good idea to make the signatures "mean" anything? Do you think our group of contributors is large enough to start collecting multiple signatures at all? By the way, I think it's really great that we're actually having this discussion. To me it says something about the maturity of the ABCL project and the attitude of the committers in its community: we're a group dedicated to setting steps in the direction of delivering mature software with solid processes to ensure that our users are getting the quality they deserve. Bye, Erik.'

2 1

Re: [armedbear-devel] [armedbear-cvs] r13209 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 08 Feb '11

08 Feb '11

This fixes the regression I introduced a few days ago. Bye, Erik. On Tue, Feb 8, 2011 at 10:46 PM, Erik Huelsmann <ehuelsmann(a)common-lisp.net> wrote: > Author: ehuelsmann > Date: Tue Feb 8 16:46:47 2011 > New Revision: 13209 > > Log: > Add documentation to STD-SHARED-INITIALIZE and > add initarg checking to REINITIALIZE-INSTANCE. > > Modified: > trunk/abcl/src/org/armedbear/lisp/clos.lisp > > Modified: trunk/abcl/src/org/armedbear/lisp/clos.lisp > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/clos.lisp (original) > +++ trunk/abcl/src/org/armedbear/lisp/clos.lisp Tue Feb 8 16:46:47 2011 > @@ -2650,18 +2650,23 @@ > ;; slots should be initialized according to their initforms), and the initargs > ;; it received." > (defmethod reinitialize-instance ((instance standard-object) &rest initargs) > + (check-initargs (list #'reinitialize-instance) (list* instance initargs) > + instance () initargs) > (apply #'shared-initialize instance () initargs)) > > (defun std-shared-initialize (instance slot-names all-keys) > (when (oddp (length all-keys)) > (error 'program-error :format-control "Odd number of keyword arguments.")) > + ;; do a quick scan of the arguments list to see if it's a real > + ;; 'initialization argument list' (which is not the same as > + ;; checking initarg validity > (do* ((tail all-keys (cddr tail)) > - (initarg (car tail) (car tail))) > + (initarg (car tail) (car tail))) > ((null tail)) > (when (and initarg (not (symbolp initarg))) > (error 'program-error > - :format-control "Invalid initarg ~S." > - :format-arguments (list initarg)))) > + :format-control "Invalid initarg ~S." > + :format-arguments (list initarg)))) > (dolist (slot (class-slots (class-of instance))) > (let ((slot-name (slot-definition-name slot))) > (multiple-value-bind (init-key init-value foundp) > > _______________________________________________ > armedbear-cvs mailing list > armedbear-cvs(a)common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-cvs >

1 0

[armedbear-devel] Cannot RENAME-FILE to a file without extensions
by Theam Yong Chew 07 Feb '11

07 Feb '11

Dear developers of ABCL, I found a problem recently in both ABCL 0.21.0 and 0.24.0, where I could not rename a file to any file without an extension. For example, with an existing file /tmp/a.txt, CL-USER> (rename-file "/tmp/a.txt" "/tmp/a") #P"/tmp/a.txt" #P"/tmp/a.txt" #P"/tmp/a.txt" The file does not change at all. With any extension, everything works as expected. Thanks in advance. Yong.

2 1

[armedbear-devel] compiler-pass2, dump-form and the dreaded 64k constant string size limit
by Alessio Stalla 06 Feb '11

06 Feb '11

I found another limitation caused by the class file format: constant strings are limited to a size of 64k bytes. The compiler uses dump-form to externalize objects to FASLs, and this means that not only literal strings are limited to 64k, but every object that is dumped is limited by its printed representation. I found that out while trying to compile closure-html [1], which creates a big vector to hold generated parser states and stores it as a constant in the code [2]. So we need to split big dumped forms over multiple strings. I'll attempt a solution in the following days. Bye, Alessio [1] http://common-lisp.net/project/closure/closure-html [2] Incidentally, I also found out that dump-vector causes a stack overflow error for such a vector (probably because it contains other vectors that form circular references). What's the reason for dump-vector not to use the normal vector printing code?

1 0

[armedbear-devel] (quit) in slime doesn't
by Alan Ruttenberg 03 Feb '11

03 Feb '11

CL-USER> (quit) ; Evaluation aborted on NIL.

2 1

[armedbear-devel] (defstruct (teststruct (:type list) :named) testslot)))
by Alan Ruttenberg 03 Feb '11

03 Feb '11

(defstruct (teststruct (:type list) :named) testslot))) causes the following defun to be compiled: (DEFUN NIL (SYSTEM::INSTANCE) (ELT SYSTEM::INSTANCE 0)) That shouldn't be. Particularly if (fdefinition nil) gives an error. -Alan

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

armedbear-devel