- armedbear-devel - mailman3.common-lisp.net

[armedbear-devel] ABCL basics
by dusan lukic 05 Nov '09

05 Nov '09

Hi all, with your help, I managed to create abcl.jar file, and now I need some basic knowledge of using it. I would like to know how to compile Lisp code (in a form of String or text file) and call it from Java code. I would also like to get some basic idea of which classes are defined in the abcl.jar file, and what is their purpose and what can I do with them. Furthermore, I would like to obtain some abcl help (it can be online, too), which contain descriptions of abcl classes and their methods, fields, stuff like that. Can anyone point me to some documentation or give some guidelines? Thaks.

2 1

[armedbear-devel] Fwd: [j-devel] Improving startup time: sanity check
by Erik Huelsmann 03 Nov '09

03 Nov '09

forwarding ---------- Forwarded message ---------- From: Alessio Stalla <alessiostalla(a)gmail.com> Date: Wed, Oct 28, 2009 at 11:20 PM Subject: Re: [j-devel] Improving startup time: sanity check To: Erik Huelsmann <ehuels(a)gmail.com> Cc: armedbear-j-devel(a)lists.sourceforge.net, Alex Muscar <muscar(a)gmail.com> On Wed, Oct 28, 2009 at 9:15 PM, Erik Huelsmann <ehuels(a)gmail.com> wrote: > Last weekend, we experimented with better autoloading. It turned out > to strip roughly .4 seconds from a cold startup time of 1.7s, making > it a 25% improvement. > > However, the reason we started out with the startup time improvements > in the first place was the ABCL startup time on Google App Engine. It > turns out that our CPU usage during startup hasn't really decreased > much (as per their benchmark indicator - they can't really give an > actual figure). > > So, I asked for advice on #appengine (on freenode). Their reaction was > "we can't imagine the startup time being related to the size of the > JAR" even though Peter Graves calculated a 34% ratio between ABCL and > Clojure jar sizes and a 35% ratio between startup times - that looks > like a linear match. Their reaction continued "you're probably just > doing too much work during the init() phase." > > The init() phase is where the ABCL environment gets loaded and all > function objects get created. > > Let's assume for a second they're right. In that case we must assume > it's not I/O holding us up: it's the work the CPU must do to get us up > and running. If that's true, profiling the application should tell us > something about the bottlenecks we're running into. I happen to have > done quite a number of such profiles in the course of last week. The > conclusion which stands out is that ABCL - during the startup process > - spends ~ 40% of its time finding class constructors: the main > component of creating function objects. > > This brought me to the conclusion that our startup process could be > much faster, if we decided to delay function object creation until the > function is actually used: we would eliminate the need to construct > function objects until they're used instead of creating them when > their siblings are requested to be loaded. > > The idea is to create another Autoload derivative which will be > "installed" in the appropriate places which, when invoked, loads the > actual class from the byte array. I'm hoping this will cause a more > equally spread "initialization load". The performance hit will only be > the first call to the function: after it has been converted from the > byte array, the autoload object will remove itself from the function > call chain. > > So, how about it? Comments most welcome! I have mixed feelings about the idea. I think it's clever; but I also think we (I, at least) need more data to know if it will be actually beneficial. If the goal is speeding up startup time in a context like AppEngine - where not only Lisp, but the whole user application will be loaded from scratch from time to time - then it is critical to know how many Lisp functions a generic application uses on average (both directly and indirectly). If it turns up that, say, 50% of Lisp is commonly used, then no matter how clever an autoloading scheme you implement, you'll cut loading times only by roughly 50% at best. If getting constructors through reflection is really the bottleneck, and if we determine that using new instead of reflection is significantly faster (from a quick test of mine, it seems it *really* is [1]), then it might be sensible to avoid reflection altogether and devise another scheme. For example, the compiler-generated class X could contain in its static initialization block the equivalent of something like Lisp.someThreadLocal.set(new X()) and loadCompiledFunction or what it is could just fetch the instance from the threadlocal; not very elegant, but if it speeds things up... Alessio [1] this is the astounding result on a couple of runs on 50000 iterations (test files attached): REFLECTION: 16262373155 NEW: 84267527 % SLOWER: 19298 REFLECTION: 15917190176 NEW: 103681915 % SLOWER: 15351 REFLECTION: 15838714133 NEW: 77235481 % SLOWER: 20507 (times in ns) i.e. reflection as we use it is roughly 150-200 times slower than new and that's on a very simple class with no superclasses and a single constructor! The test might be wrong as I wrote it quickly and it's quite tricky. It uses the very same classloader of abcl, though (copy-pasted).

3 3

[armedbear-devel] Focusing 0.18 efforts
by Erik Huelsmann 03 Nov '09

03 Nov '09

Today, I branched for 0.17 (to be released soon), meaning that trunk has become free for 0.18 development. Personally, I found there are a number of items open any one of which could become part of our 0.18 effort. These are the points I identified: * Investigate and improve startup performance * CLOS conformance improvements (including define-method-combination support?) * Cleanup of Load.java - which would allow loading compressed fasls off streams * Gray stream compatibility finalization [we're 99% compatible, but FUNDAMENTAL-STREAM should be recognized as a subtype of STREAM] * Some random other stuff that comes along Do you have your own, or opinions on the points I mentioned above? Let's hear it! Bye, Erik.

2 3

[armedbear-devel] One more change for 0.17: FASL format update
by Erik Huelsmann 03 Nov '09

03 Nov '09

During the coming into existence of 0.17, there was an API change with respect to binding specials. This api change allows quick local access to the binding generated. However, the function for which the api signature is changed, is part of our generated .cls files (FASLs). Hence, I conclude we need a FASL version increment before 0.17 - which hasn't happened yet. Regards, Erik.

1 0

[armedbear-devel] Fw: [jvm-l] Re: Some Array vs GETFILED access times
by logicmoo＠gmail.com 01 Nov '09

01 Nov '09

----- Original Message ----- From: "Charles Oliver Nutter" <headius(a)headius.com> To: <jvm-languages(a)googlegroups.com> Sent: Sunday, November 01, 2009 8:47 PM Subject: [jvm-l] Re: Some Array vs GETFILED access times None of your results are too surprising to me. In JRuby, we moved several structures from encapsulating an array to using differently-sized "slotted" objects, with performance registering much better as a result. Some of that was due to the lack of boundschecks on the arrays, but another portion was probably due to the reduced size of an object + reference versus object + reference + array. Some comments inline below. On Sun, Nov 1, 2009 at 7:48 PM, <logicmoo(a)gmail.com> wrote: > public class ArrayVsClass { > > public static void main(String[] args) { > long lVectorStartTime = System.currentTimeMillis(); > int iterations = Integer.MAX_VALUE; > while (iterations-- > 0) { > // int iterations2 = 10; > //while (iterations2-- > 0) > { > //testArray(); // ARRAY > // vs > //testGETFIELD(); // GETFIELD > // vs > testIBean(); // INVOKE INTERFACE > // vs > //testBean(); // INVOKE VIRTUAL > // vs > //testABean(); // INVOKE VIRTUAL POSSIBLY THROW > // vs > //testSlots(); // INVOKE FOR AVALUE > } > } > long lVectorRunTime = System.currentTimeMillis() - lVectorStartTime; > System.out.println("Bench time: " + lVectorRunTime); > > } Because of optimization effects, you should try running them all together in the same benchmark in varying orders. Short benchmarks like these can skew actual results because only a small subset of the full code needs to be considered for optimization. > // SLOTS time: 33157,33250,33156 > public static void testSlots() { > ClassWithSlots oneSlot = new ClassWithSlots(6); ... > // Array time: 18438,18437,18422 > public static void testArray() { > final long[] accessArray = new long[] { 6 }; Not too surprising; you're paying the cost of the array plus the cost of the virtual invocation. So even after inlining, you've got something like boundscheck + deref + virtual call. > // GETFIELD time: 14688,14531,14453 > public static void testGETFIELD() { > ClassWithOneSlot oneSlot = new ClassWithOneSlot(6); ... > // INVOKE VIRTUAL time: 14750,14594,14719 > public static void testBean() { > ClassWithOneSlot oneSlot = new ClassWithOneSlot(6); This is exactly the pattern we use in JRuby for heap-based scopes. We have from ZeroVarDynamicScope up to FourVarDynamicScope and then it falls over into an array-based version. Because we can statically tell how many variable slots we'll need in most Ruby scopes, this ended up being a big perf improvement for us. > // INVOKE INTERFACE time: 14469,14610,14859 > public static void testIBean() { > IBeanWithOneSlot oneSlot = new ClassWithOneSlot(6); > > int iterations = Integer.MAX_VALUE; > long result = 0; > while (iterations-- > 0) { > result += oneSlot.getValue(); > } > } invokeinterface ends up as fast as invokevirtual once it's been inlined, so this is no surprise. > // INVOKE VIRTUAL POSSIBLY THROW time: 14641,14594,14547 > public static void testABean() { > AClassWithOneSlot oneSlot = new ClassWithOneSlot(6); Exception-handling paths not followed do not impact performance, so this is also not surprising. Try having one out of the N invocations trigger the exception and watch the perf change drastically from then on. - Charlie --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "JVM Languages" group. To post to this group, send email to jvm-languages(a)googlegroups.com To unsubscribe from this group, send email to jvm-languages+unsubscribe(a)googlegroups.com For more options, visit this group at http://groups.google.com/group/jvm-languages?hl=en -~----------~----~----~----~------~----~------~--~---

1 0

[armedbear-devel] Some Array vs GETFILED access times
by logicmoo＠gmail.com 01 Nov '09

01 Nov '09

ABCL, For implementing MOP-like objects these times are something to consider. What I draw from it is when not messing with arrays (array bounds checking). Every case is better than. JVM-L, Do these tests with times make sense? package ArrayTests; public class ArrayVsClass { public static void main(String[] args) { long lVectorStartTime = System.currentTimeMillis(); int iterations = Integer.MAX_VALUE; while (iterations-- > 0) { // int iterations2 = 10; //while (iterations2-- > 0) { //testArray(); // ARRAY // vs //testGETFIELD(); // GETFIELD // vs testIBean(); // INVOKE INTERFACE // vs //testBean(); // INVOKE VIRTUAL // vs //testABean(); // INVOKE VIRTUAL POSSIBLY THROW // vs //testSlots(); // INVOKE FOR AVALUE } } long lVectorRunTime = System.currentTimeMillis() - lVectorStartTime; System.out.println("Bench time: " + lVectorRunTime); } // SLOTS time: 33157,33250,33156 public static void testSlots() { ClassWithSlots oneSlot = new ClassWithSlots(6); int iterations = Integer.MAX_VALUE; long result = 0; while (iterations-- > 0) { result += oneSlot.getValue(); } } // Array time: 18438,18437,18422 public static void testArray() { final long[] accessArray = new long[] { 6 }; int iterations = Integer.MAX_VALUE; long result = 0; while (iterations-- > 0) { result += accessArray[0]; } } // GETFIELD time: 14688,14531,14453 public static void testGETFIELD() { ClassWithOneSlot oneSlot = new ClassWithOneSlot(6); int iterations = Integer.MAX_VALUE; long result = 0; while (iterations-- > 0) { result += oneSlot.slot; } } // INVOKE VIRTUAL time: 14750,14594,14719 public static void testBean() { ClassWithOneSlot oneSlot = new ClassWithOneSlot(6); int iterations = Integer.MAX_VALUE; long result = 0; while (iterations-- > 0) { result += oneSlot.getValue(); } } // INVOKE INTERFACE time: 14469,14610,14859 public static void testIBean() { IBeanWithOneSlot oneSlot = new ClassWithOneSlot(6); int iterations = Integer.MAX_VALUE; long result = 0; while (iterations-- > 0) { result += oneSlot.getValue(); } } // INVOKE VIRTUAL POSSIBLY THROW time: 14641,14594,14547 public static void testABean() { AClassWithOneSlot oneSlot = new ClassWithOneSlot(6); int iterations = Integer.MAX_VALUE; long result = 0; while (iterations-- > 0) { result += oneSlot.getValue(); } } static interface IBeanWithOneSlot { public long getValue(); } static class ClassWithOneSlot extends AClassWithOneSlot implements IBeanWithOneSlot { final public long slot; ClassWithOneSlot(long s) { slot = s; } @Override final public long getValue() { return slot; } } static class ClassWithSlots { final public long[] slots = new long[1]; ClassWithSlots(long s) { slots[0] = s; } final public long getValue() { return slots[0]; } } static abstract class AClassWithOneSlot implements IBeanWithOneSlot { @Override public long getValue() { throw new NullPointerException(); } } }

1 0

[armedbear-devel] Fwd: [j-devel] Improving startup time: sanity check
by Erik Huelsmann 29 Oct '09

29 Oct '09

forwarding ---------- Forwarded message ---------- From: Alessio Stalla <alessiostalla(a)gmail.com> Date: Wed, Oct 28, 2009 at 11:34 PM Subject: Re: [j-devel] Improving startup time: sanity check To: Erik Huelsmann <ehuels(a)gmail.com> Cc: armedbear-j-devel(a)lists.sourceforge.net, Alex Muscar <muscar(a)gmail.com> On Wed, Oct 28, 2009 at 11:20 PM, Alessio Stalla <alessiostalla(a)gmail.com> wrote: > The test might be wrong It was, indeed, wrong. It measured class loading time too for reflection, but that can't be eliminated, no matter what instantiation technique you use. New results on 50000 iterations: REFLECTION: 9660480097 NEW: 88353767 % SLOWER: 10933 REFLECTION: 9602410291 NEW: 78459331 % SLOWER: 12238 REFLECTION: 9925574038 NEW: 86923015 % SLOWER: 11418 ~100 times slower is still impressive. Ale

1 1

[armedbear-devel] Fwd: [j-devel] Improving startup time: sanity check
by Erik Huelsmann 29 Oct '09

29 Oct '09

Sorry, we seem to be having this discussion on the wrong mailing list. Forwarding. ---------- Forwarded message ---------- From: Alessio Stalla <alessiostalla(a)gmail.com> Date: Thu, Oct 29, 2009 at 9:36 AM Subject: Re: [j-devel] Improving startup time: sanity check To: Erik Huelsmann <ehuels(a)gmail.com> Cc: armedbear-j-devel(a)lists.sourceforge.net, Alex Muscar <muscar(a)gmail.com> On Wed, Oct 28, 2009 at 11:34 PM, Alessio Stalla <alessiostalla(a)gmail.com> wrote: > On Wed, Oct 28, 2009 at 11:20 PM, Alessio Stalla > <alessiostalla(a)gmail.com> wrote: >> The test might be wrong > > It was, indeed, wrong. It measured class loading time too for > reflection, but that can't be eliminated, no matter what instantiation > technique you use. > > New results on 50000 iterations: > > REFLECTION: 9660480097 > NEW: 88353767 > % SLOWER: 10933 > > REFLECTION: 9602410291 > NEW: 78459331 > % SLOWER: 12238 > > REFLECTION: 9925574038 > NEW: 86923015 > % SLOWER: 11418 > > ~100 times slower is still impressive. Incidentally, if those figures are right, it means that class loading from byte array is very costly too, and Erik's idea is likely to improve performance significantly if the application never uses a relatively large part of Lisp.

1 0

Re: [armedbear-devel] [armedbear-cvs] r12226 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 27 Oct '09

27 Oct '09

> Modified: trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp (original) > +++ trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp Sun Oct 25 18:35:52 2009 > @@ -1948,6 +1948,8 @@ > (when (plusp (length output)) > output))) > > +(defvar *declare-inline* nil) > + > (defmacro declare-with-hashtable (declared-item hashtable hashtable-var > item-var &body body) > `(let* ((,hashtable-var ,hashtable) > @@ -1970,19 +1972,19 @@ > (declare-object symbol +lisp-symbol+ > +lisp-symbol-class+)))) > (t > - (let ((*code* *static-code*) > - (s (sanitize symbol))) > - (setf g (symbol-name (gensym "SYM"))) > - (when s > - (setf g (concatenate 'string g "_" s))) > - (declare-field g +lisp-symbol+ +field-access-private+) > - (emit 'ldc (pool-string (symbol-name symbol))) > - (emit 'ldc (pool-string (package-name (symbol-package symbol)))) > - (emit-invokestatic +lisp-class+ "internInPackage" > - (list +java-string+ +java-string+) +lisp-symbol+) > - (emit 'putstatic *this-class* g +lisp-symbol+) > - (setf *static-code* *code*) > - (setf (gethash symbol ht) g)))))) > + (let ((*code* *static-code*) > + (s (sanitize symbol))) > + (setf g (symbol-name (gensym "SYM"))) > + (when s > + (setf g (concatenate 'string g "_" s))) > + (declare-field g +lisp-symbol+ +field-access-private+) > + (emit 'ldc (pool-string (symbol-name symbol))) > + (emit 'ldc (pool-string (package-name (symbol-package symbol)))) > + (emit-invokestatic +lisp-class+ "internInPackage" > + (list +java-string+ +java-string+) +lisp-symbol+) > + (emit 'putstatic *this-class* g +lisp-symbol+) > + (setf *static-code* *code*) > + (setf (gethash symbol ht) g)))))) There's a thinko in the above hunk: it only re-indents, that was intentional. However, it assumes the package to intern into exist. When *declare-inline* is non-NIL, there's a fair chance the package hasn't been created at *static-code* time though. This means the symbol creation will need to happen in-line too. I'll fix this later today. Bye, Erik.

1 0

[armedbear-devel] Change the default action of 'build.xml' to 'abcl.clean abcl.wrapper'?
by Mark Evenson 26 Oct '09

26 Oct '09

[Including armedbear-devel@ for potential wider dicussion.] On 10/26/09 1:05 PM, Erik Huelsmann wrote: […] > > BTW: I'm always doing complete builds; are you too? Yeah, in fact I think the much more common use case of the build system is 'ant abcl.clean abcl.wrapper'. I almost always want a full build from scratch, which is now taking slightly under two minutes for my MacBook Pro laptop. A couple years ago, a full build took something like five minutes from what I remember, so there was more of a need for incremental builds. What's your usage pattern like? Maybe I should make 'abcl.clean abcl.wrapper' the default target, where the old behavior could be re-restablished via setting an Ant property. This is contrary to the behavior of most build systems that I have experienced, but since we could write a banner message like "Starting build from scratch; set 'abcl.build.incremental' in 'build.properties' to enable incremental builds in the future." Thoughts? -- "A screaming comes across the sky. It has happened before, but there is nothing to compare to it now."

2 1

[armedbear-devel] Binary FASL support
by Erik Huelsmann 26 Oct '09

26 Oct '09

As the result of an attempt to reduce our startup time, I implemented binary FASL support: a compiled lisp function (= Java class) which gets executed instead of the interpreted forms which used to constitute the texty fasl format. The texty format is still there, but in case of a binary fasl only contains 2 forms to be evaluated, the rest will be in the compiled function. I don't feel like we achieved much: my startup times used to be 0.4 s and 1.6 s and that doesn't seem to have changed. Bummer. However, that's probably to be expected, because I was just guessing where our performance issue would be: I want to know how much of the 0.4 and 1.6 seconds are actually spent waiting on I/O happening. In case we're waiting big time on the data coming from the JAR, maybe there's an optimization possible to the way we create/read the JAR file. Any help on the subject of reducing our startup time would be most welcome! Bye, Erik.

2 1

[armedbear-devel] Error in 'test.lisp' to create .abcl_completions
by John Pallister 23 Oct '09

23 Oct '09

Hello list, I think there's an error in the 'test.lisp' code used to create .abcl_completions at http://common-lisp.net/project/armedbear/doc/abcl-install-with-java.html . Basically it should start with (defvar symbols nil) or somesuch to avoid an UNBOUND-VARIABLE error. Cheers, John :^P -- John Pallister john(a)johnp.net john(a)synchromesh.com

2 1

[armedbear-devel] Binary release 0.17 (steps to be taken)
by Erik Huelsmann 23 Oct '09

23 Oct '09

I'm hoping to be able to publish binaries when releasing 0.17. However, I think we're not yet completely ready to do so. We're missing: * Usage descriptions in terms of an INSTALL file, or something similar * Build targets, like we have for the src archives, for abcl-bin-<version>.zip and abcl-bin-<version>.tar.gz * Anything else? As for the archives, I'd like them to contain many of our top-level files (COPYING, README, etc) and instead of the subdirectories, I think it should contain abcl.jar Comments? Bye, Erik.

2 2

[armedbear-devel] Bug: Attempt to GO to a tag whose extent has ended quits ABCL
by Brian Mastenbrook 23 Oct '09

23 Oct '09

When attempting to GO to a tag whose dynamic extent has ended, ABCL quits and prints the name of the exception used for internally handling GO (org.armedbear.lisp.Go). I see the same behavior in compiled or interpreted code. CL-USER(1): (lisp-implementation-version) "0.16.0" CL-USER(2): (let ((f nil)) (tagbody (setf f (lambda () (go foo))) foo) (funcall f)) org.armedbear.lisp.Go abcl-src-0.16.0 chandler$ -- Brian Mastenbrook brian(a)mastenbrook.net http://brian.mastenbrook.net/

2 1

Re: [armedbear-devel] Using Java Libraries
by Carlos Ungil 21 Oct '09

21 Oct '09

> Hi folks, > > I'm searching for a (more systematic) documentation (or tutorial) > about how to use Java libraries from ABCL. > > I couldn't find anything else except the examples on > "http://trac.common-lisp.net/armedbear/browser/trunk/abcl/examples/abcl". > > Is there any such tutorial (or documentation) at all? > Any feedback is very much appreciated! > > Regards > Nik Hello, you might want to check jfli-abcl. Jfli, by Rich Hickey (who would later create Clojure), makes it possible to call Java from LispWorks. It was ported to ABCL by Andras Simon. You can I've just noticed you can find a recent (and improved) copy of jfli-abcl (including sample code) from http://github.com/avodonosov/abcl-idea/tree/master/src/abclidea/lisp/jfli-a… My version of the file has a couple of extra things that might be useful. 1) I had to add a case to infer-box-type to be able to call functions with java.lang.Float arguments. (defun infer-box-type (x) (cond ((null x) nil) ((boxed? x) (jobject-class (get-ref x))) ((integerp x) integer.type) ((typep x 'single-float) float.type) ((numberp x) double.type) ........ 2) I think the following change was done by Alex Mizrahi (I took the file from abcl-web). I don't know if it's still required. < `(defclass ,(class-symbol full-class-name) < ,supers ())))))))) --- > `(unless (get ,class-sym :ensured) ;no fwd ref'd classes in abcl > (ensure-java-class ,full-class-name) > (defclass ,(class-symbol full-class-name) > ,supers ()))))))))) I also added a "doto" macro similar to the one in Clojure (http://clojure.org/java_interop#toc15) (defmacro doto (object &body body) `(let ((object ,object)) ,@(loop for form in body collect `(,(first form) object ,@(rest form))) object)) so I can do things like (document.add (doto (pdfptable.new 3) (pdfptable.addCell (doto (pdfpcell.new (paragraph.new "header with colspan 2")) (pdfpcell.setColspan 2))) (pdfptable.addCell "A") (pdfptable.addCell "B"))) Cheers, Carlos

1 0

[armedbear-devel] Optimizing startup time
by Erik Huelsmann 21 Oct '09

21 Oct '09

Yesterday, Alex Muscar and I were chatting about the options and possibilities to use ABCL on GAE. It turns out that ABCL's startup gets triggered more often than we expected: instances of ABCL may get swapped out of memory or mapped to different servers, meaning ABCL needs to load all from scratch. So, we were evaluating what options we have to optimize ABCL's startup time. As always, I want to base such a decision on facts, so I ran the profiler on ABCL's startup yesterday. The conclusion is that ~ 40 to 45% of our startup time is spent in "privateGetDeclaredConstructors()". This is due to loadCompiledFunction calling the class's newInstance() method. That however, is the processing time spent. I'd love to be able to reduce it, but the function body delegates to a C/C++ function which means I can't fully understand its performance characteristics. Now, the other thing might be "I/O waiting time". Although the profiler measures "run time" and "wait time", I'm not sure how to deduce I/O wait time from that, or how to profile I/O times in another way. If there is considerable I/O wait time, we could probably speed up ABCL's startup process without having to drastically change any design decisions. Does anybody have any comments to that? Helpful remarks on how to find out about I/O wait time? Bye, Erik.

1 0

Re: [armedbear-devel] Using named classes for primitives
by Erik Huelsmann 21 Oct '09

21 Oct '09

On Mon, Oct 19, 2009 at 2:59 PM, Alessio Stalla <alessiostalla(a)gmail.com> wrote: > On Mon, Oct 19, 2009 at 2:22 PM, Alex Muscar <muscar(a)gmail.com> wrote: >> Hi, >> >> I've been messing around with the code. I've managed to load the fasl, >> but I think we're missing some initializations because I get the >> following error: >> >> ERROR placeholder called with arguments: >> #<UNDEFINED-FUNCTION SYSTEM::ENSURE-AVAILABLE-SYMBOLS {E5F46E}> >> >> Here's a full stack trace: >> >> org.armedbear.lisp.ConditionThrowable: java.lang.Error >> at org.armedbear.lisp.Primitives$70.execute(Primitives.java:1459) > > OT, but not too much: if we used named classes for primitives we could > get more meaningful stack traces (say, JCALL instead of > Primitives$XY). I.e. instead of > > private static final Primitive xyz = new Primitive(...) { ... }; > > we could use > > private static class JCALL extends Primitive { > JCALL(...) { super(...); } > ... > } > private static final Primitive xyz = new JCALL(...); > > a bit more verbose, but worth the effort imho. I think so too. However, there are a few too many of these to start changing them over now. Or does anybody feel like hacking up a perl script to get it done? :-) Bye, Erik.

4 7

[armedbear-devel] abcl on AppEngine
by Alex Muscar 19 Oct '09

19 Oct '09

Here's the first abcl "app" running on Google AppEngine: http://1.latest.abcl-test.appspot.com/hello . It's not much, but it's a start ;). -- All the best, Alex Muscar

1 0

[armedbear-devel] Using Java Libraries
by nitralime 19 Oct '09

19 Oct '09

Hi folks, I'm searching for a (more systematic) documentation (or tutorial) about how to use Java libraries from ABCL. I couldn't find anything else except the examples on "http://trac.common-lisp.net/armedbear/browser/trunk/abcl/examples/abcl". Is there any such tutorial (or documentation) at all? Any feedback is very much appreciated! Regards Nik

3 5

[armedbear-devel] Google AppEngine
by Alex Muscar 19 Oct '09

19 Oct '09

Hi, I've been messing around with the code. I've managed to load the fasl, but I think we're missing some initializations because I get the following error: ERROR placeholder called with arguments: #<UNDEFINED-FUNCTION SYSTEM::ENSURE-AVAILABLE-SYMBOLS {E5F46E}> Here's a full stack trace: org.armedbear.lisp.ConditionThrowable: java.lang.Error at org.armedbear.lisp.Primitives$70.execute(Primitives.java:1459) at org.armedbear.lisp.Primitive.execute(Primitive.java:108) at org.armedbear.lisp.Symbol.execute(Symbol.java:781) at org.armedbear.lisp.Lisp.error(Lisp.java:349) at org.armedbear.lisp.Primitives$72.execute(Primitives.java:1509) at org.armedbear.lisp.Symbol.execute(Symbol.java:792) at org.armedbear.lisp.LispThread.execute(LispThread.java:528) at org.armedbear.lisp.Symbol.undefinedFunction(Symbol.java:898) at org.armedbear.lisp.Symbol.execute(Symbol.java:779) at org.armedbear.lisp.LispThread.execute(LispThread.java:511) at org.armedbear.lisp.Lisp.evalCall(Lisp.java:488) at org.armedbear.lisp.Lisp.eval(Lisp.java:453) at org.armedbear.lisp.Lisp.evalCall(Lisp.java:511) at org.armedbear.lisp.Lisp.eval(Lisp.java:453) at org.armedbear.lisp.Lisp.eval(Lisp.java:451) at org.armedbear.lisp.Load.faslLoadStream(Load.java:523) at org.armedbear.lisp.Load.access$100(Load.java:47) at org.armedbear.lisp.Load$1.execute(Load.java:381) at org.armedbear.lisp.LispThread.execute(LispThread.java:528) at org.armedbear.lisp.Lisp.evalCall(Lisp.java:495) at org.armedbear.lisp.Lisp.eval(Lisp.java:453) at org.armedbear.lisp.Load.loadStream(Load.java:491) at org.armedbear.lisp.Load.loadFileFromStream(Load.java:452) at org.armedbear.lisp.Load.load(Load.java:165) at org.armedbear.lisp.Load.load(Load.java:94) at org.armedbear.lisp.Load.load(Load.java:53) at abcl_ae.AbclInit.<clinit>(AbclInit.java:32) at abcl_ae.HelloWorldServlet.doGet(HelloWorldServlet.java:17) at javax.servlet.http.HttpServlet.service(HttpServlet.java:693) at javax.servlet.http.HttpServlet.service(HttpServlet.java:806) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093) at com.google.apphosting.utils.servlet.TransactionCleanupFilter.doFilter(TransactionCleanupFilter.java:43) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at com.google.appengine.tools.development.StaticFileFilter.doFilter(StaticFileFilter.java:121) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405) at com.google.apphosting.utils.jetty.DevAppEngineWebAppContext.handle(DevAppEngineWebAppContext.java:54) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139) at com.google.appengine.tools.development.JettyContainerService$ApiProxyHandler.handle(JettyContainerService.java:342) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139) at org.mortbay.jetty.Server.handle(Server.java:313) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:506) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:830) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:514) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:381) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:396) at org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442) ERROR placeholder called with arguments: #<UNDEFINED-FUNCTION SYSTEM::ENSURE-AVAILABLE-SYMBOLS {E5F46E}> I've made Primitives.ERROR throw a ConditionThrowable instead of calling exit -- for debugging purpose. The fasls need to be in the war directory (or in a subdirectory). An ant task copies the .abcl files from src to war\fasls. I've attached an archive with the code as it looks now. -- All the best, Alex Muscar

3 2

[armedbear-devel] ABCL on Google App Engine (progress)
by Erik Huelsmann 19 Oct '09

19 Oct '09

Today, on IRC (irc://irc.freenode.net/#abcl) Alex and I have been working on getting ABCL to run on GAE (Google App Engine). We didn't complete our work, but since this mailing list has a wider audience than the IRC channel, I thought I'd forward our progress (his typing) to the mailing list. Possibly there are additional people interested. If others want to join in this effort to get ABCL running on GAE, I could commit the code to the examples directory in the repository. From there, we could make this a joint effort. One of the things we were running into is that we knew how to get a stream to the first-servlet.abcl file, but not how to get a path/URL to it. Can anybody contribute by answering how we should? When we know, we can do with the existing public functions, if there's not way, we need to make additional functions public. Bye, Erik. ---------- Forwarded message ---------- From: Alex Muscar <muscar(a)gmail.com> Date: Sun, Oct 18, 2009 at 6:13 PM Subject: The GAE bits To: ehuels(a)gmail.com Still hackish, though :(. We'll talk more about this tomorrow. -- All the best, Alex Muscar

2 3

[armedbear-devel] Serious bug involving UWP
by Tobias C. Rittweiler 18 Oct '09

18 Oct '09

Steps to reproduce: * ABCL from svn, updated a few minutes ago. * Slime from CVS. * M-x slime-scratch * Put (defun test (x) ,bar) in the buffer * Press C-c C-c You'll see "Evaluation aborted." in the minibuffer even though the debugger should have popped up complaining about comma not being inside backquote. C-c C-c is SWANK-COMPILE-STRING in swank-abcl.lisp. If you follow the control flow, you'll see that in SLDB-LOOP (we come here through *DEBUGGER-HOOK*) in swank.lisp, __the UNWINDED-PROTECT's protected form is *never* executed and it goes straight to the cleanup forms.__ -T.

4 13

[armedbear-devel] ABCL 0.16.1 released
by Erik Huelsmann 17 Oct '09

17 Oct '09

On behalf of the ABCL development team, I would like to announce the new ABCL release: 0.16.1 This release is a maintenance release on the 0.16 version line. In total four issues have been fixed: - In case of unsuccessful completion of a COMPILE call, ABCL would leak (= not correctly clean up behind itself) temporary files - In some cases, an exception thrown by a GO or RETURN-FROM form would not be correctly caught, causing the thread in which it occurs to terminate - Honor appearance of *&allow-other-keys* in CLOS MAKE-INSTANCE argument checking - More careful checking of 'null' arguments when processing stack frames Should you have any comments, remarks or bugs to be found in this release, please contact the developers through the mailing list mentioned on the ABCL project home page <http://common-lisp.net/project/armedbear/>.

1 0

[armedbear-devel] How to build the abcl.jar file within Eclipse
by dusan lukic 16 Oct '09

16 Oct '09

Hi all, I've downloaded ABCL from http://common-lisp.net/project/armedbear/ site, and, on it's building & running page, I've read that I can build abcl.jar file within Eclipse. I already have Eclipse installed on my computer, so can anyone, please, tell me how to do it. I do not have much experience with Eclipse, so a step-by-step procedure is preferred. Thanks, in advance.

2 1

Re: [armedbear-devel] [armedbear-cvs] r12180 - trunk/abcl/src/org/armedbear/lisp
by Erik Huelsmann 15 Oct '09

15 Oct '09

John, The commit below removes temporary file use from the COMPILE function. This is the minimal requirement to get running on GAE. So, I hope that you'll be using ABCL as of this version in your testing. I'm eager to learn about your progress. If you run into issues, please don't hesitate, we definitely want to fix them. If at all possible I'm for doing that ASAP. Bye, Erik. On Wed, Oct 7, 2009 at 11:51 PM, Alessio Stalla <astalla(a)common-lisp.net> wrote: > Author: astalla > Date: Wed Oct 7 17:51:00 2009 > New Revision: 12180 > > Log: > Ticket #56: eliminated use of temporary files for COMPILE > > > Modified: > trunk/abcl/src/org/armedbear/lisp/CompiledClosure.java > trunk/abcl/src/org/armedbear/lisp/JavaClassLoader.java > trunk/abcl/src/org/armedbear/lisp/Lisp.java > trunk/abcl/src/org/armedbear/lisp/Stream.java > trunk/abcl/src/org/armedbear/lisp/compile-file.lisp > trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp > > Modified: trunk/abcl/src/org/armedbear/lisp/CompiledClosure.java > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/CompiledClosure.java (original) > +++ trunk/abcl/src/org/armedbear/lisp/CompiledClosure.java Wed Oct 7 17:51:00 2009 > @@ -207,7 +207,7 @@ > > // ### load-compiled-function > private static final Primitive LOAD_COMPILED_FUNCTION = > - new Primitive("load-compiled-function", PACKAGE_SYS, true, "pathname") > + new Primitive("load-compiled-function", PACKAGE_SYS, true, "source") > { > @Override > public LispObject execute(LispObject arg) throws ConditionThrowable > @@ -219,6 +219,14 @@ > namestring = arg.getStringValue(); > if (namestring != null) > return loadCompiledFunction(namestring); > + if(arg instanceof JavaObject) { > + try { > + return loadCompiledFunction((byte[]) arg.javaInstance(byte[].class)); > + } catch(Throwable t) { > + Debug.trace(t); > + return error(new LispError("Unable to load " + arg.writeToString())); > + } > + } > return error(new LispError("Unable to load " + arg.writeToString())); > } > }; > > Modified: trunk/abcl/src/org/armedbear/lisp/JavaClassLoader.java > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/JavaClassLoader.java (original) > +++ trunk/abcl/src/org/armedbear/lisp/JavaClassLoader.java Wed Oct 7 17:51:00 2009 > @@ -37,17 +37,7 @@ > import java.util.HashSet; > import java.util.Set; > > -public class JavaClassLoader extends ClassLoader > -{ > - private static final boolean isSableVM; > - > - static { > - String vm = System.getProperty("java.vm.name"); > - if (vm != null && vm.equals("SableVM")) > - isSableVM = true; > - else > - isSableVM = false; > - } > +public class JavaClassLoader extends ClassLoader { > > private static JavaClassLoader persistentInstance; > > @@ -79,6 +69,10 @@ > } > } > > + public Class<?> loadClassFromByteArray(byte[] classbytes) { > + return loadClassFromByteArray(null, classbytes); > + } > + > public Class<?> loadClassFromByteArray(String className, > byte[] classbytes) > { > > Modified: trunk/abcl/src/org/armedbear/lisp/Lisp.java > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/Lisp.java (original) > +++ trunk/abcl/src/org/armedbear/lisp/Lisp.java Wed Oct 7 17:51:00 2009 > @@ -1376,6 +1376,16 @@ > new Pathname(namestring))); > } > > + public static final LispObject makeCompiledFunctionFromClass(Class<?> c) > + throws Exception { > + if (c != null) { > + LispObject obj = (LispObject)c.newInstance(); > + return obj; > + } else { > + return null; > + } > + } > + > private static final LispObject loadCompiledFunction(InputStream in, int size) > { > try > @@ -1405,21 +1415,19 @@ > } > > public static final LispObject loadCompiledFunction(byte[] bytes) throws Throwable { > - Class<?> c = (new JavaClassLoader()) > - .loadClassFromByteArray(null, bytes, 0, bytes.length); > - if (c != null) { > - Constructor constructor = c.getConstructor((Class[])null); > - LispObject obj = (LispObject)constructor > - .newInstance((Object[])null); > - if (obj instanceof Function) { > - ((Function)obj).setClassBytes(bytes); > - } > - return obj; > - } else { > - return null; > - } > + return loadCompiledFunction(bytes, new JavaClassLoader()); > } > > + public static final LispObject loadCompiledFunction(byte[] bytes, JavaClassLoader cl) throws Throwable { > + Class<?> c = cl.loadClassFromByteArray(null, bytes, 0, bytes.length); > + LispObject obj = makeCompiledFunctionFromClass(c); > + if (obj instanceof Function) { > + ((Function)obj).setClassBytes(bytes); > + } > + return obj; > + } > + > + > public static final LispObject makeCompiledClosure(LispObject template, > ClosureBinding[] context) > throws ConditionThrowable > > Modified: trunk/abcl/src/org/armedbear/lisp/Stream.java > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/Stream.java (original) > +++ trunk/abcl/src/org/armedbear/lisp/Stream.java Wed Oct 7 17:51:00 2009 > @@ -119,6 +119,14 @@ > { > } > > + public Stream(Reader r) { > + initAsCharacterInputStream(r); > + } > + > + public Stream(Writer w) { > + initAsCharacterOutputStream(w); > + } > + > public Stream(InputStream inputStream, LispObject elementType) > { > this(inputStream, elementType, keywordDefault); > > Modified: trunk/abcl/src/org/armedbear/lisp/compile-file.lisp > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/compile-file.lisp (original) > +++ trunk/abcl/src/org/armedbear/lisp/compile-file.lisp Wed Oct 7 17:51:00 2009 > @@ -146,11 +146,17 @@ > (parse-body body) > (let* ((expr `(lambda ,lambda-list > ,@decls (block ,block-name ,@body))) > - (classfile-name (next-classfile-name)) > - (classfile (report-error > - (jvm:compile-defun name expr nil > - classfile-name))) > + (classfile (next-classfile-name)) > + (result (with-open-file > + (f classfile > + :direction :output > + :element-type '(unsigned-byte 8) > + :if-exists :supersede) > + (report-error > + (jvm:compile-defun name expr nil > + classfile f)))) > (compiled-function (verify-load classfile))) > + (declare (ignore result)) > (cond > (compiled-function > (setf form > @@ -205,10 +211,14 @@ > (let ((name (second form))) > (eval form) > (let* ((expr (function-lambda-expression (macro-function name))) > - (classfile-name (next-classfile-name)) > - (classfile > - (ignore-errors > - (jvm:compile-defun nil expr nil classfile-name)))) > + (classfile (next-classfile-name))) > + (with-open-file > + (f classfile > + :direction :output > + :element-type '(unsigned-byte 8) > + :if-exists :supersede) > + (ignore-errors > + (jvm:compile-defun nil expr nil classfile f))) > (if (null (verify-load classfile)) > ;; FIXME error or warning > (format *error-output* "; Unable to compile macro ~A~%" name) > @@ -342,10 +352,17 @@ > (eq (%car function-form) 'FUNCTION)) > (let ((lambda-expression (cadr function-form))) > (jvm::with-saved-compiler-policy > - (let* ((classfile-name (next-classfile-name)) > - (classfile (report-error > - (jvm:compile-defun nil lambda-expression nil classfile-name))) > + (let* ((classfile (next-classfile-name)) > + (result > + (with-open-file > + (f classfile > + :direction :output > + :element-type '(unsigned-byte 8) > + :if-exists :supersede) > + (report-error > + (jvm:compile-defun nil lambda-expression nil classfile f)))) > (compiled-function (verify-load classfile))) > + (declare (ignore result)) > (cond (compiled-function > (setf (getf tail key) > `(load-compiled-function ,(file-namestring classfile)))) > @@ -356,9 +373,16 @@ > (declaim (ftype (function (t) t) convert-toplevel-form)) > (defun convert-toplevel-form (form) > (let* ((expr `(lambda () ,form)) > - (classfile-name (next-classfile-name)) > - (classfile (report-error (jvm:compile-defun nil expr nil classfile-name))) > + (classfile (next-classfile-name)) > + (result > + (with-open-file > + (f classfile > + :direction :output > + :element-type '(unsigned-byte 8) > + :if-exists :supersede) > + (report-error (jvm:compile-defun nil expr nil classfile f)))) > (compiled-function (verify-load classfile))) > + (declare (ignore result)) > (setf form > (if compiled-function > `(funcall (load-compiled-function ,(file-namestring classfile))) > > Modified: trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp > ============================================================================== > --- trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp (original) > +++ trunk/abcl/src/org/armedbear/lisp/compiler-pass2.lisp Wed Oct 7 17:51:00 2009 > @@ -4921,16 +4921,16 @@ > (emit-push-nil) > (emit-move-from-stack target))) > > -(defun compile-and-write-to-file (class-file compiland) > +(defun compile-and-write-to-stream (class-file compiland stream) > (with-class-file class-file > (let ((*current-compiland* compiland)) > (with-saved-compiler-policy > (p2-compiland compiland) > - (write-class-file (compiland-class-file compiland)))))) > + (write-class-file (compiland-class-file compiland) stream))))) > > -(defun set-compiland-and-write-class-file (class-file compiland) > +(defun set-compiland-and-write-class (class-file compiland stream) > (setf (compiland-class-file compiland) class-file) > - (compile-and-write-to-file class-file compiland)) > + (compile-and-write-to-stream class-file compiland stream)) > > > (defmacro with-temp-class-file (pathname class-file lambda-list &body body) > @@ -4949,15 +4949,18 @@ > (let* ((pathname (funcall *pathnames-generator*)) > (class-file (make-class-file :pathname pathname > :lambda-list lambda-list))) > - (set-compiland-and-write-class-file class-file compiland) > + (with-open-class-file (f class-file) > + (set-compiland-and-write-class class-file compiland f)) > (setf (local-function-class-file local-function) class-file))) > (t > - (with-temp-class-file > - pathname class-file lambda-list > - (set-compiland-and-write-class-file class-file compiland) > + (let ((class-file (make-class-file > + :pathname (funcall *pathnames-generator*) > + :lambda-list lambda-list))) > + (with-open-stream (stream (sys::%make-byte-array-output-stream)) > + (set-compiland-and-write-class class-file compiland stream) > (setf (local-function-class-file local-function) class-file) > (setf (local-function-function local-function) > - (load-compiled-function pathname))))))) > + (load-compiled-function (sys::%get-output-stream-bytes stream))))))))) > > (defun emit-make-compiled-closure-for-labels > (local-function compiland declaration) > @@ -4981,19 +4984,24 @@ > (let* ((pathname (funcall *pathnames-generator*)) > (class-file (make-class-file :pathname pathname > :lambda-list lambda-list))) > - (set-compiland-and-write-class-file class-file compiland) > + (with-open-class-file (f class-file) > + (set-compiland-and-write-class class-file compiland f)) > (setf (local-function-class-file local-function) class-file) > (let ((g (declare-local-function local-function))) > (emit-make-compiled-closure-for-labels > local-function compiland g)))) > (t > - (with-temp-class-file > - pathname class-file lambda-list > - (set-compiland-and-write-class-file class-file compiland) > + (let ((class-file (make-class-file > + :pathname (funcall *pathnames-generator*) > + :lambda-list lambda-list))) > + (with-open-stream (stream (sys::%make-byte-array-output-stream)) > + (set-compiland-and-write-class class-file compiland stream) > (setf (local-function-class-file local-function) class-file) > - (let ((g (declare-object (load-compiled-function pathname)))) > + (let ((g (declare-object > + (load-compiled-function > + (sys::%get-output-stream-bytes stream))))) > (emit-make-compiled-closure-for-labels > - local-function compiland g))))))) > + local-function compiland g)))))))) > > (defknown p2-flet-node (t t t) t) > (defun p2-flet-node (block target representation) > @@ -5041,7 +5049,8 @@ > (make-class-file :pathname (funcall *pathnames-generator*) > :lambda-list lambda-list)) > (let ((class-file (compiland-class-file compiland))) > - (compile-and-write-to-file class-file compiland) > + (with-open-class-file (f class-file) > + (compile-and-write-to-stream class-file compiland f)) > (emit 'getstatic *this-class* > (declare-local-function (make-local-function :class-file > class-file)) > @@ -5051,14 +5060,13 @@ > (setf (compiland-class-file compiland) > (make-class-file :pathname pathname > :lambda-list lambda-list)) > - (unwind-protect > - (progn > - (compile-and-write-to-file (compiland-class-file compiland) > - compiland) > - (emit 'getstatic *this-class* > - (declare-object (load-compiled-function pathname)) > - +lisp-object+)) > - (delete-file pathname))))) > + (with-open-stream (stream (sys::%make-byte-array-output-stream)) > + (compile-and-write-to-stream (compiland-class-file compiland) > + compiland stream) > + (emit 'getstatic *this-class* > + (declare-object (load-compiled-function > + (sys::%get-output-stream-bytes stream))) > + +lisp-object+))))) > (cond ((null *closure-variables*)) ; Nothing to do. > ((compiland-closure-register *current-compiland*) > (duplicate-closure-array *current-compiland*) > @@ -8030,7 +8038,14 @@ > (setf (compiland-arity compiland) arg-count) > (get-descriptor (list +lisp-object-array+) +lisp-object+))))) > > -(defun write-class-file (class-file) > +(defmacro with-open-class-file ((var class-file) &body body) > + `(with-open-file (,var (class-file-pathname ,class-file) > + :direction :output > + :element-type '(unsigned-byte 8) > + :if-exists :supersede) > + ,@body)) > + > +(defun write-class-file (class-file stream) > (let* ((super (class-file-superclass class-file)) > (this-index (pool-class (class-file-class class-file))) > (super-index (pool-class super)) > @@ -8045,43 +8060,39 @@ > (when (and (boundp '*source-line-number*) > (fixnump *source-line-number*)) > (pool-name "LineNumberTable")) ; Must be in pool! > - > - ;; Write out the class file. > - (with-open-file (stream (class-file-pathname class-file) > - :direction :output > - :element-type '(unsigned-byte 8) > - :if-exists :supersede) > - (write-u4 #xCAFEBABE stream) > - (write-u2 3 stream) > - (write-u2 45 stream) > - (write-constant-pool stream) > - ;; access flags > - (write-u2 #x21 stream) > - (write-u2 this-index stream) > - (write-u2 super-index stream) > - ;; interfaces count > - (write-u2 0 stream) > - ;; fields count > - (write-u2 (length *fields*) stream) > - ;; fields > - (dolist (field *fields*) > - (write-field field stream)) > - ;; methods count > - (write-u2 (1+ (length (class-file-methods class-file))) stream) > - ;; methods > - (dolist (method (class-file-methods class-file)) > - (write-method method stream)) > - (write-method constructor stream) > - ;; attributes count > - (cond (*file-compilation* > - ;; attributes count > - (write-u2 1 stream) > - ;; attributes table > - (write-source-file-attr (file-namestring *compile-file-truename*) > - stream)) > - (t > - ;; attributes count > - (write-u2 0 stream)))))) > + > + (write-u4 #xCAFEBABE stream) > + (write-u2 3 stream) > + (write-u2 45 stream) > + (write-constant-pool stream) > + ;; access flags > + (write-u2 #x21 stream) > + (write-u2 this-index stream) > + (write-u2 super-index stream) > + ;; interfaces count > + (write-u2 0 stream) > + ;; fields count > + (write-u2 (length *fields*) stream) > + ;; fields > + (dolist (field *fields*) > + (write-field field stream)) > + ;; methods count > + (write-u2 (1+ (length (class-file-methods class-file))) stream) > + ;; methods > + (dolist (method (class-file-methods class-file)) > + (write-method method stream)) > + (write-method constructor stream) > + ;; attributes count > + (cond (*file-compilation* > + ;; attributes count > + (write-u2 1 stream) > + ;; attributes table > + (write-source-file-attr (file-namestring *compile-file-truename*) > + stream)) > + (t > + ;; attributes count > + (write-u2 0 stream))) > + stream)) > > (defknown p2-compiland-process-type-declarations (list) t) > (defun p2-compiland-process-type-declarations (body) > @@ -8359,7 +8370,7 @@ > (push execute-method (class-file-methods class-file))) > t) > > -(defun compile-1 (compiland) > +(defun compile-1 (compiland stream) > (let ((*all-variables* nil) > (*closure-variables* nil) > (*undefined-variables* nil) > @@ -8393,8 +8404,7 @@ > ;; Pass 2. > (with-class-file (compiland-class-file compiland) > (p2-compiland compiland) > - (write-class-file (compiland-class-file compiland))) > - (class-file-pathname (compiland-class-file compiland))))) > + (write-class-file (compiland-class-file compiland) stream))))) > > (defvar *compiler-error-bailout*) > > @@ -8402,7 +8412,7 @@ > `(lambda ,(cadr form) > (error 'program-error :format-control "Execution of a form compiled with errors."))) > > -(defun compile-defun (name form environment filespec) > +(defun compile-defun (name form environment filespec stream) > (aver (eq (car form) 'LAMBDA)) > (catch 'compile-defun-abort > (let* ((class-file (make-class-file :pathname filespec > @@ -8415,13 +8425,15 @@ > :class-file > (make-class-file :pathname ,filespec > :lambda-name ',name > - :lambda-list (cadr ',form)))))) > + :lambda-list (cadr ',form))) > + ,stream))) > (*compile-file-environment* environment)) > (compile-1 (make-compiland :name name > :lambda-expression > (precompiler:precompile-form form t > environment) > - :class-file class-file))))) > + :class-file class-file) > + stream)))) > > (defvar *catch-errors* t) > > @@ -8517,11 +8529,22 @@ > (tempfile (make-temp-file))) > (with-compilation-unit () > (with-saved-compiler-policy > - (unwind-protect > - (setf compiled-function > - (load-compiled-function > - (compile-defun name expr env tempfile)))) > - (delete-file tempfile))) > + (setf compiled-function > + (load-compiled-function > + (if *file-compilation* > + (unwind-protect > + (progn > + (with-open-file (f tempfile > + :direction :output > + :element-type '(unsigned-byte 8) > + :if-exists :supersede) > + (compile-defun name expr env tempfile f)) > + tempfile) > + (delete-file tempfile)) > + (with-open-stream (s (sys::%make-byte-array-output-stream)) > + (compile-defun name expr env tempfile s) > + (finish-output s) > + (sys::%get-output-stream-bytes s))))))) > (when (and name (functionp compiled-function)) > (sys::set-function-definition name compiled-function definition)) > (or name compiled-function))) > > _______________________________________________ > armedbear-cvs mailing list > armedbear-cvs(a)common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-cvs >

3 3