Mark, Erik, thank you for those fixes. There is another bug in jfli.lisp, at line 366 there is a call to sys::ensure-class but it seems that this function has been moved to another package: mop:ensure-class I have two more comments about jfli.lisp (but these are not critical issues). 1) the function unbox-string (never used, probably it can be removed) calls the undefined function convert-from-java-string 2) I used to have an additional clause in infer-box-type (I don't remember the details, but I think I had to add it to be able to pass a Float argument to some java API): ((typep x '(integer -9223372036854775808 +9223372036854775807)) long.type) + ((typep x 'single-float) float.type) ((numberp x) double.type) Cheers, Carlos On Wed, Nov 28, 2012 at 10:26 AM, Mark Evenson <evenson@panix.com> wrote:
On Nov 26, 2012, at 11:34 PM, Carlos Ungil <carlos.ungil@gmail.com> wrote:
Dear ABCL developers,
I apologize if this is not the right channel for this kind of request, but I'd like to suggest the following change to src/org/armedbear/lisp/Lisp.java (for CFFI to identify the platform properly on MacOSX).
@@ -2378,9 +2378,9 @@ } // Processor architecture if(osArch != null) { - if (osArch.equals("amd64")) + if (osArch.equals("amd64")||osArch.equals("x86_64")) featureList = new Cons(Keyword.X86_64, featureList); - else if (osArch.equals("x86")) + else if (osArch.equals("x86")||osArch.equals("i386")) featureList = new Cons(Keyword.X86, featureList); } Symbol.FEATURES.initializeSpecial(featureList);
Erik applied this in [r14256][]. Thanks for the patch!
[r14256]: http://trac.common-lisp.net/armedbear/changeset/14256
Also, there is a problem with contrib/jfli/test/yanking.lisp, there is a referece to abclidea:*lisp-dir* and that package is not part of ABCL. As a workaround I've changed contrib/jfli/jfli.asd to remove the (:module test :components ((:file "yanking"))
Since there is no need for runtime dependency for JFLI on IntelliJ, I [have moved the JFLI IntelliJ test suite into its own ASDF system definition][r14257]. Please let us know if this does' work for you for some reason.
[r14257]: http://trac.common-lisp.net/armedbear/changeset/14257
-- "A screaming comes across the sky. It has happened before but there is nothing to compare to it now."