Re: [armedbear-devel] JSR-223: Returning immutable lists in ScriptEngineFactory

On Sun, Sep 20, 2009 at 2:50 PM, Clemens Blamauer clemens.blamauer@gmail.com wrote:

Hi everyone,

I was looking through the JSR-223 code in org.armedbear.lisp.scripting as I noticed that AbclScriptEngineFactory is not fully compliant to JSR-223 [1] (p. 101-102 in the Final Draft Specification, v1.0).

For the methods:

• java.util.List<java.lang.String> getExtensions()
• java.util.List<java.lang.String> getMimeTypes()
• java.util.List<java.lang.String> getNames()

_immutable_ Lists should be returned.

Please find a remedying patch below.

Thank you, I patched the class and committed to trunk.

Bye, Alessio