16.01.2014, 21:22, "Mark Evenson" evenson@panix.com:
On Jan 16, 2014, at 13:44, Theam Yong Chew senatorzergling@gmail.com wrote:
Hi all,
I inadvertently discovered some bugs in the gray-streams implementation due to a stale flexi-streams that did not get upgraded properly.
Applied in [r14602][1]: FLEXI-STREAMS from Quicklisp passes all its tests! Fantastic!
Flexi-streams test suite passes even on ABCL 1.1.1 http://common-lisp.net/project/cl-test-grid/library/flexi-streams.html
But not in quicklisp 2014-01-13, where flexi-streams test suite has new test case. It fails on ABCL due to #342: http://cl-test-grid.appspot.com/blob?key=1r0ys54trc
So, I suggest to commit the trivial fix from #342.
Note about the Yong's patch. Strictly speaking, there is not requirement that gray streams implementation provide default method stream-read-sequence implemented in terms of read-char (for character streams) or read-byte (for binary streams).
Gray proposal does not contain stream-read-sequence function at all: http://www.nhplace.com/kent/CL/Issues/stream-definition-by-user.html
I suppose it is because CLTL book doesn't have cl:read-sequence: http://www.cs.cmu.edu/Groups/AI/html/cltl/clm/node194.html#SECTION0026200000...
But of course, it reasonable to have default methods.
Best regards, - Anton