On Tue, Feb 2, 2010 at 11:53 AM, Blake McBride <blake@mcbride.name> wrote:

See comments in-line.

On Tue, Feb 2, 2010 at 11:14 AM, Ville Voutilainen <ville.voutilainen@gmail.com> wrote:

2010/1/30 Blake McBride <blake@mcbride.name>:

> Greetings,
> Enclosed are the completed Lisp and Java utilities designed to make Lisp /
> Java interaction easier. It also includes an example / tutorial program.
> If it is appropriate, I'd like to have these added as one of the ABCL
> examples in the distribution. Also, if it is advantageous, perhaps we can
> move the Lisp and Java utilities to be part of ABCL.

Looks good. I think the ABCL java class could benefit from a setter for the
interpreter, and a getter, so that you could use it as a decorator. Wherever
an instance of Interpreter is created, I think it's better to allow
people to use
that instance for other things Interpreter is capable of.

Agreed.

I'd add the
possibility
to have per-ABCL-instance Interpreters, as well as the option of having a
class instance.

I was under the impression that, while you can have multiple ABCL threads, you can't have multiple instances of ABCL running. If this is true, however, I could use an instance version instead to support the future possibilities.

The utils.lisp stuff looks like it could well be added to our
java.lisp, probably
slightly tweaking the function names to follow the normal java.lisp conventions.

Agreed. I am now working on a Lisp function in which you pass the name of a Java class and it automatically creates the Lisp proxy functions for the entire class through Java reflection. I'll probably have that working today.

Would you like to do such tweaks, or should I? :)

Alessio, this is your familiar playground, any comments on these utils?