Hi.
A simple thing, but I spotted it during reading of the code.
Index: src/org/armedbear/lisp/JHandler.java =================================================================== --- src/org/armedbear/lisp/JHandler.java (revision 12738) +++ src/org/armedbear/lisp/JHandler.java (working copy) @@ -66,21 +66,22 @@ public static void callLisp (String s, Object o, String as[], int ai[]) { if (table.containsKey(o)) { - Map<String,Entry> entryTable = (Map<String,Entry>)table.get(o); + Map<String,Entry> entryTable = (Map<String,Entry>)table.get(o); if (entryTable.containsKey(s)) { - Function f = ((Entry)entryTable.get(s)).getHandler(); - LispObject data = ((Entry)entryTable.get(s)).getData(); - Fixnum count = ((Entry)entryTable.get(s)).getCount(); - Fixnum[] lispAi = new Fixnum[ai.length]; + final Entry entry = entryTable.get(s); + final Function f = entry.getHandler(); + final LispObject data = entry.getData(); + final Fixnum count = entry.getCount(); + final Fixnum[] lispAi = new Fixnum[ai.length]; for (int i = 0; i < ai.length; i++) { lispAi[i] = Fixnum.getInstance(ai[i]); } - LispObject lispAiVector = new SimpleVector(lispAi); - SimpleString[] lispAs = new SimpleString[as.length]; + final LispObject lispAiVector = new SimpleVector(lispAi); + final SimpleString[] lispAs = new SimpleString[as.length]; for (int i = 0; i < as.length; i++) { lispAs[i] = new SimpleString(as[i]); } - LispObject lispAsVector = new SimpleVector(lispAs); + final LispObject lispAsVector = new SimpleVector(lispAs); LispObject[] args = new LispObject[] //FIXME: count -> seq_num { data, new JavaObject(o), lispAiVector, lispAsVector, internKeyword(s), count }; f.execute(args);
Hi Mario,
So sorry to be responding to your mail only now! However, your mail seems to have gotten stuck in the moderation queue.
On Sat, Jun 5, 2010 at 2:27 PM, Mario Lang mlang@delysid.org wrote:
Hi.
A simple thing, but I spotted it during reading of the code.
Thank you for your submission! It's very much appreciated.
Committed as r13015 just a second ago.
Thanks again.
Bye,
Erik.
Index: src/org/armedbear/lisp/JHandler.java
--- src/org/armedbear/lisp/JHandler.java (revision 12738) +++ src/org/armedbear/lisp/JHandler.java (working copy) @@ -66,21 +66,22 @@ public static void callLisp (String s, Object o, String as[], int ai[]) { if (table.containsKey(o)) {
- Map<String,Entry> entryTable = (Map<String,Entry>)table.get(o);
- Map<String,Entry> entryTable = (Map<String,Entry>)table.get(o);
if (entryTable.containsKey(s)) {
- Function f = ((Entry)entryTable.get(s)).getHandler();
- LispObject data = ((Entry)entryTable.get(s)).getData();
- Fixnum count = ((Entry)entryTable.get(s)).getCount();
- Fixnum[] lispAi = new Fixnum[ai.length];
- final Entry entry = entryTable.get(s);
- final Function f = entry.getHandler();
- final LispObject data = entry.getData();
- final Fixnum count = entry.getCount();
- final Fixnum[] lispAi = new Fixnum[ai.length];
for (int i = 0; i < ai.length; i++) { lispAi[i] = Fixnum.getInstance(ai[i]); }
- LispObject lispAiVector = new SimpleVector(lispAi);
- SimpleString[] lispAs = new SimpleString[as.length];
- final LispObject lispAiVector = new SimpleVector(lispAi);
- final SimpleString[] lispAs = new SimpleString[as.length];
for (int i = 0; i < as.length; i++) { lispAs[i] = new SimpleString(as[i]); }
- LispObject lispAsVector = new SimpleVector(lispAs);
- final LispObject lispAsVector = new SimpleVector(lispAs);
LispObject[] args = new LispObject[] //FIXME: count -> seq_num { data, new JavaObject(o), lispAiVector, lispAsVector, internKeyword(s), count }; f.execute(args);
-- CYa, ⡍⠁⠗⠊⠕
armedbear-devel mailing list armedbear-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
armedbear-devel@common-lisp.net