[Armedbear-ticket] [armedbear] #368: define-setf-expander is not available for expansion later in the file on ABCL unless we wrap it in an eval-when

List overview All Threads
Download

newer

older

[Armedbear-ticket] [armedbear]...

armedbear

29 Aug 2014 29 Aug '14

6:13 p.m.

#368: define-setf-expander is not available for expansion later in the file on ABCL unless we wrap it in an eval-when ----------------------+----------------------- Reporter: mevenson | Owner: Type: defect | Status: new Priority: major | Milestone: 1.4.0 Component: java | Version: 1.4.0-dev Keywords: | ----------------------+----------------------- define-setf-expander is not available for expansion later in the file on ABCL unless we wrap it in an eval-when

https://github.com/easye/cffi/commit/03624e609cd48cc065bd15c8dcea715f287b6bb...

Slyrus ran into this while working on CFFI.

-- Ticket URL: http://abcl.org/trac/ticket/368 armedbear http://abcl.org armedbear

Show replies by date

armedbear

29 Aug 29 Aug

6:14 p.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when (was: define-setf-expander is not available for expansion later in the file on ABCL unless we wrap it in an eval-when)

#368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when -----------------------+----------------------- Reporter: mevenson | Owner: Type: defect | Status: new Priority: major | Milestone: 1.4.0 Component: java | Version: 1.4.0-dev Resolution: | Keywords: -----------------------+-----------------------

Comment (by mevenson):

Check compiled v. interpreted versions.

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:1 armedbear http://abcl.org armedbear

armedbear

1 Sep 1 Sep

8:12 a.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

Comment (by mevenson):

The exact conditions to trigger this problem are not simple, as the following works in both interpreted and compiled modes

{{{ ;;file:///opt/local/share/doc/lisp/HyperSpec-7-0/HyperSpec/Body/m_defi_3.htm

(defun lastguy (x) (car (last x)))

(define-setf-expander lastguy (x &environment env) "Set the last element in a list to the given value." (multiple-value-bind (dummies vals newval setter getter) (get-setf-expansion x env) (let ((store (gensym))) (values dummies vals `(,store) `(progn (rplaca (last ,getter) ,store) ,store) `(lastguy ,getter)))))

(defun use-lastguy () (let ((a `(1 2 3 4))) (setf (lastguy a) 42) a)) }}}

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:2 armedbear http://abcl.org armedbear

armedbear

2 Sep 2 Sep

6:32 p.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

Comment (by mevenson):

Replying to [comment:2 mevenson]:

...

The exact conditions to trigger this problem are not simple, as the

following works […]

My current working hypothesis is that things involving macros aren't being expanded at the correct time.

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:3 armedbear http://abcl.org armedbear

armedbear

7:31 p.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

Comment (by mevenson):

Replying to [comment:3 mevenson]:

Triaged back to failure in abcl-1.1.1, so this is not the result of recent damage.

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:4 armedbear http://abcl.org armedbear

armedbear

8 Sep 8 Sep

9:33 p.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

Comment (by charmon):

This is also true for define-modify-macro. Both issues are fixed by the most recent 2 commits on my setf-and-modify-eval-when branch: https://github.com/slyrus/abcl/commits/setf-and-modify-eval-when

Any chance of getting this committed soon? Then we can revert the corresponding CFFI patch and get the rest of the ABCL support for CFFI committed.

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:5 armedbear http://abcl.org armedbear

armedbear

9 Sep 9 Sep

7:59 a.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

Comment (by mevenson):

In testing your patch, ran into an issue that may or may not have been a result of not doing a complete recompilation. I'll get back to this later today.

Unfortunately for CFFI, until we get a release of abcl-1.4.0 or (abcl-1.3.2) with this patch, I wouldn't recommend changing the CFFI patch, as almost no users will have had a chance to update. I don't know where the compromise lies: since we have to appease the CFFI maintainers, and the problems with DEFINE-SETF-MODIFY affect the code shared with other Lisp implementation, I don't expect them to want to "dirty" the code with the necessary hack for the broken ABCL. But on the other hand, if CFFI doesn't use the ugly version of the DEFINE-SETF-MODIFY code, the usage of CFFI will break for all ABCL users not running from abcl-1.4.0-dev sources. This week is busy for me, so I would realistically guess that I could make a release of abcl sometime in the next two weeks.

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:6 armedbear http://abcl.org armedbear

armedbear

9:26 a.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

Comment (by mevenson):

Replying to [comment:6 mevenson]:

...

In testing your patch, ran into an issue that may or may not have been a

result of not doing a complete recompilation. I'll get back to this later today.

After a recompilation of ABCL from scratch, this patch does indeed seem to resolve the underlying issues. I'm running more of the test suite to ensure we haven't broken anything else, afterwards I'll commit Cyrus' patch. Thanks!

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:7 armedbear http://abcl.org armedbear

armedbear

10:55 a.m.

New subject: [Armedbear-ticket] [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

#368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when -----------------------+----------------------- Reporter: mevenson | Owner: Type: defect | Status: closed Priority: major | Milestone: 1.4.0 Component: java | Version: 1.4.0-dev Resolution: fixed | Keywords: -----------------------+----------------------- Changes (by mevenson):

* status: new => closed * resolution: => fixed

Comment:

Committed Cyrus's patch as http://abcl.org/trac/changeset/14727.

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:8 armedbear http://abcl.org armedbear

armedbear

28 Apr 28 Apr

6:32 a.m.

New subject: [armedbear] #368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when

#368: File level define-setf-expander is not available for expansion unless wrapped in an eval-when ---------------------------+----------------------- Reporter: mevenson | Owner: Type: defect | Status: closed Priority: major | Milestone: 1.3.2 Component: java | Version: 1.4.0-dev Resolution: fixed | Keywords: Parent Tickets: | ---------------------------+----------------------- Changes (by mevenson):

* milestone: 1.4.0 => 1.3.2

-- Ticket URL: http://abcl.org/trac/ticket/368#comment:9 armedbear http://abcl.org armedbear

3525

Age (days ago)

3767

Last active (days ago)

armedbear-ticket@common-lisp.net

9 comments

1 participants

tags (0)

participants (1)

armedbear