[armedbear] #433: merge-pathnames blocks error signal?
#433: merge-pathnames blocks error signal? -------------------------+---------------------- Reporter: aruttenberg | Owner: Type: defect | Status: new Priority: major | Milestone: Component: interpreter | Version: Keywords: | Parent Tickets: -------------------------+---------------------- `(make-pathname :directory '(:absolute ("a" "b")))` property signals an error `Unsupported directory component (a b).` However the following `(merge-pathnames (make-pathname :directory '(:absolute ("a" "b"))) "")` Does not, instead spitting out a java stack trace ABCL Debug.assertTrue() assertion failed! java.lang.Error: ABCL Debug.assertTrue() assertion failed! at org.armedbear.lisp.Debug.assertTrue(Debug.java:48) at org.armedbear.lisp.Pathname.<init>(Pathname.java:154) at org.armedbear.lisp.Pathname.mergePathnames(Pathname.java:1979) at org.armedbear.lisp.Pathname$pf_merge_pathnames.execute(Pathname.java:1957) at org.armedbear.lisp.LispThread.execute(LispThread.java:832) at org.armedbear.lisp.Lisp.evalCall(Lisp.java:582) at org.armedbear.lisp.Lisp.eval(Lisp.java:540) at org.armedbear.lisp.Primitives$pf__eval.execute(Primitives.java:345)`` -- Ticket URL: <http://abcl.org/trac/ticket/433> armedbear <http://abcl.org> armedbear
#433: merge-pathnames blocks error signal? ------------------------------+----------------- Reporter: aruttenberg | Owner: Type: defect | Status: new Priority: major | Milestone: Component: interpreter | Version: Resolution: | Keywords: Parent Tickets: | ------------------------------+----------------- Comment (by mevenson): (as mentioned in <irc:freenode:#abcl> by Ferada: the fix would be to replace the Debug.assertTrue() with code that throws a proper Lisp ERROR. In general, the Debug.assertTrue() instances in the codebase should be audited, and replaced where possible. -- Ticket URL: <http://abcl.org/trac/ticket/433#comment:1> armedbear <http://abcl.org> armedbear
#433: merge-pathnames blocks error signal? ------------------------------+------------------------------------- Reporter: aruttenberg | Owner: Type: defect | Status: closed Priority: major | Milestone: 1.5.0 Component: interpreter | Version: 1.5.0-dev Resolution: fixed | Keywords: cl:pathname :unspecific Parent Tickets: | ------------------------------+------------------------------------- Changes (by mevenson): * keywords: => cl:pathname :unspecific * status: new => closed * version: => 1.5.0-dev * resolution: => fixed * milestone: => 1.5.0 Comment: Fixed (untested) as http://abcl.org/trac/changeset/15032 -- Ticket URL: <http://abcl.org/trac/ticket/433#comment:2> armedbear <http://abcl.org> armedbear
participants (1)
-
armedbear