[armedbear-ticket] [armedbear] #284: checks in ensure-generic-function-using-class should occur later
#284: checks in ensure-generic-function-using-class should occur later -------------------------+-------------------------------------------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: new Priority: minor | Milestone: Component: (A)MOP | Version: Keywords: | -------------------------+-------------------------------------------------- In ensure-generic-function-using-class, abcl is making a few sanity checks and issuing errors, and it is correct to do so according to the HyperSpec. However, since they are done already at such an early stage, some useful MOP idioms are not easily expressible, or at least need to be expressed differently, and I think it would be better to perform the checks at a later stage, for example inside shared-initialize. The concrete case that I encounter is the :lambda-list initialization parameter. In AspectL and filtered-functions, I need to be able to modify the lambda list internally, by adding one or two extra required parameters. I do this, extremely roughly, as follows: {{{ (defmethod initialize-instance :around ((gf my-generic-function) &rest initargs &key lambda-list) (apply #'call-next-method gf :lambda-list (list* extra-parameters… lambda-list) initargs)) }}} All methods that are added to such generic functions also get the extra parameters padded in during method metaobject initialization. However, due to this, the lambda list that ensure-generic-function-using-class sees is, by definition, not congruent with potentially existing methods, and thus complains about this fact with an error. If the check would only occur later (for example in shared-initialize on standard-generic-function), then the modifications would correctly pass through. At least, that is the case in all the other MOP implementations in which AspectL and filtered- functions work. -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284> armedbear <http://common-lisp.net/project/armedbear> armedbear
#284: checks in ensure-generic-function-using-class should occur later -------------------------+-------------------------------------------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: new Priority: minor | Milestone: Component: (A)MOP | Version: Keywords: | -------------------------+-------------------------------------------------- Comment(by rschlatte): (Reported by Pascal Costanza) -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284#comment:1> armedbear <http://common-lisp.net/project/armedbear> armedbear
#284: checks in ensure-generic-function-using-class should occur later -------------------------+-------------------------------------------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: new Priority: blocker | Milestone: 1.2.0 Component: (A)MOP | Version: 1.2.0-dev Keywords: | -------------------------+-------------------------------------------------- Changes (by mevenson): * priority: minor => blocker * version: => 1.2.0-dev * milestone: => 1.2.0 -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284#comment:2> armedbear <http://common-lisp.net/project/armedbear> armedbear
#284: checks in ensure-generic-function-using-class should occur later -------------------------------------------------------------+-------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: new Priority: blocker | Milestone: 1.2.0 Component: (A)MOP | Version: 1.2.0-dev Keywords: closer-mop quicklisp AspectL filtered-functions | -------------------------------------------------------------+-------------- Changes (by mevenson): * keywords: => closer-mop quicklisp AspectL filtered-functions -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284#comment:3> armedbear <http://common-lisp.net/project/armedbear> armedbear
#284: checks in ensure-generic-function-using-class should occur later --------------------------+------------------------------------------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: closed Priority: blocker | Milestone: 1.2.0 Component: (A)MOP | Version: 1.2.0-dev Resolution: fixed | Keywords: closer-mop quicklisp AspectL filtered-functions --------------------------+------------------------------------------------- Changes (by rschlatte): * status: new => closed * resolution: => fixed Comment: (In [14347]) defer checking for lambda list congruence. - fixes #284 -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284#comment:4> armedbear <http://common-lisp.net/project/armedbear> armedbear
#284: checks in ensure-generic-function-using-class should occur later --------------------------+------------------------------------------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: closed Priority: blocker | Milestone: 1.2.0 Component: (A)MOP | Version: 1.2.0-dev Resolution: fixed | Keywords: closer-mop quicklisp AspectL filtered-functions --------------------------+------------------------------------------------- Comment(by mevenson): (In [14348]) Backport r14347 | rschlatte | 2013-01-05 19:39:28 +0100 (Sat, 05 Jan 2013) | 3 lines defer checking for lambda list congruence. - fixes #284 -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284#comment:5> armedbear <http://common-lisp.net/project/armedbear> armedbear
#284: checks in ensure-generic-function-using-class should occur later --------------------------+------------------------------------------------- Reporter: rschlatte | Owner: rschlatte Type: enhancement | Status: closed Priority: blocker | Milestone: 1.1.1 Component: (A)MOP | Version: 1.2.0-dev Resolution: fixed | Keywords: closer-mop quicklisp AspectL filtered-functions --------------------------+------------------------------------------------- Changes (by mevenson): * milestone: 1.2.0 => 1.1.1 -- Ticket URL: <http://trac.common-lisp.net/armedbear/ticket/284#comment:6> armedbear <http://common-lisp.net/project/armedbear> armedbear
participants (1)
-
armedbear