November 2020 - asdf-devel - mailman3.common-lisp.net

[PATCH] Add a TEST-OP-TEST-FAILURE condition for test libraries to sub-class
by Vladimir Sedach 26 Mar '21

26 Mar '21

Hello! I recently wrote a script to run FiveAM tests for one of my libraries on many different implementations on your own machine: https://gitlab.common-lisp.net/uri-template/uri-template2/blob/master/run-t… It would be really nice if I did not have to copy-paste that script to my other libraries, and instead could contribute a generalized version to Roswell (on which the script is based) and have it work for any project using any test library. What I would like to be able to do, for any system: (handler-case (asdf:test-system "system") (asdf:test-op-test-failure (condition) (princ condition uiop:*stderr*) (uiop:quit 1))) The attached patch adds an ASDF:TEST-OP-TEST-FAILURE condition that test libraries can inherit from. I also added the necessary functionality to FiveAM: https://github.com/sionescu/fiveam/pull/58 It should be easy to add similar functionality to other testing libraries. This will make test automation trivial, with few, if any, changes required to systems that use ASDF and the testing libraries. One thing I would like to discuss is which condition ASDF:TEST-OP-TEST-FAILURE should inherit from. It definitely should not be ERROR - there is no error in test-op, or in running the tests; test failures are a regular and expected occurrence of running tests. Also problematic is widespread abuse of HANDLER-CASE to catch any ERROR; I am afraid if signaled from popular test libraries it would break someone's test running code somewhere. WARNING seems like a nice parent condition, but maybe having ASDF:TEST-OP-TEST-FAILURE inherit from CONDITION is a better idea. Thoughts? Vladimir

4 15

Helper function to dump REPL-optimized core
by Pierre Neidhardt 30 Nov '20

30 Nov '20

Hi! Generating a core with pre-loaded packages (namely sb-bsd-sockets, sb-posix, sb-introspect, sb-cltl2, asdf) is a common optimization technique for faster REPL startups. The technique is detailed in the SLIME and SLY manuals. Some may argue that modern machines are fast enough. But from personal experience even on very fast hardware, I find that it makes for a much smoother experience, especially for people using SLIME / SLY as their shell :) I've implemented my own Emacs helper (https://github.com/joaotavora/sly/pull/366) but in https://bugs.launchpad.net/sbcl/+bug/1904042 it was suggested to bring the issue to ASDF which might be the most appropriate place where to share a helper for everyone, independently of the Lisp implementation or editor. So what about adding a function the would dump an optimized core a bit like I did in the SLY pull request: --8<---------------cut here---------------start------------->8--- (defvar *default-core-extra-modules* '(asdf)) (defun asdf:dump-core (&key (path *asdf-default-core-location*) (extra-modules *default-core-extra-modules*)) ... ;; Complete the extra-modules with implementation specific modules, as documented in the SLIME / SLY manuals. (cond ((sbcl-p) (append '(sb-bsd-sockets sb-posix sb-introspect sb-cltl2) extra-modules)) ((ccl-p) ... --8<---------------cut here---------------end--------------->8--- Then all the user would have to do is: --8<---------------cut here---------------start------------->8--- CL-USER> (asdf:dump-core) --8<---------------cut here---------------end--------------->8--- And restart their REPL, assuming they've configured their REPL to use this new core. It can also be useful to only replace an existing core if the modules or the Lisp version are different. This would allow the user to systematically run `asdf:dump-core` before starting their REPL, thus automatically ensuring they run an optimized core. --8<---------------cut here---------------start------------->8--- ;; In Emacs: (setq sly-lisp-implementations '((sbcl (lambda () (call-process "sbcl" nil t nil "--no-userinit" "--eval" "(require :asdf)" "--eval" "(asdf:core-dump)" "--quit") `(("sbcl" "--core" path-to-core)))))) --8<---------------cut here---------------end--------------->8--- Thoughts? -- Pierre Neidhardt https://ambrevar.xyz/

2 5

Question about version in submitting patches
by Mark Evenson 27 Nov '20

27 Nov '20

I’m a little unsure of whether the “Committee for Ongoing and Perpetual ASDF maintenance” (hi Robert!) wishes us to include the results of “<file:bin/bump-version>” in submitted patches. I have a small ABCL-specific patch dealing with UIOP:PARSE-UNIX-NAMESTRING when loading system definitions from zip archives for which I have used bump-version to denote as version “3.3.4.0.1”. I’ve not quite finished my testing to ensure that previous versions of ABCL work well with it, but when I do, do you wish me to include the use of “bump-version” with the patch or is that something the Committee prefers to do on its own? yours, Mark -- "A screaming comes across the sky. It has happened before but there is nothing to compare to it now."

6 6

Unexpected error ..
by gwbennett 26 Nov '20

26 Nov '20

Good morning from Greg Bennett who is running sbcl 2.0.10 under linux mint 19.2 64-bit and using asdf 3.3.6 with mcclim from mcclim-20201016-git via quicklisp. I am working on a large project and wish to capture the results of a trial compile in a file so that I can check notes, warnings, errors, etc.. Such a compile essentially loops over a set of asdf load-systems. Not unnaturally for me, I make mistakes, and sometimes I get blocked by an unexpected error which I believe I have managed to isolate. I am quite unsure about the locus of the unexpected error .. asdf ? sbcl ? mcclim ? their interaction ? so I am starting with asdf-devel. I am uncertain how much to include by way of source files, so i have opted to summarise things here first. New sbcl 2.0.10 in emacs listener Load a set-up-file to ensure I am using asdf 3.3.6 [I gather this is significant for sbcl]. And some of my own logging tools. Two files attached. Load mcclim Running (in-package :cl-user) (a-l "mcclim" "doit" (doit) "Z" :base-name "/home/gwbennett/mcclim-code/") which has the effect of writing the results to a file, in this case /home/gwbennett/LOGS/MCCLIM/MCCLIM2020-lsbcl-to-Z-26-NOV-at-14:5:2.lsp" The process exits with: ; wrote /home/gwbennett/.cache/common-lisp/sbcl-2.0.10-linux-x64/home/gwbennett/mcclim-code/check-qmb/one/test-qmb-tmpJU0JWO19.fasl ; compilation finished in 0:00:00.051 ; No value Now suppose I do something which contains an error, such as CL-USER> (asdf-version) Since (asdf-version) is not in the cl-user package, this is an error. What I get back is a different error message: #<SB-SYS:FD-STREAM for "file /home/gwbennett/LOGS/MCCLIM/MCCLIM2020-lsbcl-to-Z-26-NOV-at-14:5:2.lsp" {1008BEC8A3}> is closed [Condition of type SB-INT:CLOSED-STREAM-ERROR] Which is my unexpected error. Sometimes after ABORT (twice), this error can block me from defining any new function or loading a new function .. all I receive is a repeat of this message. Thank you for your patience Cheers Greg Bennett

2 1

Looking for some ECL help...
by Robert Goldman 19 Nov '20

19 Nov '20

I have pulled in a patch independently derived by Luis Oliveira and Martin Simmons that fixes an issue with launch program. Unfortunately, the test I developed for it *reveals* an issue in ECL. Here's the report: https://gitlab.common-lisp.net/asdf/asdf/-/merge_requests/144 If anyone with ECL expertise has time to give a look into this, I would be grateful. Even if you just have time to tell me how to deal with ECL on this -- it's an issue of ECL not being able to read a pipe stream. Best, R

1 0