Thanks for the patch. See https://gitlab.common-lisp.net/asdf/asdf/-/merge_requests/240

On 10 Jan 2025, at 13:56, Russell L. Carter wrote:

---

doc/asdf.texinfo | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/asdf.texinfo b/doc/asdf.texinfo
index cc3aa287..f0e6dd64 100644
--- a/doc/asdf.texinfo
+++ b/doc/asdf.texinfo
@@ -2131,7 +2131,7 @@ ASDF will compute dependencies from the

@example
(uiop:define-package :my-lib/interface/order

• (:use :closer-common-lisp

• (:use :cl :closer-mop)
  :my-lib/interface/definition
  :my-lib/interface/base)
  (:mix :fare-utils :uiop :alexandria)

@@ -2152,7 +2152,7 @@ context. For example:
@example
(uiop:define-package :my-lib/interface/all
(:nicknames :my-lib-interface)

• (:use :closer-common-lisp)

• (:use :cl :closer-mop)
  (:mix :fare-utils :uiop :alexandria)
  (:use-reexport
  :my-lib/interface/definition

--
2.45.2

On 1/10/25 2:21 PM, Russell L. Carter wrote:

It would seem so if I'm reading the macrolet
define-closer-common-lisp-package
correctly:

https://github.com/pcostanza/closer-mop/blob/master/closer-mop- packages.lisp

Since the example is supposed to be expository rather than a
a professional code snippet I see no problem with your suggestion.
An expert would factor that in, I would think, and people like me
wouldn't know the difference.

Russell

On 1/10/25 1:18 PM, Robert Goldman wrote:

There's a problem with this patch that highlights a problem with the example.

The problem is that the package |:closer-common-lisp| is a new package that exports all the external symbols in |:closer-mop| (a portability layer for the meta object protocol) /and/ all the external symbols of |:common-lisp|. So adding |:cl| to the |:use| list in this example does nothing.

I /think/ a better fix for this example would be to replace | (:use :closer-common-lisp)| with |(:use :cl :closer-mop)| everywhere.

On 10 Jan 2025, at 11:49, Russell L. Carter wrote:

    Hi Robert,
    I decided against modifying the UIOP doc because although
    the existing wording is quite concise it is also correct,
    AFAICT. Any edits I could conceive would alter the
    style and as a maker of many words myself I am loathe
    to do that.

    I'm also open to any style nitpicks in this tiny patch.
    I'm not interested in being different from existing
    code conventions, etc.

---

    doc/asdf.texinfo | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/doc/asdf.texinfo b/doc/asdf.texinfo
    index cc3aa287..5da42b32 100644
    --- a/doc/asdf.texinfo
    +++ b/doc/asdf.texinfo
    @@ -2131,7 +2131,7 @@ ASDF will compute dependencies from the

    @example
    (uiop:define-package :my-lib/interface/order

      * (:use :closer-common-lisp

      * (:use :cl :closer-common-lisp
        :my-lib/interface/definition
        :my-lib/interface/base)
        (:mix :fare-utils :uiop :alexandria)

    @@ -2152,7 +2152,7 @@ context. For example:
    @example
    (uiop:define-package :my-lib/interface/all
    (:nicknames :my-lib-interface)

      * (:use :closer-common-lisp)

      * (:use :cl :closer-common-lisp)
        (:mix :fare-utils :uiop :alexandria)
        (:use-reexport
        :my-lib/interface/definition

    --
    2.45.2

    On 1/9/25 5:38 PM, Robert Goldman wrote:

        Thank you! A patch will be very welcome.

        On 9 Jan 2025, at 16:01, Russell L. Carter wrote:

        |I will do this tomorrow. Russell On 1/9/25 4:56 PM, Faré wrote:
        On Thu, Jan 9, 2025, 10:16 Russell L. Carter <rcarter@pinyon.org
        mailto:rcarter@pinyon.org mailto:rcarter@pinyon.org
        mailto:rcarter@pinyon.org> wrote: |Finally I'll note that the
        only examples I've seen, and I actually did suck down the repo
        for lisp-interface-library, do not show :use :cl.  For
        instance have a look at the code snippets from the ASDF.pdf
        manual on page 26.  There are two there, and neither has a
        use :cl or :common-lisp or whatever. To fix this is trivial.         Add in a :use :cl in those code snippets, and perhaps add "be
        sure to add :use :cl if you :use any other systems" in the docs
        for uiop:define-package. | Are you frustrated enough to locate
        and fix all the misleading documentation? I admit I'm fully
        responsible for getting it wrong, but I have ceased being active
        in Common Lisp or as an ASDF developer long ago. (These days:
        Gerbil Scheme, and... some Haskell recently.) The current
        maintainers and future documentation readers will thank you. git
        grep -i define-package should help you. Regards, -#f |