I suppose it would be better to release 3.0.3 without merging my branches, and merge my branches afterwards. On the other hand, there are a few bugs I fixed in my run-program branch, independently from the new functionality, that I'd like to commit in the master branch before the release, with your permission:
* the external-format bug in with-temporary-file is shameful. Sorry. * the stdin / stdout / stderr initialization is better, and allows run-program to work at all on ECL when in SLIME (or in many other cases). * the slight changes in external-format defaults (from :default to utf-8) should be done earlier rather than later (for increased consistency) * the new docstrings are also merge-worthy.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org Few people are capable of expressing with equanimity opinions which differ from the prejudices of their social environment. Most people are even incapable of forming such opinions. — Albert Einstein
Faré wrote:
I suppose it would be better to release 3.0.3 without merging my branches, and merge my branches afterwards. On the other hand, there are a few bugs I fixed in my run-program branch, independently from the new functionality, that I'd like to commit in the master branch before the release, with your permission:
- the external-format bug in with-temporary-file is shameful. Sorry.
- the stdin / stdout / stderr initialization is better, and allows
run-program to work at all on ECL when in SLIME (or in many other cases).
- the slight changes in external-format defaults (from :default to utf-8)
should be done earlier rather than later (for increased consistency)
- the new docstrings are also merge-worthy.
I'm hoping to be able to pull in your run-program branch altogether.
I would like to release 3.0.3 very soon, but need to run the tests on the branch, then merge.
Cheers, r
On Sun, Sep 29, 2013 at 10:00 PM, Robert P. Goldman rpgoldman@sift.info wrote:
I'm hoping to be able to pull in your run-program branch altogether.
Oh, excellent! I just pushed some more documentation on that branch, together with a slight tweak for *standard-readtable* (the use of which around reading .asd files was actually postponed until a further release of ASDF because some systems in Quicklisp were being evil about modifying the current readtable from inside a .asd file).
I would like to release 3.0.3 very soon, but need to run the tests on the branch, then merge.
I ran all tests for commit 3176b41 on Linux x64 with export ASDF_TEST_LISPS='ccl clisp sbcl ecl ecl_bytecodes cmucl abcl allegro allegromodern xcl' I only tested the trivial changes from there to bfca2e78 with ccl.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org Merely having an open mind is nothing; the object of opening the mind, as of opening the mouth, is to shut it again on something solid. — G.K. Chesterton
-
Faré -
Robert P. Goldman