Hello ASDF maintainers,
I just completed a port of ASDF 3.0.3 to what will soon be released as MKCL 1.1.7. It currently passes all the 48 tests of yours on Linux (Ubuntu 12.04) and I will very soon test it on Win32 and Win64 (I expect a routine ride there).
I would like to submit back to you the few lines of ASDF code I had to conditionalize to get this port working OK.
Can we do this through a "Pull request" on github? I see both a fare/asdf and a rpgoldman/asdf repositories that look like the head of ASDF evolution which one should I fork, merge with and then send the pull?
Cheers,
JCB
Jean-Claude Beaudoin wrote:
Hello ASDF maintainers,
I just completed a port of ASDF 3.0.3 to what will soon be released as MKCL 1.1.7. It currently passes all the 48 tests of yours on Linux (Ubuntu 12.04) and I will very soon test it on Win32 and Win64 (I expect a routine ride there).
I would like to submit back to you the few lines of ASDF code I had to conditionalize to get this port working OK.
Can we do this through a "Pull request" on github? I see both a fare/asdf and a rpgoldman/asdf repositories that look like the head of ASDF evolution which one should I fork, merge with and then send the pull?
Cheers,
JCB
It would actually be better to use the cl.net git repository. From the web page:
git clone git://common-lisp.net/projects/asdf/asdf.git
I'm afraid that this means that we couldn't use the pull request framework, but you could submit using format-patch.
One concern is that we are on 3.1.0.67, and there have been fairly significant changes since 3.0.3.
But if the changes are localized, we can probably figure out how to merge them into head.
Best, R
On Wed, Feb 19, 2014 at 10:02 AM, Robert P. Goldman rpgoldman@sift.info wrote:
Jean-Claude Beaudoin wrote:
Hello ASDF maintainers,
I just completed a port of ASDF 3.0.3 to what will soon be released as MKCL 1.1.7. It currently passes all the 48 tests of yours on Linux (Ubuntu 12.04) and I will very soon test it on Win32 and Win64 (I expect a routine ride there).
I would like to submit back to you the few lines of ASDF code I had to conditionalize to get this port working OK.
Can we do this through a "Pull request" on github? I see both a fare/asdf and a rpgoldman/asdf repositories that look like the head of ASDF evolution which one should I fork, merge with and then send the pull?
Although the official master is on common-lisp.net, my github repository is up-to-date and I'll gladly handle pull requests; or you can email a patch, as per git format-patch -1, against master. Please send the request ASAP, so it's included in the imminent 3.1.1 release.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org The whole modern world has divided itself into Conservatives and Progressives. The business of Progressives is to go on making mistakes. The business of the Conservatives is to prevent the mistakes from being corrected. — G.K. Chesterton
Dear JCB,
while you're at it, beside making it work with the latest 3.1, you can look at the ECL-only tests and mkcl workarounds in the tests (grep for ecl and mkcl tests/ and subdirectories). It would be great if you could make them work on MKCL, too. test-bundle and test-program notably are likely buggy on MKCL, since they are not tested.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org Men have a much better time of it than women; for one thing they marry later; for another thing they die earlier. — H.L. Mencken
On Thu, Feb 20, 2014 at 9:09 PM, Faré fahree@gmail.com wrote:
while you're at it, beside making it work with the latest 3.1, you can look at the ECL-only tests and mkcl workarounds in the tests (grep for ecl and mkcl tests/ and subdirectories). It would be great if you could make them work on MKCL, too. test-bundle and test-program notably are likely buggy on MKCL, since they are not tested.
Interesting. I had not noticed those ECL-only tests, I'll give them a try...
On Thu, Feb 20, 2014 at 7:23 PM, Faré fahree@gmail.com wrote:
On Wed, Feb 19, 2014 at 10:02 AM, Robert P. Goldman rpgoldman@sift.info wrote:
Jean-Claude Beaudoin wrote:
Hello ASDF maintainers,
I just completed a port of ASDF 3.0.3 to what will soon be released as MKCL 1.1.7. It currently passes all the 48 tests of yours on Linux (Ubuntu 12.04) and I will very soon test it on Win32 and Win64 (I expect a routine ride there).
I would like to submit back to you the few lines of ASDF code I had to conditionalize to get this port working OK.
Can we do this through a "Pull request" on github? I see both a fare/asdf and a rpgoldman/asdf repositories that look like the head of ASDF evolution which one should I fork, merge with and then send the pull?
Although the official master is on common-lisp.net, my github repository is up-to-date and I'll gladly handle pull requests; or you can email a patch, as per git format-patch -1, against master. Please send the request ASAP, so it's included in the imminent 3.1.1 release.
It's most probably going to be a git format-patch. I'll try to do the work over this weekend.
-
Faré -
Jean-Claude Beaudoin -
Robert P. Goldman