Now is the time to speak up if there's any reason I should *not* merge the experimental-submodules branch, which will make ASDF freestanding by pulling in its build dependencies.
I'll probably merge this and push sometime tomorrow.
Cheers, r
On Wed, Aug 27, 2014 at 9:49 PM, Robert P. Goldman rpgoldman@sift.info wrote:
Now is the time to speak up if there's any reason I should *not* merge the experimental-submodules branch, which will make ASDF freestanding by pulling in its build dependencies.
I'll probably merge this and push sometime tomorrow.
Well, as for me, I'd rather you somehow rebase -i it into a single commit (using the squash option) that you then merge into master, than merge the branch including all of cl-ppcre into master.
So: yes to making the end-result part of master, if possible no to plain merge'ing the intermediate commits.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org Every program has at least one bug and can be shortened by at least one instruction — from which, by induction, one can deduce that every program can be reduced to one instruction which doesn't work.
Hello,
with apologies for not having done the job in the first place, I would recommend using subtrees [1] instead of submodules. The most promiment difference for people who check out and use the repo is that they don't have to deal with 'git submodule init, git submodule update'.
The subtree is already in the checked out source as if it was an integral part of it, and it is fixed to a certain commit at the time when the git subtree command was issued by the maintainer(s) which minimises the risk of checking out an incompatible version with git submodule update.
I have pushed an updated version of your experimental-submodules branch to
https://github.com/darabi/asdf/commits/experimental-submodules
As you can see, all files are already present:
https://github.com/darabi/asdf/tree/experimental-submodules/ext/cl-ppcre
With git subtree split, it is easily possible to fix bugs in the ext/* repos and contribute them back to the original repo.
I will update the README with the exact commands which were necessary to create the subtrees and which ones to use to update/split the repos, if that file is the correct place for the documentation (maybe you would prefer having one single README at the top-leve).
Cheers
Kambiz
[1] https://github.com/git/git/blob/master/contrib/subtree/git-subtree.txt
On 2014-08-28 03:49 CEST, "Robert P. Goldman" rpgoldman@sift.info wrote:
Now is the time to speak up if there's any reason I should *not* merge the experimental-submodules branch, which will make ASDF freestanding by pulling in its build dependencies.
I'll probably merge this and push sometime tomorrow.
Cheers, r
Asdf-devel mailing list Asdf-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
Actually, I believe git submodule is a *huge* plus in this case, since it means you can choose whether or not you want to checkout the dependencies. I for one don't usually want them to interfere with my otherwise checked out dependencies.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org In Italia i fascisti si dividono in due categorie: i fascisti e gli antifascisti. — Ennio Flaiano
On Sat, Aug 30, 2014 at 9:12 AM, Kambiz Darabi darabi@m-creations.com wrote:
Hello,
with apologies for not having done the job in the first place, I would recommend using subtrees [1] instead of submodules. The most promiment difference for people who check out and use the repo is that they don't have to deal with 'git submodule init, git submodule update'.
The subtree is already in the checked out source as if it was an integral part of it, and it is fixed to a certain commit at the time when the git subtree command was issued by the maintainer(s) which minimises the risk of checking out an incompatible version with git submodule update.
I have pushed an updated version of your experimental-submodules branch to
https://github.com/darabi/asdf/commits/experimental-submodules
As you can see, all files are already present:
https://github.com/darabi/asdf/tree/experimental-submodules/ext/cl-ppcre
With git subtree split, it is easily possible to fix bugs in the ext/* repos and contribute them back to the original repo.
I will update the README with the exact commands which were necessary to create the subtrees and which ones to use to update/split the repos, if that file is the correct place for the documentation (maybe you would prefer having one single README at the top-leve).
Cheers
Kambiz
[1] https://github.com/git/git/blob/master/contrib/subtree/git-subtree.txt
On 2014-08-28 03:49 CEST, "Robert P. Goldman" rpgoldman@sift.info wrote:
Now is the time to speak up if there's any reason I should *not* merge the experimental-submodules branch, which will make ASDF freestanding by pulling in its build dependencies.
I'll probably merge this and push sometime tomorrow.
Cheers, r
Asdf-devel mailing list Asdf-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
Asdf-devel mailing list Asdf-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
I don't know how many people are devs and how many people just 'users' in the sense that they clone the repo and use it without caring about the dependencies of asdf.
But your point is definitively valid.
Cheers
Kambiz
On 2014-08-30 22:46 CEST, Faré fahree@gmail.com wrote:
Actually, I believe git submodule is a *huge* plus in this case, since it means you can choose whether or not you want to checkout the dependencies. I for one don't usually want them to interfere with my otherwise checked out dependencies.
—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org In Italia i fascisti si dividono in due categorie: i fascisti e gli antifascisti. — Ennio Flaiano
On Sat, Aug 30, 2014 at 9:12 AM, Kambiz Darabi darabi@m-creations.com wrote:
Hello,
with apologies for not having done the job in the first place, I would recommend using subtrees [1] instead of submodules. The most promiment difference for people who check out and use the repo is that they don't have to deal with 'git submodule init, git submodule update'.
The subtree is already in the checked out source as if it was an integral part of it, and it is fixed to a certain commit at the time when the git subtree command was issued by the maintainer(s) which minimises the risk of checking out an incompatible version with git submodule update.
I have pushed an updated version of your experimental-submodules branch to
https://github.com/darabi/asdf/commits/experimental-submodules
As you can see, all files are already present:
https://github.com/darabi/asdf/tree/experimental-submodules/ext/cl-ppcre
With git subtree split, it is easily possible to fix bugs in the ext/* repos and contribute them back to the original repo.
I will update the README with the exact commands which were necessary to create the subtrees and which ones to use to update/split the repos, if that file is the correct place for the documentation (maybe you would prefer having one single README at the top-leve).
Cheers
Kambiz
[1] https://github.com/git/git/blob/master/contrib/subtree/git-subtree.txt
On 2014-08-28 03:49 CEST, "Robert P. Goldman" rpgoldman@sift.info wrote:
Now is the time to speak up if there's any reason I should *not* merge the experimental-submodules branch, which will make ASDF freestanding by pulling in its build dependencies.
I'll probably merge this and push sometime tomorrow.
Cheers, r
Asdf-devel mailing list Asdf-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
Asdf-devel mailing list Asdf-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/asdf-devel
-
Faré -
Kambiz Darabi -
Robert P. Goldman