Hello Wenpeng,
I missed an obvious problem with your patch, it depends on Lisps loading gbk-map.lisp using the UTF-8 encoding. AFAIK, there's no good way to portably enforce that via ASDF, so I've converted the file to an ASCII representation. It's not as pretty as the previous version, but it seems to work.
Cheers,
Hi,Luís Oliveira
Thanks for telling me this problem, and I'm also glad that you fixed it, sorry for the problem, I didn't take much consideration into this problem when I was writing, BTW, ASCII representation is pretty enough.
Another problem you mentioned in the github issue list, I'd try to learn how to write the ASDF tests suite.
Wenpeng Li
On Tue, Jan 3, 2012 at 6:05 AM, Luís Oliveira luismbo@gmail.com wrote:
Hello Wenpeng,
I missed an obvious problem with your patch, it depends on Lisps loading gbk-map.lisp using the UTF-8 encoding. AFAIK, there's no good way to portably enforce that via ASDF, so I've converted the file to an ASCII representation. It's not as pretty as the previous version, but it seems to work.
Cheers,
-- Luís Oliveira http://r42.eu/~luis/
-
levin -
Luís Oliveira