[bknr-devel] BKNR.datastore: support for serializing/deserializing arrays with complex (list) element-types
Hi, I'd like to be able to store vectors of element-type '(unsigned-byte 8) using bknr.datastore. The included patch seems work to that end. Please consider it for inclusion. Thank you, Vladimir
Hi Vladimir, thank you for your patch. I am interested in applying it, but as it currently stands, I think it does break backward compatibility for stores. Can you change it so that both old-format and new-format stores can be read? Writing the old format need not be supported. Thanks! Hans On Wed, Apr 6, 2011 at 4:47 AM, Vladimir Sedach <vsedach@gmail.com> wrote:
Hi,
I'd like to be able to store vectors of element-type '(unsigned-byte 8) using bknr.datastore. The included patch seems work to that end. Please consider it for inclusion.
Thank you, Vladimir
_______________________________________________ bknr-devel mailing list bknr-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/bknr-devel
Hi Hans, Here is the updated patch with backwards compatibility (something which I always forget!). Unfortunately it is a bit ugly and I don't know how to make it better. I guess one lesson here is to add tags to all binary data if you're designing a new serialization scheme. Vladimir On Wed, Apr 6, 2011 at 12:59 AM, Hans Hübner <hans.huebner@gmail.com> wrote:
Hi Vladimir,
thank you for your patch. I am interested in applying it, but as it currently stands, I think it does break backward compatibility for stores. Can you change it so that both old-format and new-format stores can be read? Writing the old format need not be supported.
Thanks! Hans
On Wed, Apr 6, 2011 at 4:47 AM, Vladimir Sedach <vsedach@gmail.com> wrote:
Hi,
I'd like to be able to store vectors of element-type '(unsigned-byte 8) using bknr.datastore. The included patch seems work to that end. Please consider it for inclusion.
Thank you, Vladimir
_______________________________________________ bknr-devel mailing list bknr-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/bknr-devel
Hi Vladimir, I know that it has been a long time since you posted this patch and I did not comment, but here is my reply anyway: On Fri, Apr 8, 2011 at 11:17 PM, Vladimir Sedach <vsedach@gmail.com> wrote:
Here is the updated patch with backwards compatibility (something which I always forget!). Unfortunately it is a bit ugly and I don't know how to make it better. I guess one lesson here is to add tags to all binary data if you're designing a new serialization scheme.
We already have tags for all data types. The patch that you've submitted thus is not really adding the feature at the proper level. If you are still interested, I would propose that you fix the problem by adding a new pair of encoding functions for typed arrays (%encode-typed-array and %decode-typed-array), a new type tag for that (#\t) and code in encode-array to decide whether an untyped or a typed array should be written (although I suppose you could always write typed arrays, too). Again, sorry for the long delay. I'm only slowly picking up the work that I've been deferring for too long. -Hans
Hi Hans, I am indeed not interested anymore, but thank you for the feedback. I didn't think of adding a "typed array" type, that is a better solution. In any case, if someone wants this, they'll hopefully come across this email thread and figure out what to do. Vladimir On Wed, Dec 7, 2011 at 3:46 AM, Hans Hübner <hans.huebner@gmail.com> wrote:
Hi Vladimir,
I know that it has been a long time since you posted this patch and I did not comment, but here is my reply anyway:
On Fri, Apr 8, 2011 at 11:17 PM, Vladimir Sedach <vsedach@gmail.com> wrote:
Here is the updated patch with backwards compatibility (something which I always forget!). Unfortunately it is a bit ugly and I don't know how to make it better. I guess one lesson here is to add tags to all binary data if you're designing a new serialization scheme.
We already have tags for all data types. The patch that you've submitted thus is not really adding the feature at the proper level. If you are still interested, I would propose that you fix the problem by adding a new pair of encoding functions for typed arrays (%encode-typed-array and %decode-typed-array), a new type tag for that (#\t) and code in encode-array to decide whether an untyped or a typed array should be written (although I suppose you could always write typed arrays, too).
Again, sorry for the long delay. I'm only slowly picking up the work that I've been deferring for too long.
-Hans
participants (2)
-
Hans Hübner -
Vladimir Sedach