Re: [bknr-devel] Problems with XML import/export, can't follow the tutorial
Hello, 2010/5/27 Frederico Muñoz <fsmunoz@gmail.com>: (...)
I'll go back at it and hope to have something to show soon (well, for relative values of soon).
Well, I have pulled some changes to my github fork. The good news is that the tutorial now works. However, I'm sure that my changes could have been done is some better way - the code is not easy for me to follow. There are different approaches to how to do the exporting: I've maintained write-to-xml as the main one. It outputs to *standard-output*, or to any sink that is passed to it. I've made it a a macro (that is compatible with the usage seen in the tutorial) and renamed the original write-to-xml to build-xml (since it doesn't actuall write anything by itself). I haven't tested it deeply, but it mostly works. I'm now trying to understand the code better and see if there is any part in there that is a left-over of previous rewrites, etc. One of the things I will surely do is to document the functions - and also document the whole conversion process, since the way it works is sometimes hard to track. Regards, Frederico
Hi Frederico, thank you for your work! I have one request, though: Can you reconfigure your emacs so that it does not insert tabs into source files? It seems that some changes you made resulted in some indentation changes and now the code looks ugly and badly indented when inspected with the github web ui (i.e. http://github.com/fsmunoz/bknr-datastore/commit/9639adbfed1050daee08dab8db2a...) (setq-default indent-tabs-mode nil) in your .emacs should do fine. I'll review your changes and let you know if I think that there is something which I'd like to see changed. I'm going to pull them over into my repository once you think that the stuff is usable enough for you. Thanks again! Hans 2010/5/28 Frederico Muñoz <fsmunoz@gmail.com>:
Hello,
2010/5/27 Frederico Muñoz <fsmunoz@gmail.com>: (...)
I'll go back at it and hope to have something to show soon (well, for relative values of soon).
Well, I have pulled some changes to my github fork. The good news is that the tutorial now works. However, I'm sure that my changes could have been done is some better way - the code is not easy for me to follow.
There are different approaches to how to do the exporting: I've maintained write-to-xml as the main one. It outputs to *standard-output*, or to any sink that is passed to it. I've made it a a macro (that is compatible with the usage seen in the tutorial) and renamed the original write-to-xml to build-xml (since it doesn't actuall write anything by itself).
I haven't tested it deeply, but it mostly works. I'm now trying to understand the code better and see if there is any part in there that is a left-over of previous rewrites, etc. One of the things I will surely do is to document the functions - and also document the whole conversion process, since the way it works is sometimes hard to track.
Regards,
Frederico
Hello, 2010/5/28 Hans Hübner <hans.huebner@gmail.com>:
Hi Frederico,
thank you for your work! I have one request, though: Can you reconfigure your emacs so that it does not insert tabs into source files? It seems that some changes you made resulted in some indentation changes and now the code looks ugly and badly indented when inspected with the github web ui (i.e. http://github.com/fsmunoz/bknr-datastore/commit/9639adbfed1050daee08dab8db2a...)
(setq-default indent-tabs-mode nil) in your .emacs should do fine.
Argh, sorry about that. I usually have that in my init.el, but I didn't yet copy it to my new installation. Will do another commit fixing that.
I'll review your changes and let you know if I think that there is something which I'd like to see changed. I'm going to pull them over into my repository once you think that the stuff is usable enough for you.
Yes, comments are extremely helpful, even general ones (of course, as time permits). There are several different possible approaches, I chose one, but it could be that there are some better ways. Code-wise it goes without saying that the same applies. Regards, Frederico
Hi, Just one small detail: I've run untabify in the files, and pushed a commit with the changes. I'm new to git, but should I use rebase so ou can see the changes more easily, or is this enough? Regards, Frederico
2010/5/28 Frederico Muñoz <fsmunoz@gmail.com>:
Just one small detail: I've run untabify in the files, and pushed a commit with the changes. I'm new to git, but should I use rebase so ou can see the changes more easily, or is this enough?
I'd prefer if you could eventually rebase your commits and squash them into one before I pull them. That way, the log will be easier to follow. I'll review the changes as they are later tonight if you don't manage to rebase them right away. Cheers, Hans
Hi, 2010/5/28 Hans Hübner <hans.huebner@gmail.com>:
I'd prefer if you could eventually rebase your commits and squash them into one before I pull them. That way, the log will be easier to follow. I'll review the changes as they are later tonight if you don't manage to rebase them right away.
I've tried to, but I'm afraid I probably didn't do it correctly. I reset my master by using upstream/master, forced the push to github, switch to my wip branch, did a git rebase master. The switched to my local master, merged the wip branch, and did a push.
From reading the docs I was expecting something more akin to a single commit, which isn't the case. I'm likely missing a step, or doing one to many.
Regards, Frederico
participants (2)
-
Frederico Muñoz -
Hans Hübner