Hello Bordeaux-threads developers,
Here is attached my port of bordeaux-threads 0.8.2 to MKCL. The first file is a patch, done with git format-patch against your git repository on common-lisp.net, that modifies bordeaux-threads.asd. The second file is to be dropped as is in your "src" directory.
I hope you will find this adequate for your purpose.
Regards,
Jean-Claude Beaudoin
On Sat, 2012-08-04 at 23:25 -0400, Jean-Claude Beaudoin wrote:
Hello Bordeaux-threads developers,
Here is attached my port of bordeaux-threads 0.8.2 to MKCL. The first file is a patch, done with git format-patch against your git repository on common-lisp.net, that modifies bordeaux-threads.asd. The second file is to be dropped as is in your "src" directory.
I hope you will find this adequate for your purpose.
Thanks, patch committed. Do all tests pass on MKCL ?
On Sun, Aug 5, 2012 at 10:00 AM, Stelian Ionescu sionescu@cddr.org wrote:
Thanks, patch committed. Do all tests pass on MKCL ?
After installing FiveAM I did the following in the MKCL repl:
jean-claude@mars> mkcl
(aload :bordeaux-threads-test)
;;; Loading "/home/jean-claude/CL/MKCL/dev/mkcl/contrib/bordeaux-threads-0.8.2/bordeaux-threads-test.asd" ;;; Loading "/home/jean-claude/CL/MKCL/mkcl-1.1.0/lib/mkcl-1.1.0/contrib/fiveam.asd" ;;; Loading "/home/jean-claude/CL/MKCL/mkcl-1.1.0/lib/mkcl-1.1.0/contrib/alexandria.asd" ;;; Loading "/home/jean-claude/CL/MKCL/mkcl-1.1.0/lib/mkcl-1.1.0/contrib/bordeaux-threads.asd" ;;; Loading "/home/jean-claude/CL/MKCL/mkcl-1.1.0/lib/mkcl-1.1.0/contrib/alexandria.fasb" ;;; Loading "/home/jean-claude/CL/MKCL/mkcl-1.1.0/lib/mkcl-1.1.0/contrib/fiveam.fasb" ;;; Loading "/home/jean-claude/CL/MKCL/mkcl-1.1.0/lib/mkcl-1.1.0/contrib/bordeaux-threads.fasb" ;;; Compiling /home/jean-claude/CL/MKCL/dev/mkcl/contrib/bordeaux-threads-0.8.2/test/bordeaux-threads-test.lisp. ;;; Finished compiling /home/jean-claude/CL/MKCL/dev/mkcl/contrib/bordeaux-threads-0.8.2/test/bordeaux-threads-test.lisp. ;;; Loading "/home/jean-claude/CL/MKCL/dev/mkcl/contrib/bordeaux-threads-0.8.2/test/bordeaux-threads-test.fas" ;;; Warning: Redefining BORDEAUX-THREADS-TEST::USING-LOCK in deflookup-table named IT.BESE.FIVEAM::FIXTURE T
I don't understand the warning so I just ignored it. Then I did:
(IT.BESE.FIVEAM:RUN!)
.............................................................................................................................................................................................................. Did 206 checks. Pass: 206 (100%) Skip: 0 ( 0%) Fail: 0 ( 0%)
NIL
Is this the proper way to run the test suite?
Cheers,
Jean-Claude Beaudoin
On Sun, 2012-08-05 at 15:19 -0400, Jean-Claude Beaudoin wrote: [...]
;;; Warning: Redefining BORDEAUX-THREADS-TEST::USING-LOCK in deflookup-table named IT.BESE.FIVEAM::FIXTURE T
I don't understand the warning so I just ignored it.
I fixed it in fiveam HEAD, which I'll release soon.
Then I did:
(IT.BESE.FIVEAM:RUN!)
.............................................................................................................................................................................................................. Did 206 checks. Pass: 206 (100%) Skip: 0 ( 0%) Fail: 0 ( 0%)
Is this the proper way to run the test suite?
The best way is (asdf:test-system :fiveam), which is shorthand for (asdf:oos 'asdf:test-op :fiveam). Most good libraries nowadays hook into ASDF to provide a TEST-OP operation, so you should try that the next time you test some library.
bordeaux-threads-devel@common-lisp.net
-
Jean-Claude Beaudoin -
Stelian Ionescu