On Sat, 2014-11-22 at 15:25 +0000, Luís Oliveira wrote:
On Thu, Nov 20, 2014 at 6:36 PM, Liam Healy lnp@healy.washington.dc.us wrote:
I bisected this down to this commit: 4d5479d692f07c641d3218c4728fa43287528366 is the first bad commit commit 4d5479d692f07c641d3218c4728fa43287528366 Author: Sumant Oemrawsingh soemraws@xs4all.nl Date: Fri Oct 31 19:03:54 2014 +0100
Heh, turns out that commit was broken, then Stelian fixed it, then I broke it again. Oh well, PKG-FLAGS should noq be fixed in master. Besides actually working when pkg-config is present (even if it returns an empty list of flags), it also continues gracefully when it isn't.
I strongly object to this last change. When one requests the use of pkg-config, it is because code depending on it needs to access some headers in paths that pkg-config returns, and ignoring that pkg-config is not installed or returned an error will only lead to mysterious errors later, typically unknown types or macros, so please revert commit 41016200d2a8555aa3635a2738652317acdc195c