I have consolidated all the hard work of Cyrus Harmon and Olof-Joachim Frahm over the past six months into a [pull request to the CFFI on github][43] which passes all CFFI tests with ABCL.
@olof: I couldn’t align your [commit entitled "Convert callback return value if necessary”][1] with Cyrus’s latest version. If you could take a look to understand if this patch superseded by Cyrus’s work, or we should recover your work in a different form, I would appreciate it.
Even though we are passing all the CFFI tests,
CL-USER> (drakma:http-request “https://google.com%E2%80%9D)
still times out with an error. Always something further to fix…
All hail Cyrus and Olof!
[43]: https://github.com/cffi/cffi/pull/43 [1]: https://github.com/easye/cffi/commit/36012f655372217133b2a83fb3008380724cb37...
On Wed, Aug 20, 2014 at 10:24 AM, Mark Evenson evenson@panix.com wrote:
I have consolidated all the hard work of Cyrus Harmon and Olof-Joachim Frahm over the past six months into a [pull request to the CFFI on github][43] which passes all CFFI tests with ABCL.
Cool, thanks. I'll have to carefully review some of the non-abcl specific changes. Hope to get to it by the end of the week. I'll send comments to the pull request.
Cheers,
On Wed, Aug 20, 2014 at 9:39 PM, Luís Oliveira luismbo@gmail.com wrote:
Cool, thanks. I'll have to carefully review some of the non-abcl specific changes. Hope to get to it by the end of the week. I'll send comments to the pull request.
I left a couple of comments in some commits. Alas, they don't show in the pull request, so here are the links:
https://github.com/easye/cffi/commit/992c608e47d20e9aea39b35212e681392a4f936... https://github.com/easye/cffi/commit/13e80675df9f2f31e87d03b43bd6b8a952121b0... https://github.com/easye/cffi/commit/03624e609cd48cc065bd15c8dcea715f287b6bb...
Cheers,
On Aug 23, 2014, at 0:35, Luís Oliveira luismbo@gmail.com wrote:
On Wed, Aug 20, 2014 at 9:39 PM, Luís Oliveira luismbo@gmail.com wrote:
Cool, thanks. I'll have to carefully review some of the non-abcl specific changes. Hope to get to it by the end of the week. I'll send comments to the pull request.
I left a couple of comments in some commits. Alas, they don't show in the pull request, so here are the links:
https://github.com/easye/cffi/commit/992c608e47d20e9aea39b35212e681392a4f936... https://github.com/easye/cffi/commit/13e80675df9f2f31e87d03b43bd6b8a952121b0... https://github.com/easye/cffi/commit/03624e609cd48cc065bd15c8dcea715f287b6bb...
Just a note that I am in the process of addressing your concerns, but haven’t had quite the amount of free time that I thought I would have had. Hopefully more news soon.
-
Luís Oliveira -
Mark Evenson