Hi there.
Thanks for all the great work you do here.
I had a problem loading cl-libuv from Quicklisp on Windows because the default installation location for the development package sits in C:/Program Files/libuv, which broke the grovel compilation.
The include path list is split by the code below, fixed by removing the space from the separator list per the patch.
It wasn't clear to me what parse-command-flags was meant to do, given the definitions in grovel.lisp of cl-libuv which control the header search paths.
Is there a place to lodge bug reports on github for cffi?
Maybe one needs to be a contributor?
Cheers
Mike
@@ -33,7 +33,7 @@
;;; Utils
(defun parse-command-flags (flags)
- (let ((separators '(#\Space #\Tab #\Newline #\Return)))
+ (let ((separators '(#\Tab #\Newline #\Return)))
(remove-if 'emptyp (split-string flags :separator separators))))
(defun parse-command-flags-list (strings)
Hello Mike,
On Fri, Aug 4, 2017 at 7:29 AM, mike thomas mjt464@gmail.com wrote:
Is there a place to lodge bug reports on github for cffi?
The bug tracker lives here: https://bugs.launchpad.net/cffi.
@@ -33,7 +33,7 @@
;;; Utils (defun parse-command-flags (flags)
- (let ((separators '(#\Space #\Tab #\Newline #\Return)))
- (let ((separators '(#\Tab #\Newline #\Return))) (remove-if 'emptyp (split-string flags :separator separators))))
(defun parse-command-flags-list (strings)
I think this change will break the case where multiple flags are provided, since those are separated by spaces. I don't remember why we need to do this parsing at all. Do you feel like investigating that?
Cheers,