proposed fixes for cffi-libffi on Windows7+MSYS
So, after a long hiatus I updated CFFI, only to see dreaded compilation errors pop-up. Nothing better to keep me awake for an extra hour. The two patches (in the attached file) fix the error that I see and improve the code slightly. One patch removes ^M that CCL sees at the end of output of pkg-config. The need for the second patch arises in the case when the package loading fails, and I try to load it again. In that case *cc-flags* gets loaded with duplicate entries. This patch removes the duplicates. I generated the patches with the command: git format-patch master --stdout > mv-mods.txt If there is a better way to submit patches, let me know how and I will resend. Thanks, Mirko
On Thu, Apr 7, 2016 at 4:13 AM, Mirko Vukovic <mirko.vukovic@gmail.com> wrote:
If there is a better way to submit patches, let me know how and I will resend.
A pull request on github.com/cffi/cffi would be nice, but let me know if that ends up being too much trouble for you. -- Luís Oliveira http://kerno.org/~luis/
On Fri, Apr 8, 2016 at 12:27 PM, Luís Oliveira <luismbo@gmail.com> wrote:
On Thu, Apr 7, 2016 at 4:13 AM, Mirko Vukovic <mirko.vukovic@gmail.com> wrote:
If there is a better way to submit patches, let me know how and I will resend.
A pull request on github.com/cffi/cffi would be nice, but let me know if that ends up being too much trouble for you.
I just submitted two pull requests. I hope the commit history is clean enough (the diff's are good). I had to break up my work into separate branches and that took a bit of history rewriting. If things look incomprehensible on your end I will try again.
-- Luís Oliveira http://kerno.org/~luis/
participants (2)
-
Luís Oliveira
-
Mirko Vukovic