[cl-gd-devel] proposed patch for WITH-TRANSFORMATION macro
Hi, I use cl-gd extensively and decided to figure out how to eliminate the incessant SBCL generated warnings that trace back to the WITH-TRANSFORMATION macro. It looks like work has already been done there. I came up with a pretty clean solution which removes the existing argument checking, provides it through a different mechanism and satisfies SBCL and backwards compatibility. I don't have any other platforms to test with but I think it will run on anything. I've attached the patch. Regards, Jeff Cunningham
Here's the same patch with the added -b flag to ignore whitespace (sorry about that). --Jeff Jeff Cunningham wrote:
Hi,
I use cl-gd extensively and decided to figure out how to eliminate the incessant SBCL generated warnings that trace back to the WITH-TRANSFORMATION macro. It looks like work has already been done there. I came up with a pretty clean solution which removes the existing argument checking, provides it through a different mechanism and satisfies SBCL and backwards compatibility. I don't have any other platforms to test with but I think it will run on anything. I've attached the patch.
Regards, Jeff Cunningham
------------------------------------------------------------------------
_______________________________________________ cl-gd-devel site list cl-gd-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-gd-devel
Jeff, I have not actually tested your patch, but before I do, can you please re-send it without the debugging format statements that you've left in? Thanks, Hans On Mon, Nov 9, 2009 at 06:47, Jeff Cunningham <j.k.cunningham@comcast.net> wrote:
Here's the same patch with the added -b flag to ignore whitespace (sorry about that).
--Jeff
Jeff Cunningham wrote:
Hi,
I use cl-gd extensively and decided to figure out how to eliminate the incessant SBCL generated warnings that trace back to the WITH-TRANSFORMATION macro. It looks like work has already been done there. I came up with a pretty clean solution which removes the existing argument checking, provides it through a different mechanism and satisfies SBCL and backwards compatibility. I don't have any other platforms to test with but I think it will run on anything. I've attached the patch.
Regards, Jeff Cunningham
________________________________ _______________________________________________ cl-gd-devel site list cl-gd-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-gd-devel
_______________________________________________ cl-gd-devel site list cl-gd-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-gd-devel
Here are the complaints I was getting which are eliminated: warning: Asserted type NUMBER conflicts with derived type (VALUES NULL &OPTIONAL). --> LET LET UNLESS IF PROGN SETQ THE ==> (- #:X214 #:WIDTH15) warning: Asserted type NUMBER conflicts with derived type (VALUES NULL &OPTIONAL). --> LET LET UNLESS IF PROGN SETQ THE ==> (- #:Y217 #:HEIGHT18) warning: Asserted type NUMBER conflicts with derived type (VALUES NULL &OPTIONAL). --> LET LET UNLESS IF PROGN SETQ THE ==> (+ #:Y116 #:HEIGHT18) warning: Asserted type NUMBER conflicts with derived type (VALUES NULL &OPTIONAL). --> LET LET UNLESS IF PROGN SETQ THE ==> (+ #:X113 #:WIDTH15) --Jeff
participants (2)
-
Hans Hübner -
Jeff Cunningham