[cl-gd-devel] clisp ffi
Hello, I've added support for clisp. It's only tested on Solaris, and not very much. The included test suite runs (almost) successfully, but I'm sure there will be bugs in the functionality not covered by these tests. Test 17 (ellipse filled in with tiles) fails, but it fails in the same way in SBCL so that might a problem with Solaris (or with my installation). Test 16 takes ages to complete, but I don't think I will optimize the code (as long as it is fast enough generating simple charts). I had no previous experience with clisp's FFI, so I'm sure there will be things that could have been done better, in particular about performance. The modified files can be found here http://ungil.com/cl-gd-0.4.2-clisp.tgz I've discovered as well some bugs, that I detail at the end of the message (only the first one is really relevant). Cheers, Carlos * [ colors-aux ] (defun resolve-c-color (color image) ......... ((or vector list) (setf (current-style image) (cdr color)) ;;; the first element of the list is dropped, that cdr shouldn't exist +styled+) ......... * [ gd-uffi ] (def-struct gd-image ......... (aal-x1 :int) (aal-y1 :int) (aal-x2 :int) (aal-y1 :int) ;;; this should be aal-y2, right? .......... * [ cl-gd-test ] (compare-files file) ;; the check is missing in test-012
On Wed, 9 Mar 2005 01:44:11 +0100, Carlos Ungil <ungil@mac.com> wrote:
I've added support for clisp.
[...]
The modified files can be found here http://ungil.com/cl-gd-0.4.2-clisp.tgz
I've discovered as well some bugs, that I detail at the end of the message (only the first one is really relevant).
Thanks. I've made a new release which fixes the bugs you found and adds a link to your CLISP port. I'm hesitant to add the port to the CL-GD distribution itself because it adds a large amount of code that I can't and won't maintain. I'd rather wait until CLISP is supported by UFFI... :) Download: <http://weitz.de/files/cl-gd.tar.gz> Thanks again, Edi.
Hello Edi, the link in the http://weitz.de/cl-gd page is wrong. Anyway, I've created a new package (including a README file) and changed the name to make it independent of the release number: http://ungil.com/cl-gd-clisp.tgz Also, I've noticed that you didn't change the images in test/orig. I've not tried, but I would expect some tests to fail (because of the bug that has been fixed). Cheers, Carlos On Mar 9, 2005, at 4:17 PM, Edi Weitz wrote:
On Wed, 9 Mar 2005 01:44:11 +0100, Carlos Ungil <ungil@mac.com> wrote:
I've added support for clisp.
[...]
The modified files can be found here http://ungil.com/cl-gd-0.4.2-clisp.tgz
I've discovered as well some bugs, that I detail at the end of the message (only the first one is really relevant).
Thanks. I've made a new release which fixes the bugs you found and adds a link to your CLISP port. I'm hesitant to add the port to the CL-GD distribution itself because it adds a large amount of code that I can't and won't maintain. I'd rather wait until CLISP is supported by UFFI... :)
Download: <http://weitz.de/files/cl-gd.tar.gz>
Thanks again, Edi.
On Wed, 9 Mar 2005 20:09:10 +0100, Carlos Ungil <ungil@mac.com> wrote:
the link in the http://weitz.de/cl-gd page is wrong.
Argh! Sorry, I was in a hurry. This is fixed now (in 0.4.4).
Anyway, I've created a new package (including a README file) and changed the name to make it independent of the release number:
http://ungil.com/cl-gd-clisp.tgz
Also, I've noticed that you didn't change the images in test/orig. I've not tried, but I would expect some tests to fail (because of the bug that has been fixed).
I've done that now. However, I notice that test #17 still works with CMUCL but fails with AllegroCL, SBCL, and LispWorks. I wonder what the reason might be but I don't have enough time to investigate this at the moment. Any volunteers? Thanks, Edi.
participants (2)
-
Carlos Ungil -
Edi Weitz