cl-irc-devel March 2004

cl-irc-devel@common-lisp.net

2 participants
7 discussions

[cl-irc-devel] [PATCH] Add ChangeLog file
by Erik Huelsmann 16 Mar '04

16 Mar '04

Ok, the first commit in the ChangeLog I propose would contain the following: Now 's the time to object although I presume that the previous 'Ok' still stands. bye, Erik. +++ ChangeLog 2004-03-16 21:39:43.413843588 +0100 @@ -0,0 +1,9 @@ + + + * package.lisp (export): export symbols needed for manipulation + of the different objects + +2004-03-08: + Started tracking changes committed to the repository in this log. + + The ordering in this file is last-at-top. -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

1 0

[cl-irc-devel] [PATCH] make remove-channel api consistent
by Erik Huelsmann 14 Mar '04

14 Mar '04

Hi! On my quest for defmethods that needed defgenerics, I found an inconsistency in the API. I have no idea if this project has any provisions or policies about breaking APIs, so I'm mailing the list. The add-* apis use the object to add to as the first parameter and the object to be added as the second. So does the remove-channel api, except for one point: (remove-channel <channel-object> <user-object>). Resolving this item is not critical, but nice to have. Since parts of code of external parties might depend on the api, I decided to add a warn statement, but leave the api in place. I added a new defmethod which is the same, except that it has its parameters reversed. I'll rewrite the library (and possibly the examples) to use the new API ofcourse - given that there will be no objections. bye, Erik. PS: I don't think I can remember the changes I am committing some months from now, so I'll institute the ChangeLog as previously discussed. The patch: Index: protocol.lisp =================================================================== RCS file: /project/cl-irc/cvsroot/cl-irc/protocol.lisp,v diff -u -r1.2 protocol.lisp --- protocol.lisp 8 Jan 2004 23:11:47 -0000 1.2 +++ protocol.lisp 14 Mar 2004 18:34:35 -0000 @@ -437,6 +437,14 @@ (defmethod remove-channel ((channel channel) (user user)) "Remove `channel' from `user'." + (warn + (concat 'string + "use of depricated API (remove-channel channel user): " + "(remove-channel user channel) is now preferred")) + (remove-channel user channel)) + +(defmethod remove-channel ((user user) (channel channel)) + "Remove `channel' from `user'." (setf (channels user) (remove channel (channels user)))) (defmethod remove-user ((connection connection) (user user)) -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

1 0

[cl-irc-devel] [PATCH] Add defgeneric forms to eliminate style warnings
by Erik Huelsmann 14 Mar '04

14 Mar '04

Hi, Attached is the beginnings of a patch to eliminate style warnings which appear when compiled code is loaded using (asdf:operate 'asdf:load-op 'cl-irc). When using require these warnings don't occur, but that method is said to be only supported on SBCL. While trying to make my own application warning-free, I started doing cl-irc too. If anybody objects to me adding defgenerics, please say so. Also, the current patch adds these defgenerics in the middle of the protocol.lisp file. I think I prefer the beginning of the file, but if anybody has an opinion on that subject I'd like to know that too. bye, Erik. Index: event.lisp =================================================================== RCS file: /project/cl-irc/cvsroot/cl-irc/event.lisp,v --- event.lisp 5 Jan 2004 14:13:03 -0000 1.1.1.1 +++ event.lisp 10 Mar 2004 22:08:40 -0000 @@ -14,6 +14,12 @@ (apply-to-hooks message) (client-log (connection message) message "UNHANDLED-EVENT:")) + +(defgeneric default-hook (message) + (:documentation "Minimum action to be executed upon reception +of the IRC message to keep the connection, channel and user +objects in sync.")) + (defmethod default-hook ((message irc-rpl_whoisuser-message)) (let ((user (find-user (connection message) (second (arguments message)))) Index: protocol.lisp =================================================================== RCS file: /project/cl-irc/cvsroot/cl-irc/protocol.lisp,v --- protocol.lisp 8 Jan 2004 23:11:47 -0000 1.2 +++ protocol.lisp 10 Mar 2004 22:08:41 -0000 @@ -61,6 +61,23 @@ (print-unreadable-object (object stream :type t :identity t) (princ (server-name object) stream))) +(defgeneric add-default-hooks (connection)) +(defgeneric client-raw-log (connection message)) +(defgeneric connectedp (connection)) +(defgeneric read-message (connection)) +(defgeneric start-process (function name)) +(defgeneric start-background-message-handler (connection)) +;;(defgeneric stop-background-message-handler (process)) +(defgeneric read-message-loop (connection)) +(defgeneric read-irc-message (connection)) +(defgeneric send-irc-message (connection command + &optional trailing-argument &rest arguments)) +(defgeneric get-hooks (connection class)) +(defgeneric add-hook (connection class hook)) +(defgeneric remove-hook (connection class hook)) +(defgeneric remove-hoods (connection class)) +(defgeneric remove-all-hooks (connection)) + (defun make-connection (&key (user nil) (server-name "") (server-socket nil) @@ -239,6 +256,8 @@ #-sbcl (warn "make-dcc-connection not supported for this implementation.")) +(defgeneric dcc-close (connection)) + (defmethod read-message ((connection dcc-connection)) (let ((message (read-line (dcc-stream connection)))) (format (output-stream connection) "~A~%" message) @@ -323,6 +342,12 @@ (add-user channel user)) channel)) +(defgeneric find-channel (connection channel)) +(defgeneric remove-all-channels (connection)) +(defgeneric add-channel (connection channel)) +(defgeneric remove-channel (connection channel)) +(defgeneric remove-users (channel)) + (defmethod find-channel ((connection connection) (channel string)) "Return channel as designated by `channel'. If no such channel can be found, return nil." @@ -409,6 +434,16 @@ (new-string (substitute #\~ #\^ new-string))) (string-downcase new-string))) +(defgeneric find-user (connection nickname)) +(defgeneric add-user (object user)) +(defgeneric remove-all-users (connection)) +(defgeneric remove-user (object user)) +;;(defgeneric remove-channel (channel user)) +(defgeneric remove-user-everywhere (connection user)) +(defgeneric find-or-make-user (connection nickname + &key username hostname realname)) +(defgeneric change-nickname (connection user new-nickname)) + (defmethod find-user ((connection connection) (nickname string)) "Return user as designated by `nickname' or nil if no such user is known." @@ -513,6 +548,11 @@ (print-unreadable-object (object stream :type t :identity t) (format stream "~A ~A" (source object) (command object)))) +(defgeneric self-message-p (message)) +(defgeneric find-irc-message-class (type)) +(defgeneric client-log (connection message &optional prefix)) +(defgeneric apply-to-hooks (message)) + (defmethod self-message-p ((message irc-message)) "Did we send this message?" (string-equal (source message) @@ -577,6 +617,8 @@ :accessor ctcp-command))) (defclass standard-ctcp-message (ctcp-mixin message) ()) + +(defgeneric find-ctcp-message-class (type)) (defmacro define-ctcp-message (ctcp-command) (let ((name (intern-message-symbol :ctcp ctcp-command))) -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

1 0

Re: [cl-irc-devel] cl-irc-cvs commit mails?
by Erik Huelsmann 09 Mar '04

09 Mar '04

Hi Erik, > It seems that everything you are doing is correct. I see that the mail > went through fine in Exim also. No errors apparently. I just tried sending > on from my account and it went through so perhaps we just saw some > intermittent bugs of some sorts. Could you try again? I saw your test mail. It came to my box nicely. Did you see the commit mail itself? Anyway, I'll be committing the export of add-default-hooks and remove-all-hooks tonight, so I'll be able to see what happens... > > Also, I noticed there not being a ChangeLog or Changes file in the > > repository. I guess there is no protocol to keep track of commits to > > the repository then? Could someone please confirm (or deny :-) ) this? > > I don't think there is one. You can add one if you like. Well, I wasn't really looking for that kind of work :-) but if the the group thinks it's a good idea to add one, I'll be happy to start one. bye, Erik. -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

2 1

[cl-irc-devel] Next commit; no commit mail
by Erik Huelsmann 09 Mar '04

09 Mar '04

Hi. Sorry to intrude again. I committed my next commit (also a change to package.lisp) making available add-default-hooks and remove-all-hooks. As last time, I expected a mail from cl-irc-cvs@ to confirm the commit but like last time, I did not recieve one. I'm not concerned about this, but I like to review my own changes right after committing by reading the commit mail. It's also a check to see if I put in the right commit message. Anyway: further changes I will propose on the list first and commit after a few days (with no reaction) or after approval. bye, Erik. -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

1 0

[cl-irc-devel] cl-irc-cvs commit mails?
by Erik Huelsmann 09 Mar '04

09 Mar '04

Hi, Last night I committed the change I proposed on the list to the CVS repository at common-lisp.net. Before doing that I subscribed to cl-irc-cvs@.. but I didn't see any commit mail. Am I doing something wrong or should I not expect a commit mail this soon? Also, I noticed there not being a ChangeLog or Changes file in the repository. I guess there is no protocol to keep track of commits to the repository then? Could someone please confirm (or deny :-) ) this? Working to get past the initial quircks, but slowly getting there.... bye, Erik. -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

2 1

[cl-irc-devel] Not all package elements exported
by Erik Huelsmann 03 Mar '04

03 Mar '04

Hi, Working further with the cl-irc library, I found that not all methods and classes are exported. Is it intentional that the following keys are not exported from the package? - nickname - channel - users - name (as in the slot of the channel class) and maybe others I did not check. If it is not intentional, then is there a guideline on what should be exported? I can write a patch if there is something like that... Bye, Erik. -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

cl-irc-devel March 2004