Hi!
Thanks for your patch. However, I think it misses some parts:
> Recent SVN stuff for CL-IRC has broken CL-IRC on Allegro. This patch
> makes a couple of changes:
>
> 1. removes the asdf dependency on flexi-streams when :allegro is a
> feature.
I see this in the patch.
> 2. replaces use of flexi-streams with use of allegro simple-streams
> using conditional compilation. It is possible that some of this
> might break on older versions of ACL. I *believe* it's safe on
> ACL 7.0 and 8.0.
Unless this is automagical by removing flexi-streams, I don't see this one.
> 3. There was a quoted :type option to the channel :visibility slot.
> This caused Allegro to toss a hairball in the MOP. I dequoted it,
> and all seems well.
And definitely not this one. (I'll comment a fix for it soon though, since I already found what you meant.)
> Patch follows. I'm afraid it's just a default svn generated diff ---
> I don't understand svn as well as CVS.
In this respect CVS and svn shouldn't differ much. There are some stray symbols in your patch, did you mean to include them?
> Index: utility.lisp
> ===================================================================
> --- utility.lisp (revision 161)
> +++ utility.lisp (working copy)
> @@ -112,7 +112,7 @@
>
> (defun read-byte-no-hang (stream &optional eof-error-p eof-value)
> (declare (optimize (speed 3) (debug 0) (safety 0)))
> - (when (listen stream)
> + (when (listen stream)all
Here 'all' seems to be misplaced
> (read-byte stream eof-error-p eof-value)))
>
> (defun read-sequence-until (stream target limit &key non-blocking)
> @@ -421,7 +421,6 @@
>
> (defmethod irc-string-downcase ((map-name (eql :ascii))
> string &key (start 0) end)
> - (declare (ignore map-name))
> (string-downcase string :start start :end end))
Your log doesn't say why the declare should be removed...
> (defun parse-isupport-multivalue-argument (argument)
> Index: cl-irc.asd
> ===================================================================
> --- cl-irc.asd (revision 161)
> +++ cl-irc.asd (working copy)
> @@ -16,7 +16,7 @@
> :version "0.5.2"
> :licence "MIT"
> :description "Common Lisp interface to the IRC protocol"
> - :depends-on (:split-sequence :trivial-sockets :flexi-streams)
> + :depends-on (:split-sequence :trivial-sockets #-allegro
> :flexi-streams)
> :properties ((#:author-email . "cl-irc-devel(a)common-lisp.net")
> (#:date . "$Date$")
> ((#:albert #:output-dir) . "doc/api-doc/")
Thanks for your comments and contribution! I hope you'll work with me to 'nail this one'!
bye,
Erik.
--
Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer
