Hi,
Using cl-irc and a non-threaded sbcl on Linux 2.4.20, I had to apply the patch below to prevent the 'quit' command in commands.lisp from generating an error: having a handler bound to an invalid fd.
Thanks for the great library. I would like to know though why you print the UNHANDLED messages to the console while at the same time encouraging the use of hooks...
bye,
Erik Huelsmann
cvs server: Diffing . Index: command.lisp =================================================================== RCS file: /project/cl-irc/cvsroot/cl-irc/command.lisp,v retrieving revision 1.1.1.1 diff -r1.1.1.1 command.lisp 84a85,87
#+(and sbcl (not sb-thread)) (sb-sys:invalidate-descriptor (sb-bsd-sockets:socket-file-descriptor (server-socket connection)))
On Feb 7, 2004, at 5:48 PM, Erik Huelsmann wrote:
Using cl-irc and a non-threaded sbcl on Linux 2.4.20, I had to apply the patch below to prevent the 'quit' command in commands.lisp from generating an error: having a handler bound to an invalid fd.
Brian will probably apply this as he's the threaded guy.
Thanks for the great library. I would like to know though why you print the UNHANDLED messages to the console while at the same time encouraging the use of hooks...
It was really more of a way for me to debug when I did the initial development and should probably be turned of by default (setting client-stream, IIRC, on the connection object to nil will do this).
Brian, Kevin, what do you think? I seem to recall that Brian wanted to turn it off by default some time ago.
Erik.
Erik Enge wrote:
It was really more of a way for me to debug when I did the initial development and should probably be turned of by default (setting client-stream, IIRC, on the connection object to nil will do this).
Brian, Kevin, what do you think? I seem to recall that Brian wanted to turn it off by default some time ago.
I suppose the default should be off. I think it is potentially useful to have a means of logging messages which the end-user has not hooked.
I've worked around this in irc-logger (http://cliki.net/irc-logger) by creating and :around method on cl-irc::irc-message-event and comparing the type of the message to a list of message types that irc-logger handlers. If it is a message that my application doesn't log, then I log that message to the "unknown-message" stream.
On Feb 7, 2004, at 6:42 PM, Kevin Rosenberg wrote:
I suppose the default should be off. I think it is potentially useful to have a means of logging messages which the end-user has not hooked.
Whatever you guys think is best is fine by me. I do not use the library directly anymore (though I really enjoy the benefits from it through meme, minion and lisppaste) so my vote probably doesn't matter that much (though if I were to vote I'd say make it the default to not print to *standard-output*).
Erik.
Erik Huelsmann wrote:
Using cl-irc and a non-threaded sbcl on Linux 2.4.20, I had to apply the patch below to prevent the 'quit' command in commands.lisp from generating an error: having a handler bound to an invalid fd.
Thanks for the patch, I've committed it to CVS.
Thanks for the great library. I would like to know though why you print the UNHANDLED messages to the console while at the same time encouraging the use of hooks...
That's a good question, I wonder the same.
-
Erik Enge -
Erik Huelsmann -
Kevin Rosenberg