Hi,
Working further with the cl-irc library, I found that not all methods and classes are exported. Is it intentional that the following keys are not exported from the package?
- nickname - channel - users - name (as in the slot of the channel class)
and maybe others I did not check. If it is not intentional, then is there a guideline on what should be exported? I can write a patch if there is something like that...
Bye,
Erik.
On Mar 2, 2004, at 1:39 PM, Erik Huelsmann wrote:
Working further with the cl-irc library, I found that not all methods and classes are exported. Is it intentional that the following keys are not exported from the package?
I don't think we want to export everything but certainly any useful operator should be exported. Go ahead and make a patch, you seem to be the main developer these days. ;-)
Anyone object in giving Erik CVS access?
Erik.
Hi,
Working further with the cl-irc library, I found that not all methods and classes are exported. Is it intentional that the following keys are
not
exported from the package?
Ok. I created the patch below. I intentionally added only the slots in the classes. Although remove-all-hooks and add-default-hooks would be good candidates for inclusion in the externals too.
The user and channel class have themselves not been added, since they can be created using their make-* functions. All their slots are exported and most of their methods too. This should allow them to be used in external applications.
I don't think we want to export everything but certainly any useful operator should be exported. Go ahead and make a patch, you seem to be the main developer these days. ;-)
Log: [[[ Add missing slot-accessor operators
* package.lisp: export slot operators in the channel and user classes.
]]]
Index: package.lisp =================================================================== RCS file: /project/cl-irc/cvsroot/cl-irc/package.lisp,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 package.lisp --- package.lisp 5 Jan 2004 14:13:03 -0000 1.1.1.1 +++ package.lisp 3 Mar 2004 21:33:23 -0000 @@ -20,6 +20,12 @@ :parse-raw-message :normalize-nickname :normalize-channel-name + :name + :normalized-name + :topic + :modes + :user-count + :users :server-stream :client-stream :channels @@ -31,6 +37,11 @@ :remove-hooks :get-hooks :make-user + :nickname + :normalized-nickname + :username + :hostname + :realname :change-nickname :irc-message :source
bye,
Erik.
-
Erik Enge -
Erik Huelsmann