#6: [patch] keep server port and password in connection object --------------------+------------------------------------------------------- Reporter: afuchs | Owner: somebody Type: defect | Status: new Priority: major | Milestone: Component: chat | Version: Keywords: | Has_patch: 1 --------------------+------------------------------------------------------- Beirc needs the port and password used to establish a connection in order to reliably reconnect to the same server (ssh port forwards for example can cause localhost to have many irc ports open). So, the attached patch adds them as slots to the connection object.
The patch requires the "external format guessing" patch in order to apply correctly, but the code will run independently. If needed, I'll create another patch that applies to vanilla cl-irc.
#6: [patch] keep server port and password in connection object --------------------------+------------------------------------------------- Reporter: afuchs | Owner: somebody Type: enhancement | Status: new Priority: major | Milestone: Component: chat | Version: Resolution: | Keywords: Has_patch: 1 | --------------------------+------------------------------------------------- Changes (by afuchs):
* type: defect => enhancement
#6: [patch] keep server port and password in connection object --------------------------+------------------------------------------------- Reporter: afuchs | Owner: ehuelsmann Type: enhancement | Status: new Priority: major | Milestone: Component: chat | Version: Resolution: | Keywords: Has_patch: 1 | --------------------------+------------------------------------------------- Changes (by ehuelsmann):
* owner: somebody => ehuelsmann
Comment:
Change sounds reasonable, accepting the issue, but since the patch depends on the encoding-guessing patch (in issue #2), holding up until that one is committed.
#6: [patch] keep server port and password in connection object --------------------------+------------------------------------------------- Reporter: afuchs | Owner: ehuelsmann Type: enhancement | Status: assigned Priority: major | Milestone: Component: chat | Version: Resolution: | Keywords: Has_patch: 1 | --------------------------+------------------------------------------------- Changes (by ehuelsmann):
* status: new => assigned
#6: [patch] keep server port and password in connection object --------------------------+------------------------------------------------- Reporter: afuchs | Owner: ehuelsmann Type: enhancement | Status: closed Priority: major | Milestone: Component: chat | Version: Resolution: fixed | Keywords: Has_patch: 1 | --------------------------+------------------------------------------------- Changes (by ehuelsmann):
* resolution: => fixed * status: assigned => closed
Comment:
This issue has been fixed in r157.
I reserve the right to change all this later though: I think a connection object should hold either or both some userdata and configuration data. (Ticket #16)
At least closing the patch ticket.
The commit is a close resemblense, but not a 1-1 application of the patch attached to the issue.
-
cl-irc