On Fri, Jun 26, 2009 at 3:20 PM, Boris Smilga <boris.smilga@gmail.com> wrote:

Just a minor cavil: does not *STRING-TO-KEY* (or maybe *IDENTIFIER-NAME-TO-KEY*) seem like a better name for this variable?

I would prefer *IDENTIFIER-NAME-TO-KEY* since it gives more context about what the function is used for. *STRING-TO-KEY* is confusing since it's unclear where the "string" is coming from.

Rationale: I would say that the -JSON- and -LISP- parts of the original *JSON-SYMBOLIZE-LISP-KEY* are not in place here because, unlike *JSON-IDENTIFIER-NAME-TO-LISP*, the function does not translate between JSON and Lisp conventions. Further, -SYMBOLIZE- is a very imperative form, and imperatives should, in my humble opinion, be limited to functions with side effects.

What do you think?

- B. Sm.

-Red