Re: [cl-opengl-devel] Re: Two patches...

On Sun, May 4, 2008 at 10:20 AM, Charlie McMackin charliemac+cl-opengl@gmail.com > hunk ./gl/funcs.lisp 8365

• (params (:pointer int64)))

• (params (:pointer int64EXT)))

int64EXT isn't defined anywhere is it? We might want to add those two new types to LOAD-TYPE-MAP in tools/generate-funcs.lisp even though it's not a big deal since the :POINTER type discards it.

hunk ./glut/init.lisp 75 +(defun ensure-init ()

• (when (not (null-pointer-p *argcp*))

•      (foreign-free *argcp*)
  

•      (setf *argcp* (null-pointer)))
  

• (when (not (null-pointer-p *argv*))

•      (foreign-free (mem-aref *argv* :pointer 0))
  

•      (foreign-free *argv*)
  

•      (setf *argv* (null-pointer))))
  

That *argcp* and *argv* stuff was too paranoid of me. I just checked the freeglut sources and we they call strdup on the argv parameter so I'll just get rid of these globals altogether.

The other patch looks fine except for the little detail I pointed out. Can you fix that?

Thanks,