cl-unification-devel

Download

cl-unification-devel@common-lisp.net

February 2011

2 participants
2 discussions

[cl-unification-devel] sequence template bug?
by Robert Brown 19 Feb '11

19 Feb '11

I think vectors should unify with sequence templates. This expression (unify #(0 1 42 3 4 5) #T(sequence 0 1 ?x 3 4 5)) currently fails. How does the following patch look? bob ========== *** test/unification-tests.lisp#1 Wed Feb 16 16:51:33 2011 --- test/unification-tests.lisp Thu Feb 17 15:06:27 2011 *************** *** 99,104 **** --- 99,106 ---- (test t (unify:environment-p (unify #C(0 1) #T(complex #C(0 1))))) (test '(42 T) (v? '?x (unify #T(number ?x) 42)) :multiple-values t) + (test '(42 T) (v? '?x (unify #(0 1 42 3 4 5) #T(sequence 0 1 ?x 3 4 5))) + :multiple-values t) (test-error (unify 42 #T(float 42.0)) :condition-type 'unification-failure *** unifier.lisp#1 Wed Feb 16 16:51:33 2011 --- unifier.lisp Thu Feb 17 15:09:24 2011 *************** *** 476,482 **** :format-arguments (list a b))) ! (defmethod unify ((a vector) (b vector-template) &optional (env (make-empty-environment)) &key &allow-other-keys) (let ((template-lambda-list (sequence-template-lambda-list b)) --- 476,482 ---- :format-arguments (list a b))) ! (defmethod unify ((a vector) (b sequence-template) &optional (env (make-empty-environment)) &key &allow-other-keys) (let ((template-lambda-list (sequence-template-lambda-list b))

2 1

[cl-unification-devel] implement ASDF testing
by Robert Brown 14 Feb '11

14 Feb '11

I'd ilke to add the ability to test cl-unification by evaluating either of: (asdf:test-system 'cl-unification) (asdf:test-system 'cl-unification-test) The change involves adding one line: :in-order-to ((test-op (test-op :cl-unification-test))) to cl-unification.asd and adding the cl-unification-test.asd file below. Any objections? bob ========== ;;;; cl-unification-test.asd (in-package #:asdf) ;; Tests implemented using the ptester framework are run at *load* time, so ;; we tell ASDF that loading a file containing ptester code is never done. ;; This causes ASDF to run all the tests whenever ASDF:LOAD-SYSTEM or ;; ASDF:TEST-SYSTEM is called with argument CL-UNIFICATION-TEST. (defclass ptester-source-file (cl-source-file) () (:documentation "A Common Lisp source file containing ptester code.")) (defmethod operation-done-p ((operation load-op) (component ptester-source-file)) nil) (in-package #:common-lisp-user) (defpackage #:cl-unification-test-system (:use #:common-lisp #:asdf)) (in-package #:cl-unification-test-system) (defsystem #:cl-unification-test :depends-on (:cl-unification :ptester) :components ((:module "test" :components ((:ptester-source-file "unification-tests")))))

2 1