#33: Refactor, document, and unit test 'handle-client-request' ----------------------------------------------+----------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Keywords: refactor 'handle-client-request' | ----------------------------------------------+----------------------------- Currently 'handle-client-request' is a complex function that's somewhat poorly tested and documented. We should refactor it into more manageable pieces, provide better tests and document its behavior more therally.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Changes (by sakhmechet):
* summary: Refactor, document, and unit test 'handle-client-request' => Refactor, document, and unit test overly complex functions
Comment:
We should refactor and unit test 'object-from-request-valid-p' along with 'handle-client-request'.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
We should use 'progv' in 'handle-client-request'.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
We should also refactor the part of the linguistics module that deals with message generation from typespec. It should take advantage of custom dispatching on slot-management-generic-function metaclasses.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
There is a lot of visible slot processing code. We get all visible slots, map over them, check if the slot should be rendered inline, and take some action. We should refactor with HOFs. There are already some HOFs in place, but they're only flexible enough to use for renderers.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
We should refactor humanize-typespec aspect of the linguistics module.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
We should refactor object-visible-slots. It isn't nicely structured and it walks over the elements multiple times. Additionally, if it proves to be a problem, object-visible-slots should cache its computation.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
Refactor datagrid class to use mixins.
#33: Refactor, document, and unit test overly complex functions -------------------------+-------------------------------------------------- Reporter: sakhmechet | Owner: sakhmechet Type: defect | Status: new Priority: medium | Milestone: 0.2 Component: weblocks | Version: pre-0.1 Resolution: | Keywords: refactor 'handle-client-request' -------------------------+-------------------------------------------------- Comment (by sakhmechet):
Prevalence backend should reuse as much of memory backend code as possible.
cl-weblocks-ticket@common-lisp.net
-
cl-weblocks