May 2007 - cl-who-devel@common-lisp.net - mailman3.common-lisp.net

[cl-who-devel] patch + unit test code (Re: *html-empty-tag* bug)
by Mac Chan 28 May '07

28 May '07

Attached is a patch to fix html-empty-tag bug and also some unit test code to help spotting problems in case there are ignorant people like me who submit bad code ;-) Thanks, -- Mac

2 1

[cl-who-devel] convert-tag-to-string-list and *html-empty-tag* bug maybe :)
by Simon Cusack 28 May '07

28 May '07

Hi, >From my testing it seems that the default convert-tag-to-string-list isn't finding the tags in html-empty-tag when it should. It looks like tag is getting converted to a string but *html-empty-tags* are keywords. I changed (member tag *html-empty-tags*) to (member tag *html-empty-tags* :test #'string-equal) and made it happy. the following test (in-package :who) (with-html-output-to-string (blah) (with-html-output (blah) (:input :value "test this") (:div) (:div "test this"))) Used to produce: "<input value='test this'></input><div></div><div>test this</div>" and now produces; "<input value='test this' /><div></div><div>test this</div>"

3 4

[cl-who-devel] MACROLET inside HTM
by Volkan YAZICI 22 May '07

22 May '07

Hi, I've been trying to use MACROLET in HTM with no success: (with-html-output (*standard-output*) (:div (macrolet ((foo (bar) `(:div ,bar))) (htm (foo "baz") (foo "moo"))))) Here's the fully macroexpand result of the above form: (LET ((*STANDARD-OUTPUT* *STANDARD-OUTPUT*)) (PROGN (WRITE-STRING "<div>" *STANDARD-OUTPUT*) (MACROLET ((FOO (BAR) `(:DIV ,BAR))) (HTM (:DIV "baz") (:DIV "moo"))) (WRITE-STRING "</div>" *STANDARD-OUTPUT*))) I will be appreciated if anybody would help me to figure out how to use MACROLET inside HTM bodies. Regards.

2 1

[cl-who-devel] escaping attributes question
by Simon Cusack 22 May '07

22 May '07

Hi all, I have read the syntax and semantics chapter and was just wondering why values in the attribute position aren't escaped by default? Or is there something I am missing? - sim

3 5

[cl-who-devel] semantic for (str NIL) and (esc NIL)
by Mac Chan 08 May '07

08 May '07

Hi all, This happened to me a couple times where I have a form like this (with-html (:html (:body (str (get-error-messages))))) Now if there's no error, (get-error-messages) returns NIL, otherwise it returns a description of the problem. This function also serve as a predicate for other code. But (str (get-error-messages)) actually prints a "NIL" to the browser. Of course I could replace (str (get-error-messages)) with (let ((messages (get-error-messages)) (when messages (str messages)))) or (str (or (get-error-messages) "")) however it's getting rather verbose. But the real issue is that the string "NIL" really doesn't make sense in HTML, XML or JSON. It's only something that a Lisp programmer would understand. So I'm purposing to change the substitution of (str form) => (princ form1 s) to (str form) => (let ((#:result form1)) (when #:result (princ #:result s))) Attached is a diff for this change in case you guys agree that this makes sense. Thanks, -- Mac

4 3