[cl-who-devel] Adding support for HTML5 doctype

Hi, I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype. Hope this patch is fine. Chaitanya -- http://chaitanyagupta.com/blog/

Thanks, that looks OK. But could you please also update the docstrings and the HTML documentation? http://weitz.de/patches.html Thanks, Edi. On Tue, Sep 14, 2010 at 5:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi,
I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype.
Hope this patch is fine.
Chaitanya
-- http://chaitanyagupta.com/blog/
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel

Edi Weitz wrote:
Thanks, that looks OK. But could you please also update the docstrings and the HTML documentation?
Sure. However, I have noticed that the released version is not the same as one that is on the bknr-svn repo. Which one should I create the patch against? Chaitanya
Thanks, Edi.
On Tue, Sep 14, 2010 at 5:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi,
I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype.
Hope this patch is fine.
Chaitanya
-- http://chaitanyagupta.com/blog/
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel

The one in the BKNR repo, as it says on the patches page. Thanks, Edi. On Tue, Sep 14, 2010 at 6:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Edi Weitz wrote:
Thanks, that looks OK. But could you please also update the docstrings and the HTML documentation?
Sure. However, I have noticed that the released version is not the same as one that is on the bknr-svn repo. Which one should I create the patch against?
Chaitanya
Thanks, Edi.
On Tue, Sep 14, 2010 at 5:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi,
I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype.
Hope this patch is fine.
Chaitanya
-- http://chaitanyagupta.com/blog/
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel

Edi Weitz wrote:
The one in the BKNR repo, as it says on the patches page.
Oops! I didn't care to look at the updated patches page. Anyways, I have attached the updated patch. I have also changed a few things from the original patch: * Using HTML5's HTML syntax[1] instead of XHTML syntax -- this is required if <!DOCTYPE html> is used * which means *EMPTY-TAG-END* is ">" and not " />" for HTML5 * Added new elements to *HTML-EMPTY-TAGS* -- from the list of void elements defined in the HTML5 spec[2] Chaitanya 1. http://dev.w3.org/html5/spec/Overview.html#syntax 2. http://dev.w3.org/html5/spec/Overview.html#void-elements
Thanks, Edi.
On Tue, Sep 14, 2010 at 6:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Edi Weitz wrote:
Thanks, that looks OK. But could you please also update the docstrings and the HTML documentation?
Sure. However, I have noticed that the released version is not the same as one that is on the bknr-svn repo. Which one should I create the patch against?
Chaitanya
Thanks, Edi.
On Tue, Sep 14, 2010 at 5:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi,
I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype.
Hope this patch is fine.
Chaitanya
-- http://chaitanyagupta.com/blog/
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel

Hi Edi, Haven't see any update on this thread. In case there's anything missing in the patch, let me know. Cheers, Chaitanya Chaitanya Gupta wrote:
Edi Weitz wrote:
The one in the BKNR repo, as it says on the patches page.
Oops! I didn't care to look at the updated patches page.
Anyways, I have attached the updated patch. I have also changed a few things from the original patch:
* Using HTML5's HTML syntax[1] instead of XHTML syntax -- this is required if <!DOCTYPE html> is used * which means *EMPTY-TAG-END* is ">" and not " />" for HTML5 * Added new elements to *HTML-EMPTY-TAGS* -- from the list of void elements defined in the HTML5 spec[2]
Chaitanya
1. http://dev.w3.org/html5/spec/Overview.html#syntax 2. http://dev.w3.org/html5/spec/Overview.html#void-elements
Thanks, Edi.
On Tue, Sep 14, 2010 at 6:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Edi Weitz wrote:
Thanks, that looks OK. But could you please also update the docstrings and the HTML documentation?
Sure. However, I have noticed that the released version is not the same as one that is on the bknr-svn repo. Which one should I create the patch against?
Chaitanya
Thanks, Edi.
On Tue, Sep 14, 2010 at 5:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi,
I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype.
Hope this patch is fine.
Chaitanya
-- http://chaitanyagupta.com/blog/
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel

No worries, I'm just busy. I'll get to it eventually. Sorry for the delay. Edi. On Tue, Sep 28, 2010 at 6:03 AM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi Edi,
Haven't see any update on this thread. In case there's anything missing in the patch, let me know.
Cheers, Chaitanya
Chaitanya Gupta wrote:
Edi Weitz wrote:
The one in the BKNR repo, as it says on the patches page.
Oops! I didn't care to look at the updated patches page.
Anyways, I have attached the updated patch. I have also changed a few things from the original patch:
* Using HTML5's HTML syntax[1] instead of XHTML syntax -- this is required if <!DOCTYPE html> is used * which means *EMPTY-TAG-END* is ">" and not " />" for HTML5 * Added new elements to *HTML-EMPTY-TAGS* -- from the list of void elements defined in the HTML5 spec[2]
Chaitanya
1. http://dev.w3.org/html5/spec/Overview.html#syntax 2. http://dev.w3.org/html5/spec/Overview.html#void-elements
Thanks, Edi.
On Tue, Sep 14, 2010 at 6:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Edi Weitz wrote:
Thanks, that looks OK. But could you please also update the docstrings and the HTML documentation?
Sure. However, I have noticed that the released version is not the same as one that is on the bknr-svn repo. Which one should I create the patch against?
Chaitanya
Thanks, Edi.
On Tue, Sep 14, 2010 at 5:45 PM, Chaitanya Gupta <mail@chaitanyagupta.com> wrote:
Hi,
I needed to emit some HTML5 from cl-who the other day. Attached is a patch which adds support for an :HTML5 mode to cl-who. Essentially, it just sends the correct doctype.
Hope this patch is fine.
Chaitanya
-- http://chaitanyagupta.com/blog/
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel
_______________________________________________ cl-who-devel site list cl-who-devel@common-lisp.net http://common-lisp.net/mailman/listinfo/cl-who-devel

I've finally committed your patch to the SVN repository. Sorry for the long delay and thanks again. Edi.

That's great! No problems. Chaitanya Edi Weitz wrote:
I've finally committed your patch to the SVN repository. Sorry for the long delay and thanks again.
Edi.
participants (2)
-
Chaitanya Gupta
-
Edi Weitz