January 2016 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][master] 2 commits: Handle search lists in pathname-match-p.
by Raymond Toy 03 Jan '16

03 Jan '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 521f8392 by Raymond Toy at 2015-12-31T15:38:08Z Handle search lists in pathname-match-p. Allow search lists in pathname-match-p. For each arg, we enumerate the possible values of the search list and try to find a match between the path and the wild path. If there's a match, return true. Tests added for some cases of pathname-match-p with search lists. Fix issue #16. - - - - - c7e71ee2 by Raymond Toy at 2016-01-03T18:11:53Z Merge branch 'rtoy-issue-16' into 'master' Handle search lists in pathname-match-p. Allow search lists in pathname-match-p. For each arg, we enumerate the possible values of the search list and try to find a match between the path and the wild path. If there's a match, return true. Tests added for some cases of pathname-match-p with search lists. Fix issue #16. See merge request !6 - - - - - 2 changed files: - src/code/pathname.lisp - + tests/pathname.lisp Changes: ===================================== src/code/pathname.lisp ===================================== --- a/src/code/pathname.lisp +++ b/src/code/pathname.lisp @@ -1227,18 +1227,21 @@ a host-structure or string." ;; Not path-designator because a file-stream can't have a ;; wild pathname. (type (or string pathname) in-wildname)) - (with-pathname (pathname in-pathname) - (with-pathname (wildname in-wildname) - (macrolet ((frob (field &optional (op 'components-match )) - `(or (null (,field wildname)) - (,op (,field pathname) (,field wildname))))) - (and (or (null (%pathname-host wildname)) - (eq (%pathname-host wildname) (%pathname-host pathname))) - (frob %pathname-device) - (frob %pathname-directory directory-components-match) - (frob %pathname-name) - (frob %pathname-type) - (frob %pathname-version)))))) + (with-pathname (in-path in-pathname) + (enumerate-search-list (pathname in-path) + (with-pathname (in-wild in-wildname) + (enumerate-search-list (wildname in-wild) + (macrolet ((frob (field &optional (op 'components-match )) + `(or (null (,field wildname)) + (,op (,field pathname) (,field wildname))))) + (when (and (or (null (%pathname-host wildname)) + (eq (%pathname-host wildname) (%pathname-host pathname))) + (frob %pathname-device) + (frob %pathname-directory directory-components-match) + (frob %pathname-name) + (frob %pathname-type) + (frob %pathname-version)) + (return-from pathname-match-p pathname)))))))) ;;; SUBSTITUTE-INTO -- Internal ===================================== tests/pathname.lisp ===================================== --- /dev/null +++ b/tests/pathname.lisp @@ -0,0 +1,43 @@ +;; Tests for pathnames + +(defpackage :pathname-tests + (:use :cl :lisp-unit)) + +(in-package "PATHNAME-TESTS") + +;; Define "foo:" search list. /tmp and /usr should exist on all unix +;; systems. +(setf (ext:search-list "foo:") + '(#p"/tmp/" #p"/usr/")) + +;; Define "bar:" search list. The second entry should match the +;; second entry of the "foo:" search list. +(setf (ext:search-list "bar:") + '(#p"/bin/" #p"/usr/")) + +(define-test pathname-match-p.search-lists + (:tag :search-list) + ;; Basic tests where the wild path is search-list + + (assert-true (pathname-match-p "/tmp/foo.lisp" "foo:*")) + (assert-true (pathname-match-p "/tmp/zot/foo.lisp" "foo:**/*")) + (assert-true (pathname-match-p "/tmp/zot/foo.lisp" "foo:**/*.lisp")) + ;; These match because the second entry of the "foo:" search list is + ;; "/usr/". + (assert-true (pathname-match-p "/usr/foo.lisp" "foo:*")) + (assert-true (pathname-match-p "/usr/bin/foo" "foo:**/*")) + (assert-true (pathname-match-p "/usr/bin/foo.lisp" "foo:**/*.lisp")) + + ;; This fails because "/bin/" doesn't match any path of the search + ;; list. + (assert-false (pathname-match-p "/bin/foo.lisp" "foo:*")) + + ;; Basic test where the pathname is a search-list and the wild path is not. + (assert-true (pathname-match-p "foo:foo.lisp" "/tmp/*")) + (assert-true (pathname-match-p "foo:foo" "/usr/*")) + (assert-true (pathname-match-p "foo:zot/foo.lisp" "/usr/**/*.lisp")) + + (assert-false (pathname-match-p "foo:foo" "/bin/*")) + + ;; Tests where both args are search-lists. + (assert-true "foo:foo.lisp" "bar:*")) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/f3b73541a4918c50abdc17da…

1 0

[Git][cmucl/cmucl][master] Add special case for (expt 0 power)
by Raymond Toy 01 Jan '16

01 Jan '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: f3b73541 by Raymond Toy at 2016-01-01T09:30:18Z Add special case for (expt 0 power) We know the result of (expt 0 power) so return it immediately without first checking if the power exceeds the limit. Also took the opportunity to add a better message to the intexp-limit-error condition to make it more explicit what is being computed and why it's failing. Tests added too. - - - - - 2 changed files: - src/code/irrat.lisp - tests/irrat.lisp Changes: ===================================== src/code/irrat.lisp ===================================== --- a/src/code/irrat.lisp +++ b/src/code/irrat.lisp @@ -252,6 +252,13 @@ (return-from intexp base)) (when (eql base -1) (return-from intexp (if (oddp power) -1 1))) + + ;; Handle 0 raised to a power. Return 0 if the power is + ;; non-negative or signal a divide-by-zero if the power is negative. + (when (zerop base) + (if (minusp power) + (error 'division-by-zero) + (return-from intexp base))) (when (> (abs power) *intexp-maximum-exponent*) ;; Allow user the option to continue with calculation, possibly ===================================== tests/irrat.lisp ===================================== --- a/tests/irrat.lisp +++ b/tests/irrat.lisp @@ -152,3 +152,23 @@ for logx = (kernel::dd-%log2 x) for log1/x = (kernel::dd-%log2 (/ x)) do (assert-true (<= (abs (+ logx log1/x)) (* 1 double-float-epsilon))))) + +(define-test expt-integer + (let ((power (1+ kernel::*intexp-maximum-exponent*))) + ;; Make sure we error out in the usual case with the power too + ;; large. + (assert-error 'kernel::intexp-limit-error + (expt 2 power)) + (assert-error 'kernel::intexp-limit-error + (expt 2 (- power))) + ;; But raising 0 or 1 to a power shouldn't signal anything, except + ;; the obvious division-by-zero. + (assert-eql 1 (expt 1 power)) + (cond ((evenp power) + (assert-eql 1 (expt -1 power)) + (assert-eql -1 (expt -1 (1+ power)))) + (t + (assert-eql -1 (expt -1 power)) + (assert-eql 1 (expt -1 (1+ power))))) + (assert-eql 0 (expt 0 power)) + (assert-error 'division-by-zero (expt 0 (- power))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/f3b73541a4918c50abdc17da4…

1 0

[Git][cmucl/cmucl][master] 2 commits: Regenerated.
by Raymond Toy 01 Jan '16

01 Jan '16

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 107f067a by Raymond Toy at 2016-01-01T08:26:31Z Regenerated. - - - - - 6162f24e by Raymond Toy at 2016-01-01T09:25:09Z Add more to docstring for set-system-external-format. - - - - - 2 changed files: - src/code/extfmts.lisp - src/i18n/locale/cmucl.pot Changes: ===================================== src/code/extfmts.lisp ===================================== --- a/src/code/extfmts.lisp +++ b/src/code/extfmts.lisp @@ -1133,9 +1133,12 @@ character and illegal outputs are replaced by a question mark.") The standard streams are sys::*stdin*, sys::*stdout*, and sys::*stderr*, which are normally the input and/or output streams for *standard-input* and *standard-output*. Also sets sys::*tty* - (normally *terminal-io* to the given external format. If the - optional argument Filenames is gvien, then the filename encoding is - set to the specified format." + (normally *terminal-io* to the given external format. The value of + *default-external-format* is not changed. + + If the optional argument Filenames is given, then the filename + encoding is set to the specified format, if it has not already been + specified previously." (unless (find-external-format terminal) (error (intl:gettext "Can't find external-format ~S.") terminal)) (setf (stream-external-format sys:*stdin*) terminal ===================================== src/i18n/locale/cmucl.pot ===================================== --- a/src/i18n/locale/cmucl.pot +++ b/src/i18n/locale/cmucl.pot @@ -4729,7 +4729,7 @@ msgstr "" #: src/code/float-trap.lisp msgid "" -"Sets floating-point modes according to the give options and the\n" +"Encode the floating-point modes according to the give options and the\n" " specified mode, Floating-Point-Modes. The resulting new mode is\n" " returned. If a keyword is not supplied, then the current value is\n" " preserved. Possible keywords:\n" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/e28e38cee467fee161d8acba…

1 0