Raymond Toy pushed to branch master at cmucl / cmucl
Commits:
b8841170 by Raymond Toy at 2018-01-27T13:04:52-08:00
Fix #49: CLM crashes
When invoking motifd, the program name is #p:'library:motifd". This
is passed directly to spawn (a C routine), which only accepts strings.
So, before calling spawn, convert the program path to a unix
namestring.
This allows the example from the bug to run without crashing.
- - - - -
87c07e5d by Raymond Toy at 2018-01-27T18:19:56-08:00
Make sure spawn is called with a string
The previous commit worked for search lists, but the program could be
a string. Take care to convert pathnames to strings so that spawn is
always called with a string.
- - - - -
99eb4311 by Raymond Toy at 2018-01-28T02:54:17+00:00
Merge branch 'rtoy-fix-49-clm-crash' into 'master'
Fix #49: CLM crashes
Closes #49
See merge request cmucl/cmucl!32
- - - - -
1 changed file:
- src/code/run-program.lisp
Changes:
=====================================
src/code/run-program.lisp
=====================================
--- a/src/code/run-program.lisp
+++ b/src/code/run-program.lisp
@@ -522,8 +522,18 @@
;; Make sure all the args are okay.
(unless (every #'simple-string-p args)
(error (intl:gettext "All args to program must be simple strings -- ~S.") args))
+
+ ;; Make sure program is a string that we can use with spawn.
+ (setf program
+ (if (pathnamep program)
+ (lisp::with-pathname (p program)
+ (or (unix::unix-namestring p)
+ (namestring p)))
+ (namestring program)))
+ (check-type program string)
+
;; Prepend the program to the argument list.
- (push (namestring program) args)
+ (push program args)
;; Clear random specials used by GET-DESCRIPTOR-FOR to communicate cleanup
;; info. Also, establish proc at this level so we can return it.
(let (*close-on-error* *close-in-parent* *handlers-installed* proc)
@@ -566,9 +576,10 @@
(cdr entry)))
env))
(let ((child-pid
- (without-gcing
- (spawn program argv envp pty-name
- stdin stdout stderr))))
+ (without-gcing
+ (spawn program
+ argv envp pty-name
+ stdin stdout stderr))))
(when (< child-pid 0)
(error (intl:gettext "Could not fork child process: ~A")
(unix:get-unix-error-msg)))
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/b464fc941ebe07fb0e11ef8d…
---
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/b464fc941ebe07fb0e11ef8d…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch rtoy-fix-49-clm-crash at cmucl / cmucl
Commits:
87c07e5d by Raymond Toy at 2018-01-27T18:19:56-08:00
Make sure spawn is called with a string
The previous commit worked for search lists, but the program could be
a string. Take care to convert pathnames to strings so that spawn is
always called with a string.
- - - - -
1 changed file:
- src/code/run-program.lisp
Changes:
=====================================
src/code/run-program.lisp
=====================================
--- a/src/code/run-program.lisp
+++ b/src/code/run-program.lisp
@@ -522,8 +522,18 @@
;; Make sure all the args are okay.
(unless (every #'simple-string-p args)
(error (intl:gettext "All args to program must be simple strings -- ~S.") args))
+
+ ;; Make sure program is a string that we can use with spawn.
+ (setf program
+ (if (pathnamep program)
+ (lisp::with-pathname (p program)
+ (or (unix::unix-namestring p)
+ (namestring p)))
+ (namestring program)))
+ (check-type program string)
+
;; Prepend the program to the argument list.
- (push (namestring program) args)
+ (push program args)
;; Clear random specials used by GET-DESCRIPTOR-FOR to communicate cleanup
;; info. Also, establish proc at this level so we can return it.
(let (*close-on-error* *close-in-parent* *handlers-installed* proc)
@@ -566,10 +576,10 @@
(cdr entry)))
env))
(let ((child-pid
- (without-gcing
- (spawn (unix::unix-namestring program)
- argv envp pty-name
- stdin stdout stderr))))
+ (without-gcing
+ (spawn program
+ argv envp pty-name
+ stdin stdout stderr))))
(when (< child-pid 0)
(error (intl:gettext "Could not fork child process: ~A")
(unix:get-unix-error-msg)))
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/87c07e5d7b5c882422bf3089d…
---
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/87c07e5d7b5c882422bf3089d…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch master at cmucl / cmucl
Commits:
c8ebc741 by Raymond Toy at 2018-01-23T19:48:49-08:00
Import "telent" clx
This is an import from https://github.com/sharplispers/clx, revision
6e39a0d, unchanged.
git describe --tags says:
0.7.4-19-g6e39a0d
Not yet tested with cmucl.
- - - - -
a5964448 by Raymond Toy at 2018-01-23T20:20:54-08:00
Fixes for cmucl
bin/build-utils.sh:
* Temporarily turn off -batch
clx/dependent.lisp:
* WITH-ARRAY-DATA is in the LISP package, not KERNEL
clx/provide.lisp:
* For cmucl, don't compile anything else after (provide :clx)
- - - - -
c54f706e by Raymond Toy at 2018-01-24T09:40:50-08:00
Put back open-x-stream.
Brought back from the master branch.
- - - - -
c802a375 by Raymond Toy at 2018-01-24T09:41:32-08:00
Disable arglist declaration for cmucl
Don't know why this doesn't work, but removing it makes the macro
compile correctly.
- - - - -
6ea45079 by Raymond Toy at 2018-01-27T09:06:25-08:00
Move these files extensions dir to match upstream clx.
[skip-ci]
- - - - -
e6f4c980 by Raymond Toy at 2018-01-27T09:08:11-08:00
Merge upstream changes.
[skip-ci]
- - - - -
286801fd by Raymond Toy at 2018-01-27T09:09:49-08:00
Merge branch 'rtoy-update-clx' into rtoy-update-clx-with-cmucl-fixes
- - - - -
560af621 by Raymond Toy at 2018-01-27T09:19:42-08:00
Update file paths for clx/extensions
Some files were moved to clx/extensions, so need to update the build
paths appropriately.
- - - - -
c1864fe6 by Raymond Toy at 2018-01-27T09:23:20-08:00
Merge upstream demo files
[skip-ci]
- - - - -
f09962e2 by Raymond Toy at 2018-01-27T09:24:57-08:00
Merge branch 'rtoy-update-clx' into rtoy-update-clx-with-cmucl-fixes
- - - - -
87bd6d9d by Raymond Toy at 2018-01-27T09:30:02-08:00
Update comments to reflect what we've done.
- - - - -
d10aa4a6 by Raymond Toy at 2018-01-27T11:42:22-08:00
Add -batch flag back, as it used to be.
- - - - -
b464fc94 by Raymond Toy at 2018-01-27T19:52:26+00:00
Merge branch 'rtoy-update-clx-with-cmucl-fixes' into 'master'
Update clx from upstream
Closes #50
See merge request cmucl/cmucl!31
- - - - -
30 changed files:
- src/clx/README-CMUCL
- src/clx/attributes.lisp
- src/clx/buffer.lisp
- src/clx/bufmac.lisp
- src/clx/build-clx.lisp
- src/clx/clx-module.lisp
- src/clx/clx.lisp
- src/clx/cmudep.lisp
- src/clx/defsystem.lisp
- src/clx/demo/bezier.lisp
- src/clx/demo/beziertest.lisp
- src/clx/demo/clclock.lisp
- src/clx/demo/clipboard.lisp
- src/clx/demo/clx-demos.lisp
- src/clx/demo/gl-test.lisp
- src/clx/demo/hello.lisp
- src/clx/demo/mandel.lisp
- src/clx/dep-allegro.lisp
- + src/clx/dep-lispworks.lisp
- src/clx/dep-openmcl.lisp
- src/clx/depdefs.lisp
- src/clx/dependent.lisp
- src/clx/display.lisp
- src/clx/excldefsys.lisp
- src/clx/excldep.lisp
- src/clx/big-requests.lisp → src/clx/extensions/big-requests.lisp
- src/clx/dpms.lisp → src/clx/extensions/dpms.lisp
- src/clx/gl.lisp → src/clx/extensions/gl.lisp
- src/clx/glx.lisp → src/clx/extensions/glx.lisp
- src/clx/screensaver.lisp → src/clx/extensions/screensaver.lisp
The diff was not included because it is too large.
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/631990102d817923c0fadcda…
---
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/compare/631990102d817923c0fadcda…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch rtoy-update-clx-with-cmucl-fixes at cmucl / cmucl
Commits:
d10aa4a6 by Raymond Toy at 2018-01-27T11:42:22-08:00
Add -batch flag back, as it used to be.
- - - - -
1 changed file:
- bin/build-utils.sh
Changes:
=====================================
bin/build-utils.sh
=====================================
--- a/bin/build-utils.sh
+++ b/bin/build-utils.sh
@@ -16,7 +16,7 @@ TARGET="`echo $1 | sed 's:/*$::'`"
shift
$TARGET/lisp/lisp \
- -noinit -nositeinit "$@" <<EOF || exit 3
+ -noinit -nositeinit -batch "$@" <<EOF || exit 3
(in-package :cl-user)
(setf lisp::*enable-package-locked-errors* nil)
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/d10aa4a6e7edcf8e6254cb889…
---
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/commit/d10aa4a6e7edcf8e6254cb889…
You're receiving this email because of your account on gitlab.common-lisp.net.