October 2022 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-139-use-lang-to-set-external-format] Some cleanups so we don't change filename encoding.
by Raymond Toy (＠rtoy) 07 Oct '22

07 Oct '22

Raymond Toy pushed to branch issue-139-use-lang-to-set-external-format at cmucl / cmucl Commits: 0c3c5d94 by Raymond Toy at 2022-10-07T15:16:25-07:00 Some cleanups so we don't change filename encoding. * Clean up docstring for `setup-encodings` * Don't change the filename-encoding in any of the cases. * Fix message to say terminal encoding instead of filename encoding since we don't change the filename encoding. * Update warning message to mention that the encodings are unchanged when given an unknown external format. - - - - - 1 changed file: - src/code/save.lisp Changes: ===================================== src/code/save.lisp ===================================== @@ -143,10 +143,11 @@ (initial-function (alien:unsigned #.vm:word-bits))) (defun setup-encodings (&optional quiet) - "Set up encodings based on the value of the LANG envvar. The - codeset from LANG will be used to set *DEFAULT-EXTERNAL-FORMAT* and - sets the terminal and file name encoding to the specified codeset. - If Quiet is non-NIL, then messages will be suppressed." + "Set up encodings based on the value of the LANG and related + envvars. The codeset from LANG will be used to set + *DEFAULT-EXTERNAL-FORMAT* and sets the terminal encoding to the + specified codeset. If Quiet is non-NIL, then messages will be + suppressed." ;; Find the envvar that will tell us what encoding to use. ;; ;; See https://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html @@ -164,14 +165,14 @@ ;; If the lang is "C" or "POSIX", ignoring anything after ;; that, we need to set the format accordingly. (setf *default-external-format* :iso8859-1) - (set-system-external-format :iso8859-1 nil)) + (set-system-external-format :iso8859-1)) ((string-equal "/" lang :end2 (min 1 length)) ;; Also, we don't handle the case where the locale starts ;; with a slash which means a pathname to a file created by - ;; the localdef utility. So use our defaults for that case + ;; the localedef utility. So use our defaults for that case ;; as well. (setf *default-external-format* :iso8859-1) - (set-system-external-format :iso8859-1 nil)) + (set-system-external-format :iso8859-1)) (t ;; Simple parsing of LANG. We assume it looks like ;; "language[_territory][.codeset]". We're only interested @@ -184,13 +185,14 @@ (format (intern codeset "KEYWORD"))) (cond ((stream::find-external-format format nil) (unless quiet - (write-string "Default external format and filename encoding: ") + (write-string "Default external format and terminal encoding: ") (princ format) (terpri)) (setf *default-external-format* format) - (set-system-external-format format format)) + (set-system-external-format format)) (t - (warn "Unknown or unsupported external format: ~S" codeset))))))))))) + (warn "Unknown or unsupported external format: ~S; encodings unchanged" + codeset))))))))))) (defun save-lisp (core-file-name &key (purify t) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/0c3c5d94976d97f4f61b1b1… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/0c3c5d94976d97f4f61b1b1… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-142-random-0-wrong-error
by Raymond Toy (＠rtoy) 06 Oct '22

06 Oct '22

Raymond Toy pushed new branch issue-142-random-0-wrong-error at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-142-random-0-wrong-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-139-use-lang-to-set-external-format] Update pot file
by Raymond Toy (＠rtoy) 03 Oct '22

03 Oct '22

Raymond Toy pushed to branch issue-139-use-lang-to-set-external-format at cmucl / cmucl Commits: 2ef57042 by Raymond Toy at 2022-10-02T17:29:25-07:00 Update pot file - - - - - 1 changed file: - src/i18n/locale/cmucl.pot Changes: ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -6714,6 +6714,14 @@ msgid "" "This is true if and only if the lisp was started with the -edit switch." msgstr "" +#: src/code/save.lisp +msgid "" +"Set up encodings based on the value of the LANG envvar. The\n" +" codeset from LANG will be used to set *DEFAULT-EXTERNAL-FORMAT* and\n" +" sets the terminal and file name encoding to the specified codeset.\n" +" If Quiet is non-NIL, then messages will be suppressed." +msgstr "" + #: src/code/save.lisp msgid "" "Saves a CMU Common Lisp core image in the file of the specified name. The\n" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2ef570428f0fb5ffb73f05a… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2ef570428f0fb5ffb73f05a… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-141-locale
by Raymond Toy (＠rtoy) 02 Oct '22

02 Oct '22

Raymond Toy pushed new branch issue-141-locale at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-141-locale You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-139-use-lang-to-set-external-format] Recognize LC_ALL and LC_MESSAGES for setting encodings
by Raymond Toy (＠rtoy) 01 Oct '22

01 Oct '22

Raymond Toy pushed to branch issue-139-use-lang-to-set-external-format at cmucl / cmucl Commits: 48c9afad by Raymond Toy at 2022-10-01T16:24:35-07:00 Recognize LC_ALL and LC_MESSAGES for setting encodings We look for LC_ALL and LC_MESSAGES (in that order) for encodings. The fallback is LANG. We also recognize C and POSIX which mean ISO8859-1 encodings. Finally, if LANG and friends starts with a "/" for a path, we ignore the setting and just use the default encodings. - - - - - 1 changed file: - src/code/save.lisp Changes: ===================================== src/code/save.lisp ===================================== @@ -147,23 +147,50 @@ codeset from LANG will be used to set *DEFAULT-EXTERNAL-FORMAT* and sets the terminal and file name encoding to the specified codeset. If Quiet is non-NIL, then messages will be suppressed." - (let ((lang (unix:unix-getenv "LANG"))) + ;; Find the envvar that will tell us what encoding to use. + ;; + ;; See https://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html + ;; + (let* ((lang (or (unix:unix-getenv "LC_ALL") + (unix:unix-getenv "LC_MESSAGES") + (unix:unix-getenv "LANG"))) + (length (length lang))) + ;; If LANG isn't set, we don't need to do anything and just use + ;; the builtin defaults. (when lang - ;; Simple parsing of LANG. - (let ((dot (position #\. lang)) - (at (or (position #\@ lang) nil))) - (when dot - (let* ((codeset (subseq lang (1+ dot) at)) - (format (intern codeset "KEYWORD"))) - (cond ((stream::find-external-format format nil) - (unless quiet - (write-string "Default external format and filename encoding: ") - (princ format) - (terpri)) - (setf *default-external-format* format) - (set-system-external-format format format)) - (t - (warn "Unknown or unsupported external format: ~S" codeset))))))))) + (cond + ((or (string-equal "C" lang :end2 (min 1 length)) + (string-equal "POSIX" lang :end2 (min 5 length))) + ;; If the lang is "C" or "POSIX", ignoring anything after + ;; that, we need to set the format accordingly. + (setf *default-external-format* :iso8859-1) + (set-system-external-format :iso8859-1 nil)) + ((string-equal "/" lang :end2 (min 1 length)) + ;; Also, we don't handle the case where the locale starts + ;; with a slash which means a pathname to a file created by + ;; the localdef utility. So use our defaults for that case + ;; as well. + (setf *default-external-format* :iso8859-1) + (set-system-external-format :iso8859-1 nil)) + (t + ;; Simple parsing of LANG. We assume it looks like + ;; "language[_territory][.codeset]". We're only interested + ;; in the codeset, if given. Some LC_ vars also have an + ;; optional @modifier after the codeset; we ignore that too. + (let ((dot (position #\. lang)) + (at (or (position #\@ lang) nil))) + (when dot + (let* ((codeset (subseq lang (1+ dot) at)) + (format (intern codeset "KEYWORD"))) + (cond ((stream::find-external-format format nil) + (unless quiet + (write-string "Default external format and filename encoding: ") + (princ format) + (terpri)) + (setf *default-external-format* format) + (set-system-external-format format format)) + (t + (warn "Unknown or unsupported external format: ~S" codeset))))))))))) (defun save-lisp (core-file-name &key (purify t) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/48c9afadb56bc3d3da9c0bb… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/48c9afadb56bc3d3da9c0bb… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0