cmucl-cvs August 2022

cmucl-cvs@common-lisp.net

1 participants
39 discussions

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Remove solaris versions of stat and friends
by Raymond Toy (＠rtoy) 04 Aug '22

04 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 750c109a by Raymond Toy at 2022-08-04T07:36:39-07:00 Remove solaris versions of stat and friends This has been replaced by unix_stat and friends. - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -1467,42 +1467,6 @@ (declare (type unix-fd fd)) (call-stat "unix_fstat" int fd))) -;;; 64-bit versions of stat and friends -#+solaris -(progn -(defun unix-stat (name) - _N"Unix-stat retrieves information about the specified - file returning them in the form of multiple values. - See the UNIX Programmer's Manual for a description - of the values returned. If the call fails, then NIL - and an error number is returned instead." - (declare (type unix-pathname name)) - (when (string= name "") - (setf name ".")) - (with-alien ((buf (struct stat64))) - (syscall ("stat64" c-string (* (struct stat64))) - (extract-stat-results buf) - (%name->file name) (addr buf)))) - -(defun unix-lstat (name) - _N"Unix-lstat is similar to unix-stat except the specified - file must be a symbolic link." - (declare (type unix-pathname name)) - (with-alien ((buf (struct stat64))) - (syscall ("lstat64" c-string (* (struct stat64))) - (extract-stat-results buf) - (%name->file name) (addr buf)))) - -(defun unix-fstat (fd) - _N"Unix-fstat is similar to unix-stat except the file is specified - by the file descriptor fd." - (declare (type unix-fd fd)) - (with-alien ((buf (struct stat64))) - (syscall ("fstat64" int (* (struct stat64))) - (extract-stat-results buf) - fd (addr buf)))) -) - (def-alien-type nil (struct rusage (ru-utime (struct timeval)) ; user time used View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/750c109add317988cdb319e… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/750c109add317988cdb319e… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Update POT file for new docstrings for stat
by Raymond Toy (＠rtoy) 04 Aug '22

04 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: a831003a by Raymond Toy at 2022-08-04T07:18:22-07:00 Update POT file for new docstrings for stat - - - - - 1 changed file: - src/i18n/locale/cmucl-unix.pot Changes: ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -486,6 +486,76 @@ msgstr "" msgid "Size of control character vector." msgstr "" +#: src/code/unix.lisp +msgid "" +"Unix-stat retrieves information about the specified\n" +" file returning them in the form of multiple values. If the call\n" +" fails, then NIL and an error number is returned. If the call\n" +" succeeds, then T is returned in addition to the following values\n" +" from the stat struct st:\n" +"\n" +" st_dev Device ID\n" +" st_ino File serial number\n" +" st_mode Mode of file\n" +" st_nlink Number of hard links to the file\n" +" st_uid User ID\n" +" st_gid Group ID\n" +" st_rdev Device ID (if file is character or block special)\n" +" st_atime Last data access time, in sec\n" +" st_mtime Last data modification time, in sec\n" +" st_ctime Last file status change time, in sec\n" +" st_blksize Preferred I/O block size\n" +" st_blocks Number of blocks allocated. (Block size is implementation" +" dependent.)\n" +"" +msgstr "" + +#: src/code/unix.lisp +msgid "" +"Unix-fstat is similar to unix-stat except the file is specified\n" +" by the file descriptor fd. If the call fails, then NIL and an\n" +" error number is returned. If the call succeeds, then T is returned\n" +" in addition to the following values from the stat struct st:\n" +"\n" +" st_dev Device ID\n" +" st_ino File serial number\n" +" st_mode Mode of file\n" +" st_nlink Number of hard links to the file\n" +" st_uid User ID\n" +" st_gid Group ID\n" +" st_rdev Device ID (if file is character or block special)\n" +" st_atime Last data access time, in sec\n" +" st_mtime Last data modification time, in sec\n" +" st_ctime Last file status change time, in sec\n" +" st_blksize Preferred I/O block size\n" +" st_blocks Number of blocks allocated. (Block size is implementation" +" dependent.)\n" +"" +msgstr "" + +#: src/code/unix.lisp +msgid "" +"Unix-lstat is similar to unix-stat except the specified\n" +" file must be a symbolic link. If the call fails, then NIL and an\n" +" error number is returned. If the call succeeds, then T is returned\n" +" in addition to the following values from the stat struct st:\n" +"\n" +" st_dev Device ID\n" +" st_ino File serial number\n" +" st_mode Mode of file\n" +" st_nlink Number of hard links to the file\n" +" st_uid User ID\n" +" st_gid Group ID\n" +" st_rdev Device ID (if file is character or block special)\n" +" st_atime Last data access time, in sec\n" +" st_mtime Last data modification time, in sec\n" +" st_ctime Last file status change time, in sec\n" +" st_blksize Preferred I/O block size\n" +" st_blocks Number of blocks allocated. (Block size is implementation" +" dependent.)\n" +"" +msgstr "" + #: src/code/unix.lisp msgid "" "Unix-stat retrieves information about the specified\n" @@ -497,14 +567,14 @@ msgstr "" #: src/code/unix.lisp msgid "" -"Unix-fstat is similar to unix-stat except the file is specified\n" -" by the file descriptor fd." +"Unix-lstat is similar to unix-stat except the specified\n" +" file must be a symbolic link." msgstr "" #: src/code/unix.lisp msgid "" -"Unix-lstat is similar to unix-stat except the specified\n" -" file must be a symbolic link." +"Unix-fstat is similar to unix-stat except the file is specified\n" +" by the file descriptor fd." msgstr "" #: src/code/unix.lisp View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a831003a17f8c31c2e96d41… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a831003a17f8c31c2e96d41… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Remove unused alien types and update docstrings
by Raymond Toy (＠rtoy) 04 Aug '22

04 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: c36ad0c7 by Raymond Toy at 2022-08-03T19:53:21-07:00 Remove unused alien types and update docstrings The alien types dev-t and nlink-t aren't used anywhere anymore so remove them. Update the docstrings for unix-stat and friends to describe what the multiple return values are. - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -69,14 +69,6 @@ #+(and bsd netbsd) int64-t #+alpha unsigned-int) -#+nil -(def-alien-type dev-t - #-(or alpha svr4 bsd linux) short - #+linux u-int64-t - #+netbsd u-int64-t - #+alpha int - #+(and (not linux) (not netbsd) (or bsd svr4)) unsigned-long) - #-BSD (progn (deftype file-offset () '(signed-byte 32)) @@ -128,13 +120,6 @@ `(multiple-value-bind (,word ,bit) (floor ,offset 32) (logbitp ,bit (deref (slot ,fd-set 'fds-bits) ,word))))) -(def-alien-type nlink-t - #-(or svr4 netbsd linux) unsigned-short - #+netbsd unsigned-long - #+svr4 unsigned-long - #+(and linux (not amd64)) unsigned-int - #+(and linux amd64) u-int64-t) - (defconstant fd-setsize #-(or hpux alpha linux FreeBSD) 256 #+hpux 2048 #+alpha 4096 #+(or linux FreeBSD) 1024) @@ -1415,10 +1400,24 @@ blocks)))))) (defun unix-stat (name) _N"Unix-stat retrieves information about the specified - file returning them in the form of multiple values. - See the UNIX Programmer's Manual for a description - of the values returned. If the call fails, then NIL - and an error number is returned instead." + file returning them in the form of multiple values. If the call + fails, then NIL and an error number is returned. If the call + succeeds, then T is returned in addition to the following values + from the stat struct st: + + st_dev Device ID + st_ino File serial number + st_mode Mode of file + st_nlink Number of hard links to the file + st_uid User ID + st_gid Group ID + st_rdev Device ID (if file is character or block special) + st_atime Last data access time, in sec + st_mtime Last data modification time, in sec + st_ctime Last file status change time, in sec + st_blksize Preferred I/O block size + st_blocks Number of blocks allocated. (Block size is implementation dependent.) +" (declare (type unix-pathname name)) (when (string= name "") (setf name ".")) @@ -1426,13 +1425,45 @@ (defun unix-lstat (name) "Unix-lstat is similar to unix-stat except the specified - file must be a symbolic link." + file must be a symbolic link. If the call fails, then NIL and an + error number is returned. If the call succeeds, then T is returned + in addition to the following values from the stat struct st: + + st_dev Device ID + st_ino File serial number + st_mode Mode of file + st_nlink Number of hard links to the file + st_uid User ID + st_gid Group ID + st_rdev Device ID (if file is character or block special) + st_atime Last data access time, in sec + st_mtime Last data modification time, in sec + st_ctime Last file status change time, in sec + st_blksize Preferred I/O block size + st_blocks Number of blocks allocated. (Block size is implementation dependent.) +" (declare (type unix-pathname name)) (call-stat "unix_lstat" c-call:c-string (%name->file name))) (defun unix-fstat (fd) _N"Unix-fstat is similar to unix-stat except the file is specified - by the file descriptor fd." + by the file descriptor fd. If the call fails, then NIL and an + error number is returned. If the call succeeds, then T is returned + in addition to the following values from the stat struct st: + + st_dev Device ID + st_ino File serial number + st_mode Mode of file + st_nlink Number of hard links to the file + st_uid User ID + st_gid Group ID + st_rdev Device ID (if file is character or block special) + st_atime Last data access time, in sec + st_mtime Last data modification time, in sec + st_ctime Last file status change time, in sec + st_blksize Preferred I/O block size + st_blocks Number of blocks allocated. (Block size is implementation dependent.) +" (declare (type unix-fd fd)) (call-stat "unix_fstat" int fd))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c36ad0c736ca2f037eddb83… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c36ad0c736ca2f037eddb83… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Don't use dev_t and friends in stat interface definition.
by Raymond Toy (＠rtoy) 04 Aug '22

04 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: b726c5a4 by Raymond Toy at 2022-08-03T19:01:31-07:00 Don't use dev_t and friends in stat interface definition. To simplify things, don't use dev_t and friends in the C interface. Instead, use the largest integer type that any OS would want to use. So dev_t becomes u_int64_t because Linux can return 64-bit integers here. This would work just fine for macos which uses 32-bit integers. We are depending on the compiler to produce a warning or error if we try to store a larger integer type into a smaller type. - - - - - 2 changed files: - src/code/unix.lisp - src/lisp/os-common.c Changes: ===================================== src/code/unix.lisp ===================================== @@ -69,6 +69,7 @@ #+(and bsd netbsd) int64-t #+alpha unsigned-int) +#+nil (def-alien-type dev-t #-(or alpha svr4 bsd linux) short #+linux u-int64-t @@ -1351,37 +1352,37 @@ ;; to the stat function. fstat is different from stat and ;; lstat since it takes an fd for the first arg instead of ;; string. - `(with-alien ((dev dev-t) - (ino ino-t) - (mode mode-t) - (nlink nlink-t) - (uid uid-t) - (gid gid-t) - (rdev dev-t) - (size off-t) - (atime time-t) - (mtime time-t) - (ctime time-t) + `(with-alien ((dev u-int64-t) + (ino u-int64-t) + (mode c-call:unsigned-int) + (nlink u-int64-t) + (uid c-call:unsigned-int) + (gid c-call:unsigned-int) + (rdev u-int64-t) + (size int64-t) + (atime int64-t) + (mtime int64-t) + (ctime int64-t) (blksize c-call:long) - (blocks off-t)) + (blocks int64-t)) (let ((result (alien-funcall (extern-alien ,c-func-name (function int ,first-arg-type - (* dev-t) - (* ino-t) - (* mode-t) - (* nlink-t) - (* uid-t) - (* gid-t) - (* dev-t) - (* off-t) - (* time-t) - (* time-t) - (* time-t) + (* u-int64-t) + (* u-int64-t) + (* c-call:unsigned-int) + (* u-int64-t) + (* c-call:unsigned-int) + (* c-call:unsigned-int) + (* u-int64-t) + (* int64-t) + (* int64-t) + (* int64-t) + (* int64-t) (* c-call:long) - (* off-t))) + (* int64-t))) ,first-arg (addr dev) (addr ino) ===================================== src/lisp/os-common.c ===================================== @@ -597,11 +597,19 @@ os_sleep(double seconds) } } +/* + * Interface to stat/fstat/lstat. + * + * The arg types are chosen such that they can hold the largest + * possible value that any OS would use for the particular slot in the + * stat structure. That way we can just use one OS-independent + * function that works across all OSes. + */ int -unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) +unix_stat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, + unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, + int64_t *atime, int64_t *mtime, int64_t *ctime, + long *blksize, int64_t *blocks) { int rc; struct stat buf; @@ -647,10 +655,10 @@ unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink } int -unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) +unix_fstat(int fd, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, + unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, + int64_t *atime, int64_t *mtime, int64_t *ctime, + long *blksize, int64_t *blocks) { int rc; struct stat buf; @@ -675,10 +683,10 @@ unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, } int -unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) +unix_lstat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, + unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, + int64_t *atime, int64_t *mtime, int64_t *ctime, + long *blksize, int64_t *blocks) { int rc; struct stat buf; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/b726c5a416dd05fc6fbd848… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/b726c5a416dd05fc6fbd848… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Some more cleanup
by Raymond Toy (＠rtoy) 03 Aug '22

03 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: d8cc93fe by Raymond Toy at 2022-08-03T13:38:31-07:00 Some more cleanup Disable the prints but leave them. - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -5,10 +5,12 @@ */ +#ifdef __linux__ +/* Needed to get 64-bit objects for stat and friends on Linux. */ #define _LARGEFILE_SOURCE #define _FILE_OFFSET_BITS 64 +#endif -#include <stdio.h> #include <errno.h> #include <math.h> #include <netdb.h> @@ -595,16 +597,23 @@ os_sleep(double seconds) } } -int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) +int +unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, + uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) { int rc; struct stat buf; rc = stat(path, &buf); +#if 0 + /* + * Useful prints to see the actual size of the various + * fields. Helpful for porting this to other OSes that we haven't + * tested on. + */ fprintf(stderr, "size dev %d\n", sizeof(buf.st_dev)); fprintf(stderr, "size ino %d\n", sizeof(buf.st_ino)); fprintf(stderr, "size mode %d\n", sizeof(buf.st_mode)); @@ -618,6 +627,7 @@ int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *n fprintf(stderr, "size ctime %d\n", sizeof(buf.st_ctime)); fprintf(stderr, "size blksize %d\n", sizeof(buf.st_blksize)); fprintf(stderr, "size blocks %d\n", sizeof(buf.st_blocks)); +#endif *dev = buf.st_dev; *ino = buf.st_ino; @@ -636,10 +646,11 @@ int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *n return rc; } -int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) +int +unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, + uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) { int rc; struct stat buf; @@ -663,10 +674,11 @@ int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, return rc; } -int unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) +int +unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, + uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) { int rc; struct stat buf; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d8cc93fe688ee5913e95434… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d8cc93fe688ee5913e95434… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Replace ino64-t with ino-t on linux.
by Raymond Toy (＠rtoy) 03 Aug '22

03 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 34a975ee by Raymond Toy at 2022-08-03T13:02:19-07:00 Replace ino64-t with ino-t on linux. Basically makes ino-t be a 64-bit int and removes the ino64-t type for linux. Requires updating stat calls to use ino-t instead of ino64-t, of course. - - - - - 1 changed file: - src/code/unix.lisp Changes: ===================================== src/code/unix.lisp ===================================== @@ -53,12 +53,9 @@ (def-alien-type u-int32-t unsigned-int) (def-alien-type ino-t - #+netbsd u-int64-t + #+(or netbsd linux darwin) u-int64-t #+alpha unsigned-int - #-(or alpha netbsd) unsigned-long) - -#+linux -(def-alien-type ino64-t u-int64-t) + #-(or alpha netbsd linux darwin) unsigned-long) (def-alien-type size-t #-(or linux alpha) long @@ -1300,7 +1297,7 @@ #+glibc2.1 (d-ino ino-t) ; inode number of entry #-glibc2.1 - (d-ino ino64-t) ; inode number of entry + (d-ino ino-t) ; inode number of entry (d-off off-t) ; offset of next disk directory entry (d-reclen unsigned-short) ; length of this record (d_type unsigned-char) @@ -1346,15 +1343,16 @@ (d-name (array char 256)))) ; name must be no longer than this +;; unix-stat and friends (macrolet ((call-stat (c-func-name first-arg-type first-arg) ;; Call the stat function named C-FUNC-NAME. The type of the - ;; first arg is FIRST-ARG_TYPE and FIRST-ARG is the first arg + ;; first arg is FIRST-ARG-TYPE and FIRST-ARG is the first arg ;; to the stat function. fstat is different from stat and ;; lstat since it takes an fd for the first arg instead of ;; string. `(with-alien ((dev dev-t) - (ino ino64-t) + (ino ino-t) (mode mode-t) (nlink nlink-t) (uid uid-t) @@ -1372,7 +1370,7 @@ (function int ,first-arg-type (* dev-t) - (* ino64-t) + (* ino-t) (* mode-t) (* nlink-t) (* uid-t) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/34a975ee5749c15840971bc… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/34a975ee5749c15840971bc… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Clean up impl more
by Raymond Toy (＠rtoy) 03 Aug '22

03 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 50da071d by Raymond Toy at 2022-08-03T12:38:09-07:00 Clean up impl more * Move the stat functions from unix.c to os-common.c and remove unix.c. * Update Linux config files appropriately. * Use the same unix_stat function everywhere, so we can remove all of the different OS-specific definitions of struct stat that we no longer need. - - - - - 6 changed files: - src/code/unix.lisp - src/i18n/locale/cmucl-unix.pot - src/lisp/Config.x86_linux - src/lisp/Config.x86_linux_clang - src/lisp/os-common.c - − src/lisp/unix.c Changes: ===================================== src/code/unix.lisp ===================================== @@ -1346,232 +1346,6 @@ (d-name (array char 256)))) ; name must be no longer than this -#+(and bsd (not netbsd)) -(def-alien-type nil - (struct stat - (st-dev dev-t) - (st-ino ino-t) - (st-mode mode-t) - (st-nlink nlink-t) - (st-uid uid-t) - (st-gid gid-t) - (st-rdev dev-t) - (st-atime (struct timespec-t)) - (st-mtime (struct timespec-t)) - (st-ctime (struct timespec-t)) - (st-size off-t) - (st-blocks off-t) - (st-blksize unsigned-long) - (st-flags unsigned-long) - (st-gen unsigned-long) - (st-lspare long) - (st-qspare (array long 4)))) - -#+svr4 -(def-alien-type nil - (struct stat - (st-dev dev-t) - (st-pad1 #-linux (array long 3) #+linux unsigned-short) - (st-ino ino-t) - (st-mode #-linux unsigned-long #+linux unsigned-short) - (st-nlink #-linux short #+linux unsigned-short) - (st-uid #-linux uid-t #+linux unsigned-short) - (st-gid #-linux gid-t #+linux unsigned-short) - (st-rdev dev-t) - (st-pad2 #-linux (array long 2) #+linux unsigned-short) - (st-size off-t) - #-linux (st-pad3 long) - #+linux (st-blksize unsigned-long) - #+linux (st-blocks unsigned-long) - #-linux (st-atime (struct timestruc-t)) - #+linux (st-atime unsigned-long) - #+linux (unused-1 unsigned-long) - #-linux (st-mtime (struct timestruc-t)) - #+linux (st-mtime unsigned-long) - #+linux (unused-2 unsigned-long) - #-linux (st-ctime (struct timestruc-t)) - #+linux (st-ctime unsigned-long) - #+linux (unused-3 unsigned-long) - #+linux (unused-4 unsigned-long) - #+linux (unused-5 unsigned-long) - #-linux(st-blksize long) - #-linux (st-blocks long) - #-linux (st-fstype (array char 16)) - #-linux (st-pad4 (array long 8)))) - -#+(and nil linux) -(def-alien-type nil - (struct stat - (st-dev dev-t) - #-(or alpha amd64) (st-pad1 unsigned-short) - (st-ino ino64-t) - #+alpha (st-pad1 unsigned-int) - #-amd64 (st-mode mode-t) - (st-nlink nlink-t) - #+amd64 (st-mode mode-t) - (st-uid uid-t) - (st-gid gid-t) - (st-rdev dev-t) - #-alpha (st-pad2 unsigned-short) - (st-size off-t) - #-alpha (st-blksize unsigned-long) - #-alpha (st-blocks blkcnt-t) - (st-atime time-t) - #-alpha (unused-1 unsigned-long) - (st-mtime time-t) - #-alpha (unused-2 unsigned-long) - (st-ctime time-t) - #+alpha (st-blocks int) - #+alpha (st-pad2 unsigned-int) - #+alpha (st-blksize unsigned-int) - #+alpha (st-flags unsigned-int) - #+alpha (st-gen unsigned-int) - #+alpha (st-pad3 unsigned-int) - #+alpha (unused-1 unsigned-long) - #+alpha (unused-2 unsigned-long) - (unused-3 unsigned-long) - (unused-4 unsigned-long) - #-alpha (unused-5 unsigned-long))) - -;;; 64-bit stat for Solaris -#+solaris -(def-alien-type nil - (struct stat64 - (st-dev dev-t) - (st-pad1 (array long 3)) ; Pad so ino is 64-bit aligned - (st-ino ino64-t) - (st-mode unsigned-long) - (st-nlink short) - (st-uid uid-t) - (st-gid gid-t) - (st-rdev dev-t) - (st-pad2 (array long 3)) ; Pad so size is 64-bit aligned - (st-size off64-t) - (st-atime (struct timestruc-t)) - (st-mtime (struct timestruc-t)) - (st-ctime (struct timestruc-t)) - (st-blksize long) - (st-pad3 (array long 1)) ; Pad so blocks is 64-bit aligned - (st-blocks blkcnt64-t) - (st-fstype (array char 16)) - (st-pad4 (array long 8)))) - -#+netbsd -(def-alien-type nil - (struct stat - (st-dev dev-t) - (st-mode mode-t) - (st-ino ino-t) - (st-nlink nlink-t) - (st-uid uid-t) - (st-gid gid-t) - (st-rdev dev-t) - (st-atime (struct timespec-t)) - (st-mtime (struct timespec-t)) - (st-ctime (struct timespec-t)) - (st-birthtime (struct timespec-t)) - (st-size off-t) - (st-blocks off-t) - (st-blksize long) - (st-flags unsigned-long) - (st-gen unsigned-long) - (st-spare (array unsigned-long 2)))) - -#-linux -(defmacro extract-stat-results (buf) - `(values T - (slot ,buf 'st-dev) - (slot ,buf 'st-ino) - (slot ,buf 'st-mode) - (slot ,buf 'st-nlink) - (slot ,buf 'st-uid) - (slot ,buf 'st-gid) - (slot ,buf 'st-rdev) - (slot ,buf 'st-size) - #-(or svr4 BSD) (slot ,buf 'st-atime) - #+svr4 (slot (slot ,buf 'st-atime) 'tv-sec) - #+BSD (slot (slot ,buf 'st-atime) 'ts-sec) - #-(or svr4 BSD)(slot ,buf 'st-mtime) - #+svr4 (slot (slot ,buf 'st-mtime) 'tv-sec) - #+BSD(slot (slot ,buf 'st-mtime) 'ts-sec) - #-(or svr4 BSD) (slot ,buf 'st-ctime) - #+svr4 (slot (slot ,buf 'st-ctime) 'tv-sec) - #+BSD(slot (slot ,buf 'st-ctime) 'ts-sec) - #+netbsd (slot (slot ,buf 'st-birthtime) 'ts-sec) - (slot ,buf 'st-blksize) - (slot ,buf 'st-blocks))) - -#+linux -(defmacro extract-stat-results (buf) - `(values T - #+(or alpha amd64) - (slot ,buf 'st-dev) - #-(or alpha amd64) - (+ (deref (slot ,buf 'st-dev) 0) - (* (+ +max-u-long+ 1) - (deref (slot ,buf 'st-dev) 1))) ;;; let's hope this works.. - (slot ,buf 'st-ino) - (slot ,buf 'st-mode) - (slot ,buf 'st-nlink) - (slot ,buf 'st-uid) - (slot ,buf 'st-gid) - #+(or alpha amd64) - (slot ,buf 'st-rdev) - #-(or alpha amd64) - (+ (deref (slot ,buf 'st-rdev) 0) - (* (+ +max-u-long+ 1) - (deref (slot ,buf 'st-rdev) 1))) ;;; let's hope this works.. - (slot ,buf 'st-size) - (slot ,buf 'st-atime) - (slot ,buf 'st-mtime) - (slot ,buf 'st-ctime) - (slot ,buf 'st-blksize) - (slot ,buf 'st-blocks))) - -#-(or linux solaris) -(progn -(defun unix-stat (name) - _N"Unix-stat retrieves information about the specified - file returning them in the form of multiple values. - See the UNIX Programmer's Manual for a description - of the values returned. If the call fails, then NIL - and an error number is returned instead." - (declare (type unix-pathname name)) - (when (string= name "") - (setf name ".")) - (with-alien ((buf (struct stat))) - (syscall (#+linux "stat64" #+netbsd "__stat50" #-(or linux netbsd) "stat" - c-string (* (struct stat))) - (extract-stat-results buf) - (%name->file name) (addr buf)))) - -(defun unix-lstat (name) - _N"Unix-lstat is similar to unix-stat except the specified - file must be a symbolic link." - (declare (type unix-pathname name)) - (with-alien ((buf (struct stat))) - (syscall (#+linux "lstat64" #+netbsd "__lstat50" #-(or linux netbsd) "lstat" - c-string (* (struct stat))) - (extract-stat-results buf) - (%name->file name) (addr buf)))) - -(defun unix-fstat (fd) - _N"Unix-fstat is similar to unix-stat except the file is specified - by the file descriptor fd." - (declare (type unix-fd fd)) - (with-alien ((buf (struct stat))) - (syscall (#+linux "fstat64" #+netbsd "__fstat50" #-(or linux netbsd) "fstat" - int (* (struct stat))) - (extract-stat-results buf) - fd (addr buf)))) -) - -;; On linux we call out to our own C routine to return the appropriate -;; parts so that we don't have to mess around with making sure the -;; struct stat is consistent with the library. -;; -;; This should be updated so that all OSes do this. -#+linux (macrolet ((call-stat (c-func-name first-arg-type first-arg) ;; Call the stat function named C-FUNC-NAME. The type of the ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -497,14 +497,14 @@ msgstr "" #: src/code/unix.lisp msgid "" -"Unix-lstat is similar to unix-stat except the specified\n" -" file must be a symbolic link." +"Unix-fstat is similar to unix-stat except the file is specified\n" +" by the file descriptor fd." msgstr "" #: src/code/unix.lisp msgid "" -"Unix-fstat is similar to unix-stat except the file is specified\n" -" by the file descriptor fd." +"Unix-lstat is similar to unix-stat except the specified\n" +" file must be a symbolic link." msgstr "" #: src/code/unix.lisp ===================================== src/lisp/Config.x86_linux ===================================== @@ -7,7 +7,7 @@ CFLAGS += -rdynamic -march=pentium4 -mfpmath=sse -mtune=generic UNDEFSYMPATTERN = -Xlinker -u -Xlinker & ASSEM_SRC += linux-stubs.S -OS_SRC += Linux-os.c elf.c unix.c +OS_SRC += Linux-os.c elf.c OS_LIBS = -ldl OS_LINK_FLAGS = -m32 -rdynamic -Xlinker --export-dynamic -Xlinker -Map -Xlinker foo OS_LINK_FLAGS += -Wl,-z,noexecstack ===================================== src/lisp/Config.x86_linux_clang ===================================== @@ -12,7 +12,7 @@ CFLAGS += -msse2 -mtune=pentium4 -ftrapping-math UNDEFSYMPATTERN = -Xlinker -u -Xlinker & ASSEM_SRC += linux-stubs.S -OS_SRC += Linux-os.c elf.c unix.c +OS_SRC += Linux-os.c elf.c OS_LIBS = -ldl OS_LINK_FLAGS = -m32 -rdynamic -Xlinker --export-dynamic -Xlinker -Map -Xlinker foo OS_LINK_FLAGS += -Wl,-z,noexecstack ===================================== src/lisp/os-common.c ===================================== @@ -5,12 +5,17 @@ */ +#define _LARGEFILE_SOURCE +#define _FILE_OFFSET_BITS 64 + +#include <stdio.h> #include <errno.h> #include <math.h> #include <netdb.h> #include <stdio.h> #include <string.h> #include <time.h> +#include <sys/stat.h> #include "os.h" #include "internals.h" @@ -589,3 +594,98 @@ os_sleep(double seconds) requested = remaining; } } + +int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, + uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) +{ + int rc; + struct stat buf; + + rc = stat(path, &buf); + + fprintf(stderr, "size dev %d\n", sizeof(buf.st_dev)); + fprintf(stderr, "size ino %d\n", sizeof(buf.st_ino)); + fprintf(stderr, "size mode %d\n", sizeof(buf.st_mode)); + fprintf(stderr, "size nlink %d\n", sizeof(buf.st_nlink)); + fprintf(stderr, "size uid %d\n", sizeof(buf.st_uid)); + fprintf(stderr, "size gid %d\n", sizeof(buf.st_gid)); + fprintf(stderr, "size rdev %d\n", sizeof(buf.st_rdev)); + fprintf(stderr, "size size %d\n", sizeof(buf.st_size)); + fprintf(stderr, "size atime %d\n", sizeof(buf.st_atime)); + fprintf(stderr, "size mtime %d\n", sizeof(buf.st_mtime)); + fprintf(stderr, "size ctime %d\n", sizeof(buf.st_ctime)); + fprintf(stderr, "size blksize %d\n", sizeof(buf.st_blksize)); + fprintf(stderr, "size blocks %d\n", sizeof(buf.st_blocks)); + + *dev = buf.st_dev; + *ino = buf.st_ino; + *mode = buf.st_mode; + *nlink = buf.st_nlink; + *uid = buf.st_uid; + *gid = buf.st_gid; + *rdev = buf.st_rdev; + *size = buf.st_size; + *atime = buf.st_atime; + *mtime = buf.st_mtime; + *ctime = buf.st_ctime; + *blksize = buf.st_blksize; + *blocks = buf.st_blocks; + + return rc; +} + +int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, + uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) +{ + int rc; + struct stat buf; + + rc = fstat(fd, &buf); + + *dev = buf.st_dev; + *ino = buf.st_ino; + *mode = buf.st_mode; + *nlink = buf.st_nlink; + *uid = buf.st_uid; + *gid = buf.st_gid; + *rdev = buf.st_rdev; + *size = buf.st_size; + *atime = buf.st_atime; + *mtime = buf.st_mtime; + *ctime = buf.st_ctime; + *blksize = buf.st_blksize; + *blocks = buf.st_blocks; + + return rc; +} + +int unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, + uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) +{ + int rc; + struct stat buf; + + rc = lstat(path, &buf); + + *dev = buf.st_dev; + *ino = buf.st_ino; + *mode = buf.st_mode; + *nlink = buf.st_nlink; + *uid = buf.st_uid; + *gid = buf.st_gid; + *rdev = buf.st_rdev; + *size = buf.st_size; + *atime = buf.st_atime; + *mtime = buf.st_mtime; + *ctime = buf.st_ctime; + *blksize = buf.st_blksize; + *blocks = buf.st_blocks; + + return rc; +} ===================================== src/lisp/unix.c deleted ===================================== @@ -1,110 +0,0 @@ -/* - * C interfaces to unix syscalls - */ - -/* We want to support large files */ - -#define _LARGEFILE_SOURCE -#define _FILE_OFFSET_BITS 64 - -#include <stdio.h> -#include <sys/stat.h> - -int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) -{ - int rc; - struct stat buf; - - rc = stat(path, &buf); - - fprintf(stderr, "size dev %d\n", sizeof(buf.st_dev)); - fprintf(stderr, "size ino %d\n", sizeof(buf.st_ino)); - fprintf(stderr, "size mode %d\n", sizeof(buf.st_mode)); - fprintf(stderr, "size nlink %d\n", sizeof(buf.st_nlink)); - fprintf(stderr, "size uid %d\n", sizeof(buf.st_uid)); - fprintf(stderr, "size gid %d\n", sizeof(buf.st_gid)); - fprintf(stderr, "size rdev %d\n", sizeof(buf.st_rdev)); - fprintf(stderr, "size size %d\n", sizeof(buf.st_size)); - fprintf(stderr, "size atime %d\n", sizeof(buf.st_atime)); - fprintf(stderr, "size mtime %d\n", sizeof(buf.st_mtime)); - fprintf(stderr, "size ctime %d\n", sizeof(buf.st_ctime)); - fprintf(stderr, "size blksize %d\n", sizeof(buf.st_blksize)); - fprintf(stderr, "size blocks %d\n", sizeof(buf.st_blocks)); - - - *dev = buf.st_dev; - *ino = buf.st_ino; - *mode = buf.st_mode; - *nlink = buf.st_nlink; - *uid = buf.st_uid; - *gid = buf.st_gid; - *rdev = buf.st_rdev; - *size = buf.st_size; - *atime = buf.st_atime; - *mtime = buf.st_mtime; - *ctime = buf.st_ctime; - *blksize = buf.st_blksize; - *blocks = buf.st_blocks; - - return rc; -} - -int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) -{ - int rc; - struct stat buf; - - rc = fstat(fd, &buf); - - *dev = buf.st_dev; - *ino = buf.st_ino; - *mode = buf.st_mode; - *nlink = buf.st_nlink; - *uid = buf.st_uid; - *gid = buf.st_gid; - *rdev = buf.st_rdev; - *size = buf.st_size; - *atime = buf.st_atime; - *mtime = buf.st_mtime; - *ctime = buf.st_ctime; - *blksize = buf.st_blksize; - *blocks = buf.st_blocks; - - return rc; -} - -int unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, - uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - time_t *atime, time_t *mtime, time_t *ctime, - long *blksize, off_t *blocks) -{ - int rc; - struct stat buf; - - rc = lstat(path, &buf); - - *dev = buf.st_dev; - *ino = buf.st_ino; - *mode = buf.st_mode; - *nlink = buf.st_nlink; - *uid = buf.st_uid; - *gid = buf.st_gid; - *rdev = buf.st_rdev; - *size = buf.st_size; - *atime = buf.st_atime; - *mtime = buf.st_mtime; - *ctime = buf.st_ctime; - *blksize = buf.st_blksize; - *blocks = buf.st_blocks; - - return rc; -} - - - View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/50da071db677ed03e805422… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/50da071db677ed03e805422… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] 3 commits: 64-bit support and clean up times
by Raymond Toy (＠rtoy) 03 Aug '22

03 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 55140c71 by Raymond Toy at 2022-08-03T09:52:06-07:00 64-bit support and clean up times In unix.c define _LARGEFILE_SOURCE and _FILE_OFFSET_BITS so that we can the 64-bit versions of stat and friends. Also, for compatibility, we don't return a struct timespec, but a long for the number of seconds. We ignore the nanosec part. In unix.lisp, change the definition of dev-t on linux to be u-int64-t since it seems we support the 64-bit integer type. - - - - - 97f6a14c by Raymond Toy at 2022-08-03T10:00:45-07:00 Use time_t/time-t instead of long For the time fields, use time_t on the C side and time-t on the Lisp side. - - - - - 8dd3f6ae by Raymond Toy at 2022-08-03T11:26:29-07:00 Simplify implementation of unix-stat and friends Since the body of unix-stat and friends are almost identical and only differ in the arg and type of the first arg to stat, we use a macro to handle the call to stat. - - - - - 2 changed files: - src/code/unix.lisp - src/lisp/unix.c Changes: ===================================== src/code/unix.lisp ===================================== @@ -74,8 +74,7 @@ (def-alien-type dev-t #-(or alpha svr4 bsd linux) short - #+(and linux (not amd64)) uquad-t - #+(and linux amd64) u-int64-t + #+linux u-int64-t #+netbsd u-int64-t #+alpha int #+(and (not linux) (not netbsd) (or bsd svr4)) unsigned-long) @@ -1573,207 +1572,96 @@ ;; ;; This should be updated so that all OSes do this. #+linux -(progn -(defun unix-stat (name) - _N"Unix-stat retrieves information about the specified +(macrolet + ((call-stat (c-func-name first-arg-type first-arg) + ;; Call the stat function named C-FUNC-NAME. The type of the + ;; first arg is FIRST-ARG_TYPE and FIRST-ARG is the first arg + ;; to the stat function. fstat is different from stat and + ;; lstat since it takes an fd for the first arg instead of + ;; string. + `(with-alien ((dev dev-t) + (ino ino64-t) + (mode mode-t) + (nlink nlink-t) + (uid uid-t) + (gid gid-t) + (rdev dev-t) + (size off-t) + (atime time-t) + (mtime time-t) + (ctime time-t) + (blksize c-call:long) + (blocks off-t)) + (let ((result + (alien-funcall + (extern-alien ,c-func-name + (function int + ,first-arg-type + (* dev-t) + (* ino64-t) + (* mode-t) + (* nlink-t) + (* uid-t) + (* gid-t) + (* dev-t) + (* off-t) + (* time-t) + (* time-t) + (* time-t) + (* c-call:long) + (* off-t))) + ,first-arg + (addr dev) + (addr ino) + (addr mode) + (addr nlink) + (addr uid) + (addr gid) + (addr rdev) + (addr size) + (addr atime) + (addr mtime) + (addr ctime) + (addr blksize) + (addr blocks)))) + (if (eql -1 result) + (values nil (unix-errno)) + (values t + dev + ino + mode + nlink + uid + gid + rdev + size + atime + mtime + ctime + blksize + blocks)))))) + (defun unix-stat (name) + _N"Unix-stat retrieves information about the specified file returning them in the form of multiple values. See the UNIX Programmer's Manual for a description of the values returned. If the call fails, then NIL and an error number is returned instead." - (declare (type unix-pathname name)) - (when (string= name "") - (setf name ".")) - (with-alien ((dev dev-t) - (ino ino64-t) - (mode mode-t) - (nlink nlink-t) - (uid uid-t) - (gid gid-t) - (rdev dev-t) - (size off-t) - (atime (struct timespec-t)) - (mtime (struct timespec-t)) - (ctime (struct timespec-t)) - (blksize off-t) - (blocks off-t)) - (let ((result - (alien-funcall - (extern-alien "unix_stat" - (function int - c-call::c-string - (* dev-t) - (* ino64-t) - (* mode-t) - (* nlink-t) - (* uid-t) - (* gid-t) - (* dev-t) - (* off-t) - (* (struct timespec-t)) - (* (struct timespec-t)) - (* (struct timespec-t)) - (* off-t) - (* off-t))) - (%name->file name) - (addr dev) - (addr ino) - (addr mode) - (addr nlink) - (addr uid) - (addr gid) - (addr rdev) - (addr size) - (addr atime) - (addr mtime) - (addr ctime) - (addr blksize) - (addr blocks)))) - (if (eql -1 result) - (values nil (unix-errno)) - (flet ((make-64bit (x) - (+ (alien:deref x 0) - (ash (alien:deref x 1) 32))) - (make-time (x) - (alien:slot x 'unix::ts-sec))) - (values t - (make-64bit dev) ino mode nlink uid gid - (make-64bit rdev) - size - (make-time atime) - (make-time mtime) - (make-time ctime) - blksize blocks)))))) + (declare (type unix-pathname name)) + (when (string= name "") + (setf name ".")) + (call-stat "unix_stat" c-call:c-string (%name->file name))) -(defun unix-lstat (name) - "Unix-lstat is similar to unix-stat except the specified + (defun unix-lstat (name) + "Unix-lstat is similar to unix-stat except the specified file must be a symbolic link." - (declare (type unix-pathname name)) - (with-alien ((dev dev-t) - (ino ino64-t) - (mode mode-t) - (nlink nlink-t) - (uid uid-t) - (gid gid-t) - (rdev dev-t) - (size off-t) - (atime (struct timespec-t)) - (mtime (struct timespec-t)) - (ctime (struct timespec-t)) - (blksize off-t) - (blocks off-t)) - (let ((result - (alien-funcall - (extern-alien "unix_lstat" - (function int - c-call::c-string - (* dev-t) - (* ino64-t) - (* mode-t) - (* nlink-t) - (* uid-t) - (* gid-t) - (* dev-t) - (* off-t) - (* (struct timespec-t)) - (* (struct timespec-t)) - (* (struct timespec-t)) - (* off-t) - (* off-t))) - (%name->file name) - (addr dev) - (addr ino) - (addr mode) - (addr nlink) - (addr uid) - (addr gid) - (addr rdev) - (addr size) - (addr atime) - (addr mtime) - (addr ctime) - (addr blksize) - (addr blocks)))) - (if (eql -1 result) - (values nil (unix-errno)) - (flet ((make-64bit (x) - (+ (alien:deref x 0) - (ash (alien:deref x 1) 32))) - (make-time (x) - (alien:slot x 'unix::ts-sec))) - (values t - (make-64bit dev) ino mode nlink uid gid - (make-64bit rdev) - size - (make-time atime) - (make-time mtime) - (make-time ctime) - blksize blocks)))))) + (declare (type unix-pathname name)) + (call-stat "unix_lstat" c-call:c-string (%name->file name))) -(defun unix-fstat (fd) - _N"Unix-fstat is similar to unix-stat except the file is specified + (defun unix-fstat (fd) + _N"Unix-fstat is similar to unix-stat except the file is specified by the file descriptor fd." - (declare (type unix-fd fd)) - (with-alien ((dev dev-t) - (ino ino64-t) - (mode mode-t) - (nlink nlink-t) - (uid uid-t) - (gid gid-t) - (rdev dev-t) - (size off-t) - (atime (struct timespec-t)) - (mtime (struct timespec-t)) - (ctime (struct timespec-t)) - (blksize off-t) - (blocks off-t)) - (let ((result - (alien-funcall - (extern-alien "unix_fstat" - (function int - int - (* dev-t) - (* ino64-t) - (* mode-t) - (* nlink-t) - (* uid-t) - (* gid-t) - (* dev-t) - (* off-t) - (* (struct timespec-t)) - (* (struct timespec-t)) - (* (struct timespec-t)) - (* off-t) - (* off-t))) - fd - (addr dev) - (addr ino) - (addr mode) - (addr nlink) - (addr uid) - (addr gid) - (addr rdev) - (addr size) - (addr atime) - (addr mtime) - (addr ctime) - (addr blksize) - (addr blocks)))) - (if (eql -1 result) - (values nil (unix-errno)) - (flet ((make-64bit (x) - (+ (alien:deref x 0) - (ash (alien:deref x 1) 32))) - (make-time (x) - (alien:slot x 'unix::ts-sec))) - (values t - (make-64bit dev) ino mode nlink uid gid - (make-64bit rdev) - size - (make-time atime) - (make-time mtime) - (make-time ctime) - blksize blocks)))))) -) + (declare (type unix-fd fd)) + (call-stat "unix_fstat" int fd))) ;;; 64-bit versions of stat and friends #+solaris ===================================== src/lisp/unix.c ===================================== @@ -2,13 +2,18 @@ * C interfaces to unix syscalls */ +/* We want to support large files */ + +#define _LARGEFILE_SOURCE +#define _FILE_OFFSET_BITS 64 + #include <stdio.h> #include <sys/stat.h> int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - struct timespec *atime, struct timespec *mtime, struct timespec *ctime, - long *blksize, long *blocks) + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) { int rc; struct stat buf; @@ -38,9 +43,9 @@ int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *n *gid = buf.st_gid; *rdev = buf.st_rdev; *size = buf.st_size; - *atime = buf.st_atim; - *mtime = buf.st_mtim; - *ctime = buf.st_ctim; + *atime = buf.st_atime; + *mtime = buf.st_mtime; + *ctime = buf.st_ctime; *blksize = buf.st_blksize; *blocks = buf.st_blocks; @@ -49,8 +54,8 @@ int unix_stat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *n int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - struct timespec *atime, struct timespec *mtime, struct timespec *ctime, - long *blksize, long *blocks) + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) { int rc; struct stat buf; @@ -65,9 +70,9 @@ int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, *gid = buf.st_gid; *rdev = buf.st_rdev; *size = buf.st_size; - *atime = buf.st_atim; - *mtime = buf.st_mtim; - *ctime = buf.st_ctim; + *atime = buf.st_atime; + *mtime = buf.st_mtime; + *ctime = buf.st_ctime; *blksize = buf.st_blksize; *blocks = buf.st_blocks; @@ -76,8 +81,8 @@ int unix_fstat(int fd, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, int unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t *nlink, uid_t *uid, gid_t *gid, dev_t *rdev, off_t *size, - struct timespec *atime, struct timespec *mtime, struct timespec *ctime, - long *blksize, long *blocks) + time_t *atime, time_t *mtime, time_t *ctime, + long *blksize, off_t *blocks) { int rc; struct stat buf; @@ -92,9 +97,9 @@ int unix_lstat(const char* path, dev_t *dev, ino_t *ino, mode_t *mode, nlink_t * *gid = buf.st_gid; *rdev = buf.st_rdev; *size = buf.st_size; - *atime = buf.st_atim; - *mtime = buf.st_mtim; - *ctime = buf.st_ctim; + *atime = buf.st_atime; + *mtime = buf.st_mtime; + *ctime = buf.st_ctime; *blksize = buf.st_blksize; *blocks = buf.st_blocks; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/6a38637e8653785b23e249… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/6a38637e8653785b23e249… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-125-unix-stat-wrong
by Raymond Toy (＠rtoy) 03 Aug '22

03 Aug '22

Raymond Toy pushed new branch issue-125-unix-stat-wrong at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-125-unix-stat-wrong You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cmucl-cvs August 2022