September 2022 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-132-ansi-test-rename-files] Rename NEW-FILE-NAME arg back to NEW-NAME
by Raymond Toy (＠rtoy) 28 Sep '22

28 Sep '22

Raymond Toy pushed to branch issue-132-ansi-test-rename-files at cmucl / cmucl Commits: 189b1940 by Raymond Toy at 2022-09-27T16:20:25-07:00 Rename NEW-FILE-NAME arg back to NEW-NAME This was an oversight from when I was doing some experiments on what to return from RENAME-FILE. - - - - - 1 changed file: - src/code/filesys.lisp Changes: ===================================== src/code/filesys.lisp ===================================== @@ -940,7 +940,7 @@ ;;; Rename-File -- Public ;;; -(defun rename-file (file new-file-name) +(defun rename-file (file new-name) "Rename File to have the specified New-Name. If file is a stream open to a file, then the associated file is renamed. @@ -953,7 +953,7 @@ ;; First, merge NEW-FILE-NAME with *DEFAULT-PATHNAME-DEFAULTS* to ;; fill in the missing components and then merge again with ;; the FILE to get any missing components from FILE. - (new-name (merge-pathnames (merge-pathnames new-file-name) + (new-name (merge-pathnames (merge-pathnames new-name) file)) (new-namestring (unix-namestring new-name nil))) (unless new-namestring View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/189b194089db3484d554ebb… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/189b194089db3484d554ebb… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-140-stream-element-type-two-way-stream] Update release notes for issue #140.
by Raymond Toy (＠rtoy) 27 Sep '22

27 Sep '22

Raymond Toy pushed to branch issue-140-stream-element-type-two-way-stream at cmucl / cmucl Commits: 334be4e0 by Raymond Toy at 2022-09-27T14:53:35-07:00 Update release notes for issue #140. - - - - - 1 changed file: - src/general-info/release-21e.md Changes: ===================================== src/general-info/release-21e.md ===================================== @@ -52,6 +52,7 @@ public domain. * ~~#122~~ gcc 11 can't build cmucl * ~~#127~~ Linux unix-getpwuid segfaults when given non-existent uid. * ~~#128~~ `QUIT` accepts an exit code + * ~~#140~~ External format of `two-way-stream` returns the common format of the input and output streams if possible; otherwise, return `:default`. * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/334be4e0666f767ce56332c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/334be4e0666f767ce56332c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-140-stream-element-type-two-way-stream
by Raymond Toy (＠rtoy) 27 Sep '22

27 Sep '22

Raymond Toy pushed new branch issue-140-stream-element-type-two-way-stream at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-140-stream-element-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-139-use-lang-to-set-external-format
by Raymond Toy (＠rtoy) 27 Sep '22

27 Sep '22

Raymond Toy pushed new branch issue-139-use-lang-to-set-external-format at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-139-use-lang-to-set… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-139-filename-encoding-utf8
by Raymond Toy (＠rtoy) 25 Sep '22

25 Sep '22

Raymond Toy pushed new branch issue-139-filename-encoding-utf8 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-139-filename-encodi… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-139a-default-external-format-utf8] *tty* format can be either :utf-8 or :default
by Raymond Toy (＠rtoy) 24 Sep '22

24 Sep '22

Raymond Toy pushed to branch issue-139a-default-external-format-utf8 at cmucl / cmucl Commits: 86b4483e by Raymond Toy at 2022-09-23T16:46:25-07:00 *tty* format can be either :utf-8 or :default `*tty*` can either be an fd-stream of a two-way-stream. If the former, the format is `:utf-8`; if the latter, `:default`. Update test accordingly. - - - - - 1 changed file: - tests/issues.lisp Changes: ===================================== tests/issues.lisp ===================================== @@ -587,7 +587,11 @@ (assert-eql :utf-8 (stream-external-format sys:*stdin*)) (assert-eql :utf-8 (stream-external-format sys:*stdout*)) (assert-eql :utf-8 (stream-external-format sys:*stderr*)) - (assert-eql :utf-8 (stream-external-format sys:*tty*)) + ;; *tty* can either be an fd-stream, in which case the format is + ;; utf8, or a two-way-stream, in which case it is :default. + (if (typep sys:*tty* 'two-way-stream) + (assert-eql :default (stream-external-format sys:*tty*)) + (assert-eql :utf-8 (stream-external-format sys:*tty*))) ;; Check that printing to *standard-output* is correctly encoded. (dribble "test-format.txt") ;; Print a Greek lower-case alpha character View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/86b4483e870dc7f5bd512fd… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/86b4483e870dc7f5bd512fd… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-139a-default-external-format-utf8] Explicitly set format to :utf-8 instead of :default
by Raymond Toy (＠rtoy) 24 Sep '22

24 Sep '22

Raymond Toy pushed to branch issue-139a-default-external-format-utf8 at cmucl / cmucl Commits: c5f31c3c by Raymond Toy at 2022-09-23T16:06:01-07:00 Explicitly set format to :utf-8 instead of :default - - - - - 1 changed file: - src/code/fd-stream.lisp Changes: ===================================== src/code/fd-stream.lisp ===================================== @@ -2397,20 +2397,20 @@ (setf *available-buffers* nil) (setf *stdin* (make-fd-stream 0 :name "Standard Input" :input t :buffering :line - :external-format :default)) + :external-format :utf-8)) (setf *stdout* (make-fd-stream 1 :name "Standard Output" :output t :buffering :line - :external-format :default)) + :external-format :utf-8)) (setf *stderr* (make-fd-stream 2 :name "Standard Error" :output t :buffering :line - :external-format :default)) + :external-format :utf-8)) (let ((tty (and (not *batch-mode*) (unix:unix-open "/dev/tty" unix:o_rdwr #o666)))) (setf *tty* (if tty (make-fd-stream tty :name "the Terminal" :input t :output t :buffering :line :auto-close t - :external-format :default) + :external-format :utf-8) (make-two-way-stream *stdin* *stdout*)))) nil) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c5f31c3cd0628d668831d28… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c5f31c3cd0628d668831d28… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-139a-default-external-format-utf8] Add test for default external format and system streams
by Raymond Toy (＠rtoy) 24 Sep '22

24 Sep '22

Raymond Toy pushed to branch issue-139a-default-external-format-utf8 at cmucl / cmucl Commits: 344b9482 by Raymond Toy at 2022-09-23T15:14:21-07:00 Add test for default external format and system streams Verify that the default external format is :utf-8 and that all the system streams use :utf-8. - - - - - 1 changed file: - tests/issues.lisp Changes: ===================================== tests/issues.lisp ===================================== @@ -579,3 +579,20 @@ with user-info = (unix:unix-getpwuid uid) while user-info finally (assert-false user-info))) + +(define-test issue-139.1 + (:tag :issues) + ;; Verify the value of the default external format and that system streams use :utf-8. + (assert-eql :utf-8 stream:*default-external-format*) + (assert-eql :utf-8 (stream-external-format sys:*stdin*)) + (assert-eql :utf-8 (stream-external-format sys:*stdout*)) + (assert-eql :utf-8 (stream-external-format sys:*stderr*)) + (assert-eql :utf-8 (stream-external-format sys:*tty*)) + ;; Check that printing to *standard-output* is correctly encoded. + (dribble "test-format.txt") + ;; Print a Greek lower-case alpha character + (princ #\u+3b1) + (dribble) + (with-open-file (s "test-format.txt" :direction :input) + (let ((c (read-char s))) + (assert-equal #\u+3b1 c)))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/344b948245ca3b33154c767… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/344b948245ca3b33154c767… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-139a-default-external-format-utf8
by Raymond Toy (＠rtoy) 23 Sep '22

23 Sep '22

Raymond Toy pushed new branch issue-139a-default-external-format-utf8 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-139a-default-extern… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-135-unix-namestring-dot] Add tests for #135
by Raymond Toy (＠rtoy) 21 Sep '22

21 Sep '22

Raymond Toy pushed to branch issue-135-unix-namestring-dot at cmucl / cmucl Commits: 777ccaeb by Raymond Toy at 2022-09-20T16:42:52-07:00 Add tests for #135 - - - - - 1 changed file: - tests/issues.lisp Changes: ===================================== tests/issues.lisp ===================================== @@ -579,3 +579,9 @@ with user-info = (unix:unix-getpwuid uid) while user-info finally (assert-false user-info))) + +(define-test issue.135 + (:tag :issues) + (assert-equalp "." (ext:unix-namestring ".")) + (assert-equalp "./abc.txt" (ext:unix-namestring "abc.txt")) + (assert-equalp "./abc/def/foo.txt" (ext:unix-namestring "abc/def/foo.txt"))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/777ccaebb94ed0ccbf5e8f0… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/777ccaebb94ed0ccbf5e8f0… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch 135-unix-namestring-returns-instead-of
by Raymond Toy (＠rtoy) 21 Sep '22

21 Sep '22

Raymond Toy pushed new branch 135-unix-namestring-returns-instead-of at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/135-unix-namestring-retur… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-135-unix-namestring-dot
by Raymond Toy (＠rtoy) 21 Sep '22

21 Sep '22

Raymond Toy pushed new branch issue-135-unix-namestring-dot at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-135-unix-namestring… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-130-file-author-in-c] Address review comments
by Raymond Toy (＠rtoy) 20 Sep '22

20 Sep '22

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl Commits: 818a0d5b by Raymond Toy at 2022-09-19T18:22:05-07:00 Address review comments Use alien::null-alien to check for C NULL ptr. Remove debugging print from os_file_author. - - - - - 2 changed files: - src/code/filesys.lisp - src/lisp/os-common.c Changes: ===================================== src/code/filesys.lisp ===================================== @@ -1087,10 +1087,9 @@ optionally keeping some of the most recent old versions." (alien:extern-alien "os_file_author" (function (alien:* c-call:c-string) c-call:c-string)) (unix::%name->file name))) - (unless (zerop (sap-int (alien:alien-sap author))) + (unless (alien:null-alien author) (alien:cast author c-call:c-string))) - (when author - (alien:free-alien author))))))) + (alien:free-alien author)))))) ;;;; DIRECTORY. ===================================== src/lisp/os-common.c ===================================== @@ -774,8 +774,6 @@ os_file_author(const char *path) } } exit: - fprintf(stderr, "buffer, initial = %p %p\n", buffer, initial); - if (buffer != initial) { free(buffer); } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/818a0d5b5372b0846cc1924… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/818a0d5b5372b0846cc1924… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-132-ansi-test-rename-files] 2 commits: Add two more tests for RENAME-FILE
by Raymond Toy (＠rtoy) 16 Sep '22

16 Sep '22

Raymond Toy pushed to branch issue-132-ansi-test-rename-files at cmucl / cmucl Commits: 2a4c3765 by Raymond Toy at 2022-09-16T13:53:26-07:00 Add two more tests for RENAME-FILE One tests renaming the directory "dir/orig.dir" to "dir/new.dir" because we call `(rename-file "orig.dir" "new")` and the old file name has a pathname-name of "orig" and a pathname-type of "dir" so the new file name has the missing components filled in to produce "new.dir". The second test does `(rename-file "orig.dir/" "new")`. The original file has no name or type, so merging "new" adds nothing and we rename "orig.dir" to just "new". - - - - - 38e9d88e by Raymond Toy at 2022-09-16T13:53:56-07:00 Undo change as requested by reviewer - - - - - 2 changed files: - .gitlab-ci.yml - tests/issues.lisp Changes: ===================================== .gitlab-ci.yml ===================================== @@ -80,7 +80,7 @@ linux:ansi-test: script: - cd ansi-test - make LISP="../dist/bin/lisp -batch -noinit -nositeinit" - - grep -a 'unexpected \(successes\|failures\)' test.out + - grep 'No unexpected \(successes\|failures\)' test.out linux:benchmark: stage: benchmark ===================================== tests/issues.lisp ===================================== @@ -580,7 +580,7 @@ while user-info finally (assert-false user-info))) -(define-test issue.132 +(define-test issue.132.1 (:tag :issues) ;; From a message on cmucl-imp 2008/06/01. If "d1" is a directory, ;; (rename "d1" "d2") should rename the directory "d1" to "d2". @@ -588,7 +588,7 @@ ;; "d1/d2". ;; ;; Create the test directory (that is a subdirectory of "dir"). - (assert (ensure-directories-exist "dir/orig-dir/")) + (assert-true (ensure-directories-exist "dir/orig-dir/")) (let ((*default-pathname-defaults* (merge-pathnames "dir/" (ext:default-directory)))) (multiple-value-bind (defaulted-new-name old-truename new-truename) ;; Rename "dir/orig-dir" to "orig/new-dir". @@ -599,7 +599,49 @@ (make-pathname :directory '(:relative "new-dir"))))) ;; Ensure that the rename worked and that the returned values ;; have the expected values. - (assert defaulted-new-name) - (assert (equalp old-truename orig)) - (assert (equalp new-truename new)))))) - + (assert-true defaulted-new-name) + (assert-equalp old-truename orig) + (assert-equalp new-truename new))))) + +(define-test issue.132.2 + (:tag :issues) + (assert-true (ensure-directories-exist "dir/orig.dir/")) + (let ((*default-pathname-defaults* (merge-pathnames "dir/" (ext:default-directory)))) + (multiple-value-bind (defaulted-new-name old-truename new-truename) + ;; Rename "dir/orig.dir" to "orig/new-dir". Since the + ;; original name has a pathname-name of "orig" and a + ;; pathname-type of "dir", the new file name is merged to + ;; produce a pathname-name of "new" with a pathname-type of + ;; "dir". + (rename-file "orig.dir" "new") + (let ((orig (merge-pathnames + (make-pathname :directory '(:relative "orig.dir")))) + (new (merge-pathnames + (make-pathname :directory '(:relative "new.dir"))))) + ;; Ensure that the rename worked and that the returned values + ;; have the expected values. + (assert-true defaulted-new-name) + (assert-equalp old-truename orig) + (assert-equalp new-truename new))))) + +(define-test issue.132.3 + (:tag :issues) + (assert-true (ensure-directories-exist "dir/orig.dir/")) + (let ((*default-pathname-defaults* (merge-pathnames "dir/" (ext:default-directory)))) + (multiple-value-bind (defaulted-new-name old-truename new-truename) + ;; Rename "dir/orig.dir/" to "orig/new". Note that the + ;; original name is "orig.dir/" which marks a directory so + ;; that when we merge the new name with the old to fill in + ;; missing components, there are none because the old name is + ;; a directory with no pathname-name or pathname-type, so the + ;; new name stays the same. + (rename-file "orig.dir/" "new") + (let ((orig (merge-pathnames + (make-pathname :directory '(:relative "orig.dir")))) + (new (merge-pathnames + (make-pathname :directory '(:relative "new"))))) + ;; Ensure that the rename worked and that the returned values + ;; have the expected values. + (assert-true defaulted-new-name) + (assert-equalp old-truename orig) + (assert-equalp new-truename new))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/127d8235e5c2553e359af9… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/127d8235e5c2553e359af9… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-132-ansi-test-rename-files] Fix so renaming directories does the expected thing.
by Raymond Toy (＠rtoy) 16 Sep '22

16 Sep '22

Raymond Toy pushed to branch issue-132-ansi-test-rename-files at cmucl / cmucl Commits: 127d8235 by Raymond Toy at 2022-09-16T12:58:47-07:00 Fix so renaming directories does the expected thing. To do this, we need to merge the new name with *default-pathname-defaults* to fill in the directory components if needed. Then we merge that with the original name to fill any unfilled components. Add a test for this where we rename "dir/orig-dir" to "dir/new-dir". - - - - - 2 changed files: - src/code/filesys.lisp - tests/issues.lisp Changes: ===================================== src/code/filesys.lisp ===================================== @@ -940,7 +940,7 @@ ;;; Rename-File -- Public ;;; -(defun rename-file (file new-name) +(defun rename-file (file new-file-name) "Rename File to have the specified New-Name. If file is a stream open to a file, then the associated file is renamed. @@ -950,7 +950,11 @@ File after it was renamed." (let* ((original (truename file)) (original-namestring (unix-namestring original t)) - (new-name (merge-pathnames new-name original)) + ;; First, merge NEW-FILE-NAME with *DEFAULT-PATHNAME-DEFAULTS* to + ;; fill in the missing components and then merge again with + ;; the FILE to get any missing components from FILE. + (new-name (merge-pathnames (merge-pathnames new-file-name) + file)) (new-namestring (unix-namestring new-name nil))) (unless new-namestring (error 'simple-file-error @@ -968,7 +972,9 @@ (unix:get-unix-error-msg error)))) (when (streamp file) (file-name file new-namestring)) - (values new-name original (truename new-name))))) + (values new-name + original + (truename new-name))))) ;;; Delete-File -- Public ;;; ===================================== tests/issues.lisp ===================================== @@ -579,3 +579,27 @@ with user-info = (unix:unix-getpwuid uid) while user-info finally (assert-false user-info))) + +(define-test issue.132 + (:tag :issues) + ;; From a message on cmucl-imp 2008/06/01. If "d1" is a directory, + ;; (rename "d1" "d2") should rename the directory "d1" to "d2". + ;; Previously that produced an error trying to rename "d1" to + ;; "d1/d2". + ;; + ;; Create the test directory (that is a subdirectory of "dir"). + (assert (ensure-directories-exist "dir/orig-dir/")) + (let ((*default-pathname-defaults* (merge-pathnames "dir/" (ext:default-directory)))) + (multiple-value-bind (defaulted-new-name old-truename new-truename) + ;; Rename "dir/orig-dir" to "orig/new-dir". + (rename-file "orig-dir/" "new-dir") + (let ((orig (merge-pathnames + (make-pathname :directory '(:relative "orig-dir")))) + (new (merge-pathnames + (make-pathname :directory '(:relative "new-dir"))))) + ;; Ensure that the rename worked and that the returned values + ;; have the expected values. + (assert defaulted-new-name) + (assert (equalp old-truename orig)) + (assert (equalp new-truename new)))))) + View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/127d8235e5c2553e359af9e… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/127d8235e5c2553e359af9e… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-136-ansi-test-ensure-directories-exist.8] Update tests for change in ensure-directories-exist
by Raymond Toy (＠rtoy) 11 Sep '22

11 Sep '22

Raymond Toy pushed to branch issue-136-ansi-test-ensure-directories-exist.8 at cmucl / cmucl Commits: c59de890 by Raymond Toy at 2022-09-10T20:20:54-07:00 Update tests for change in ensure-directories-exist The tests here assumed that `ensure-directories-exits` would return a pathname object. But it doesn't anymore; it returns the given pathspec as is. - - - - - 1 changed file: - tests/filesys.lisp Changes: ===================================== tests/filesys.lisp ===================================== @@ -10,7 +10,7 @@ (define-test unix-namestring.1.exists ;; Make sure the desired directories exist. - (assert-equal #P"/tmp/foo/bar/hello.txt" + (assert-equal "/tmp/foo/bar/hello.txt" (ensure-directories-exist "/tmp/foo/bar/hello.txt")) (dolist (path '("/tmp/hello.txt" "/tmp/foo/" @@ -27,7 +27,7 @@ (define-test unix-namestring.1.non-existent ;; Make sure the desired directories exist. - (assert-equal #P"/tmp/foo/bar/hello.txt" + (assert-equal "/tmp/foo/bar/hello.txt" (ensure-directories-exist "/tmp/foo/bar/hello.txt")) ;; These paths contain directories that don't exist. (dolist (path '("/tmp/oops/" @@ -42,7 +42,7 @@ (define-test unix-namestring.2 ;; Make sure the desired directories exist. - (assert-equal #P"/tmp/foo/bar/hello.txt" + (assert-equal "/tmp/foo/bar/hello.txt" (ensure-directories-exist "/tmp/foo/bar/hello.txt")) (unwind-protect (progn View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c59de890d9e63d007d56ac3… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/c59de890d9e63d007d56ac3… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-136-ansi-test-ensure-directories-exist.8
by Raymond Toy (＠rtoy) 11 Sep '22

11 Sep '22

Raymond Toy pushed new branch issue-136-ansi-test-ensure-directories-exist.8 at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-136-ansi-test-ensur… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch 134-expt-1-c-2-2-signals-an-error-incorrectly
by Raymond Toy (＠rtoy) 07 Sep '22

07 Sep '22

Raymond Toy pushed new branch 134-expt-1-c-2-2-signals-an-error-incorrectly at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/134-expt-1-c-2-2-signals-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-134-expt-bug
by Raymond Toy (＠rtoy) 07 Sep '22

07 Sep '22

Raymond Toy pushed new branch issue-134-expt-bug at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-134-expt-bug You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-130-file-author-in-c] Only free buffer if it's not the stack buffer
by Raymond Toy (＠rtoy) 06 Sep '22

06 Sep '22

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl Commits: 4d0d6006 by Raymond Toy at 2022-09-05T15:41:50-07:00 Only free buffer if it's not the stack buffer - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -776,6 +776,9 @@ os_file_author(const char *path) exit: fprintf(stderr, "buffer, initial = %p %p\n", buffer, initial); - free(buffer); + if (buffer != initial) { + free(buffer); + } + return result; } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/4d0d6006bd9b85dae184edf… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/4d0d6006bd9b85dae184edf… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-130-file-author-in-c] 4 commits: Reindent according to cmucl style
by Raymond Toy (＠rtoy) 06 Sep '22

06 Sep '22

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl Commits: 6557e832 by Raymond Toy at 2022-09-05T14:45:35-07:00 Reindent according to cmucl style - - - - - 08b38701 by Raymond Toy at 2022-09-05T14:50:40-07:00 Apply suggested change to test for zero length. - - - - - 3a41b05c by Raymond Toy at 2022-09-05T14:54:16-07:00 Add a few comments - - - - - c4a9d0d8 by Raymond Toy at 2022-09-05T15:16:43-07:00 Add assert.h and replace ARRAYSIZE with sizeof We need to include assert.h to define the `assert` macro that we use. `ARRAYSIZE` needs to be replaced with `sizeof` to compute the size of the `initial` buffer. - - - - - 2 changed files: - src/code/filesys.lisp - src/lisp/os-common.c Changes: ===================================== src/code/filesys.lisp ===================================== @@ -1078,7 +1078,7 @@ optionally keeping some of the most recent old versions." ;; unix-namestring converts "." to "". Convert it back to ;; "." so we can stat the current directory. (Perhaps ;; that's a bug in unix-namestring?) - (when (string= name "") + (when (zerop (length name)) (setf name ".")) (let (author) (unwind-protect ===================================== src/lisp/os-common.c ===================================== @@ -5,6 +5,7 @@ */ +#include <assert.h> #include <errno.h> #include <math.h> #include <netdb.h> @@ -738,31 +739,43 @@ os_file_author(const char *path) if (stat(path, &sb) != 0) { return NULL; } + result = NULL; buffer = initial; - size = ARRAYSIZE(initial); - assert(sysconf(_SC_GETPW_R_SIZE_MAX) <= 16384)); + size = sizeof(initial) / sizeof(initial[0]); + + /* + * Assume a buffer of size 16384 is enough to for getpwuid_r to do + * it's thing. + */ + assert(sysconf(_SC_GETPW_R_SIZE_MAX) <= 16384); + + /* + * Keep trying with larger buffers until a maximum is reached. + */ while (size <= 16384) { switch (getpwuid_r(sb.st_uid, &pwd, buffer, size, &ppwd)) { - case 0: - /* Success, though we might not have a matching entry */ - result = (ppwd == NULL) ? NULL : strdup(pwd.pw_name); - goto exit; - case ERANGE: - /* Buffer is too small, double its size and try again */ - size *= 2; - obuffer = (buffer == initial) ? NULL : buffer; - if ((buffer = realloc(obuffer, size)) == NULL) { - free(obuffer); - goto exit; - } - continue; - default: - /* All other errors */ - goto exit; + case 0: + /* Success, though we might not have a matching entry */ + result = (ppwd == NULL) ? NULL : strdup(pwd.pw_name); + goto exit; + case ERANGE: + /* Buffer is too small, double its size and try again */ + size *= 2; + obuffer = (buffer == initial) ? NULL : buffer; + if ((buffer = realloc(obuffer, size)) == NULL) { + free(obuffer); + goto exit; + } + continue; + default: + /* All other errors */ + goto exit; } } exit: + fprintf(stderr, "buffer, initial = %p %p\n", buffer, initial); + free(buffer); return result; } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/518ef95922f48ff2e29087… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/518ef95922f48ff2e29087… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-130-file-author-in-c] Apply 1 suggestion(s) to 1 file(s)
by Raymond Toy (＠rtoy) 05 Sep '22

05 Sep '22

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl Commits: 518ef959 by Carl S. Shapiro at 2022-09-05T04:59:53+00:00 Apply 1 suggestion(s) to 1 file(s) - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -727,66 +727,42 @@ os_lstat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u char * os_file_author(const char *path) { - int status; - struct stat statbuf; - char* author = NULL; - bool nomem = false; - size_t bufsize; - char* buf = NULL; - char* buf2 = NULL; + struct stat sb; + char initial[1024]; + char *buffer, *obuffer; + size_t size; struct passwd pwd; - struct passwd *result = NULL; - - status = stat(path, &statbuf); + struct passwd *ppwd; + char *result; - if (status != 0) { + if (stat(path, &sb) != 0) { return NULL; } - - bufsize = sysconf(_SC_GETPW_R_SIZE_MAX); - - /* - * If sysconf fails, just use a small initial buffer size that we - * will keep growing up to some maximum size. - */ - if (bufsize == -1) { - bufsize = 1024; - } - - while (1) { - buf2 = realloc(buf, bufsize); - - if (buf2 == NULL) { - result = NULL; - nomem = true; - break; - } - - buf = buf2; - status = getpwuid_r(statbuf.st_uid, &pwd, buf, bufsize, &result); - - if (status != 0) { - result = NULL; - } - if ((result != NULL) || (status != ERANGE)) { - break; - } - /* If bufsize exceeds some large size, give up. */ - if (bufsize > 16384) { - nomem = true; - break; + result = NULL; + buffer = initial; + size = ARRAYSIZE(initial); + assert(sysconf(_SC_GETPW_R_SIZE_MAX) <= 16384)); + while (size <= 16384) { + switch (getpwuid_r(sb.st_uid, &pwd, buffer, size, &ppwd)) { + case 0: + /* Success, though we might not have a matching entry */ + result = (ppwd == NULL) ? NULL : strdup(pwd.pw_name); + goto exit; + case ERANGE: + /* Buffer is too small, double its size and try again */ + size *= 2; + obuffer = (buffer == initial) ? NULL : buffer; + if ((buffer = realloc(obuffer, size)) == NULL) { + free(obuffer); + goto exit; + } + continue; + default: + /* All other errors */ + goto exit; } - - bufsize <<= 1; } - - if (result) { - author = strdup(result->pw_name); - } - - if (buf) { - free(buf); - } - - return author; +exit: + free(buffer); + return result; } View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/518ef95922f48ff2e290878… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/518ef95922f48ff2e290878… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-130-file-author-in-c] Apply 1 suggestion(s) to 1 file(s)
by Raymond Toy (＠rtoy) 05 Sep '22

05 Sep '22

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl Commits: 344f246c by Carl S. Shapiro at 2022-09-05T04:55:48+00:00 Apply 1 suggestion(s) to 1 file(s) - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -9,7 +9,6 @@ #include <math.h> #include <netdb.h> #include <pwd.h> -#include <stdbool.h> #include <stdio.h> #include <stdlib.h> #include <string.h> View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/344f246c2bc4dd290e45f9d… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/344f246c2bc4dd290e45f9d… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-130-file-author-in-c] Apply 1 suggestion(s) to 1 file(s)
by Raymond Toy (＠rtoy) 05 Sep '22

05 Sep '22

Raymond Toy pushed to branch issue-130-file-author-in-c at cmucl / cmucl Commits: 8a90499a by Carl S. Shapiro at 2022-09-05T04:52:30+00:00 Apply 1 suggestion(s) to 1 file(s) - - - - - 1 changed file: - src/code/filesys.lisp Changes: ===================================== src/code/filesys.lisp ===================================== @@ -1061,29 +1061,6 @@ optionally keeping some of the most recent old versions." ;;; File-Author -- Public ;;; -#+nil -(defun file-author (file) - "Returns the file author as a string, or nil if the author cannot be - determined. Signals an error of type file-error if file doesn't exist, - or file is a wild pathname." - (if (wild-pathname-p file) - (error 'simple-file-error - :pathname file - :format-control (intl:gettext "Bad place for a wild pathname.")) - (let ((name (unix-namestring (merge-pathnames file) t))) - (unless name - (error 'simple-file-error - :pathname file - :format-control (intl:gettext "~S doesn't exist.") - :format-arguments (list file))) - (multiple-value-bind (winp dev ino mode nlink uid) - (unix:unix-stat name) - (declare (ignore dev ino mode nlink)) - (when winp - (let ((user-info (unix:unix-getpwuid uid))) - (when user-info - (unix:user-info-name user-info)))))))) - (defun file-author (file) "Returns the file author as a string, or nil if the author cannot be determined. Signals an error of type file-error if file doesn't exist, View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/8a90499aa2f4c569d8d32da… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/8a90499aa2f4c569d8d32da… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-132-ansi-test-rename-files] Oops. Look for unexpected successes/failures
by Raymond Toy (＠rtoy) 04 Sep '22

04 Sep '22

Raymond Toy pushed to branch issue-132-ansi-test-rename-files at cmucl / cmucl Commits: 41147e45 by Raymond Toy at 2022-09-03T21:46:04-07:00 Oops. Look for unexpected successes/failures We were grep'ing for 'No unexpected' successes or failures. We really should be looking for unexpected successes or failures. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -80,7 +80,7 @@ linux:ansi-test: script: - cd ansi-test - make LISP="../dist/bin/lisp -batch -noinit -nositeinit" - - grep -a 'No unexpected \(successes\|failures\)' test.out + - grep -a 'unexpected \(successes\|failures\)' test.out linux:benchmark: stage: benchmark View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/41147e45c35af0c6d947e99… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/41147e45c35af0c6d947e99… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

cmucl-cvs September 2022