cmucl-cvs

Download

cmucl-cvs@common-lisp.net

February 2023

1 participants
32 discussions

[Git][cmucl/cmucl][issue-162-filename-encoding-no-encoding] Disable issue.41.1 when running CI
by Raymond Toy (＠rtoy) 15 Feb '23

15 Feb '23

Raymond Toy pushed to branch issue-162-filename-encoding-no-encoding at cmucl / cmucl Commits: 9eb801f6 by Raymond Toy at 2023-02-15T13:01:43-08:00 Disable issue.41.1 when running CI This test was previously disabled only for Linux when running the CI. However, it's now also failing when running the CI for Darwin. Thus disable it whenever we're running the CI. I just manually tested this on my Linux and Mac boxes. This test passes without any problem. Not sure what's going on. - - - - - 1 changed file: - tests/issues.lisp Changes: ===================================== tests/issues.lisp ===================================== @@ -416,9 +416,12 @@ ;; running a pipeline with linux, but otherwise enable it. The ;; pipeline defines the envvar GITLAB_CI so check for that. ;; +;; This also fails on Darwin CI now. Let's just disable the test if +;; running on CI. +;; ;; It would be better if lisp-unit had a way of marking tests as known ;; failures, but it doesn't. -#+#.(cl:if (cl:and (ext:featurep :linux) (unix:unix-getenv "GITLAB_CI")) '(or) '(and)) +#+#.(cl:if (cl:and (unix:unix-getenv "GITLAB_CI")) '(or) '(and)) (define-test issue.41.1 (:tag :issues) (issue-41-tester unix:sigstop)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9eb801f6a320f02c222624f… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9eb801f6a320f02c222624f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-162-filename-encoding-no-encoding] Fix stupid typos
by Raymond Toy (＠rtoy) 10 Feb '23

10 Feb '23

Raymond Toy pushed to branch issue-162-filename-encoding-no-encoding at cmucl / cmucl Commits: ce202074 by Raymond Toy at 2023-02-10T08:29:32-08:00 Fix stupid typos Really stupid typos/thinkos: * Forgot to change initial value if `*filename-encoding*` from `:no-encoding` to `:null`. (Stupid!) * Fix typo: `:nul` instead of `:null` in `%name->file`. Update cmucl-unix.pot too for the change in the docstring for `*filename-encoding*`. - - - - - 2 changed files: - src/code/unix.lisp - src/i18n/locale/cmucl-unix.pot Changes: ===================================== src/code/unix.lisp ===================================== @@ -25,7 +25,7 @@ ;; it must be set to :iso8859-1 (or left as NIL), making files with ;; non-Latin-1 characters "mojibake", but otherwise they'll be inaccessible. ;; Must be set to NIL initially to enable building Lisp! -(defvar *filename-encoding* :no-encoding +(defvar *filename-encoding* :null "The encoding to use for converting a namestring to a string that can be used by the operations system. It must be a valid external-format name or :NULL. :NULL means the string @@ -34,7 +34,7 @@ (eval-when (:compile-toplevel :load-toplevel :execute) (defmacro %name->file (string) - `(if (eql *filename-encoding* :nul) + `(if (eql *filename-encoding* :null) ,string (string-encode ,string *filename-encoding*))) (defmacro %file->name (string) ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -19,7 +19,7 @@ msgstr "" msgid "" "The encoding to use for converting a namestring to a string that can\n" " be used by the operations system. It must be a valid\n" -" external-format name or :NO-ENCODING. :NO-ENCODING means the string\n" +" external-format name or :NULL. :NULL means the string\n" " is passed as is to the operating system. The operating system will\n" " get the low 8 bits of each UTF-16 code unit of the string." msgstr "" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ce202074d2ffa1b1626f7bd… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ce202074d2ffa1b1626f7bd… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0