July 2024 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-337-cross-compile-linux-x86-fails] Add CI to do cross-compile and run unit-tests
by Raymond Toy (＠rtoy) 15 Jul '24

15 Jul '24

Raymond Toy pushed to branch issue-337-cross-compile-linux-x86-fails at cmucl / cmucl Commits: d76be25f by Raymond Toy at 2024-07-15T14:40:25-07:00 Add CI to do cross-compile and run unit-tests Do a cross-compile and then a native build to test the cross-compiler. Then use that result (in `xdist/bin/lisp`) to run the unit tests. These should work. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -52,6 +52,20 @@ linux:build: # describe return something that make-dist.sh doesn't like. - bin/make-dist.sh -V `git describe --dirty` -I dist linux-4 +linux:cross-build: + stage: build + tags: + - linux + needs: + - job: linux:install + artifacts: true + script: + - bin/create-target.sh xtarget + - bin/create-target.sh xcross + - bin/cross-build-world.sh -crl xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp + - bin/build.sh $bootstrap -R -C "" -o xtarget/lisp/lisp + - bin/make-dist.sh -V `git describe --dirty` -I xdist linux-4 + linux:test: stage: test tags: @@ -67,6 +81,21 @@ linux:test: script: - bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log +linux:cross-test: + stage: test + tags: + - linux + artifacts: + paths: + - ansi-test/test.out + - cross-test.log + needs: + # Needs artifacts from build (dist/) + - job: linux:cross-build + artifacts: true + script: + - bin/run-unit-tests.sh -l xdist/bin/lisp 2>&1 | tee cross-test.log + linux:ansi-test: stage: ansi-test tags: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d76be25f99317f2fd9df7aa… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d76be25f99317f2fd9df7aa… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-337-cross-compile-linux-x86-fails
by Raymond Toy (＠rtoy) 15 Jul '24

15 Jul '24

Raymond Toy pushed new branch issue-337-cross-compile-linux-x86-fails at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-337-cross-compile-l… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #333: LOAD :IF-DOES-NOT-EXIST is a generalized boolean
by Raymond Toy (＠rtoy) 14 Jul '24

14 Jul '24

Raymond Toy pushed to branch master at cmucl / cmucl Commits: decda1f5 by Raymond Toy at 2024-07-14T12:34:05+00:00 Fix #333: LOAD :IF-DOES-NOT-EXIST is a generalized boolean - - - - - 5c8483f8 by Raymond Toy at 2024-07-14T12:34:13+00:00 Merge branch 'issue-333-load-if-does-not-exist' into 'master' Fix #333: LOAD :IF-DOES-NOT-EXIST is a generalized boolean Closes #333 See merge request cmucl/cmucl!231 - - - - - 3 changed files: - src/code/load.lisp - src/compiler/fndb.lisp - tests/issues.lisp Changes: ===================================== src/code/load.lisp ===================================== @@ -565,7 +565,8 @@ (fasload filename) (sloload filename)) (let ((pn (merge-pathnames (pathname filename) - *default-pathname-defaults* nil))) + *default-pathname-defaults* nil)) + (if-does-not-exist (if if-does-not-exist :error nil))) (if (wild-pathname-p pn) (dolist (file (directory pn) t) (internal-load pn file if-does-not-exist contents ===================================== src/compiler/fndb.lisp ===================================== @@ -1119,7 +1119,7 @@ (defknown load ((or filename stream) - &key (:verbose t) (:print t) (:if-does-not-exist (member :error nil)) + &key (:verbose t) (:print t) (:if-does-not-exist t) (:if-source-newer (member :load-source :load-object :query :compile)) (:contents (or null (member :source :binary))) (:external-format t)) ===================================== tests/issues.lisp ===================================== @@ -1105,3 +1105,16 @@ (not (zerop n)))) (dolist (x '(0 1 1000)) (assert-equal (expected x) (fun x) x)))) + +(define-test issue.333.if-does-not-exist + (:tag :issues) + ;; "unknown.lisp" should be a file that doesn't exist. Verify that + ;; if :IF-DOES-NOT-EXIST is non-NIL we signal an error from LOAD. + ;; The first case is the old default value of :ERROR. + (assert-error 'file-error + (load "unknown.lisp" :if-does-not-exist :error)) + ;; :IF-DOES-NOT-EXIST is a generalized BOOLEAN, so non-NIL will + ;; signal an error too. + (assert-error 'file-error + (load "unknown.lisp" :if-does-not-exist t)) + (assert-false (load "unknown.lisp" :if-does-not-exist nil))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/bf1475ce65e21ef3dd6fc1… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/bf1475ce65e21ef3dd6fc1… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-336-1-fix-compiler-notes] Fix note about unreachable code in float-sse2.lisp
by Raymond Toy (＠rtoy) 13 Jul '24

13 Jul '24

Raymond Toy pushed to branch issue-336-1-fix-compiler-notes at cmucl / cmucl Commits: 1cf38921 by Raymond Toy at 2024-07-12T17:19:30-07:00 Fix note about unreachable code in float-sse2.lisp The warning happens because we do `(and ,commutative ...)` where `commutative` is a known value passed to the macro. When the value is zero, we get the note since the rest of the `and` clause is known to be unreachable. Change this to handle the `commutative` and macro-expansion time to add the clause only when `commutative` is true. - - - - - 1 changed file: - src/compiler/x86/float-sse2.lisp Changes: ===================================== src/compiler/x86/float-sse2.lisp ===================================== @@ -773,10 +773,11 @@ (inst ,opinst x (,ea y))) (,stack-sc (inst ,opinst x (,ea-stack y))))) - ((and ,commutative (location= y r)) - ;; y = r and the operation is commutative, so just - ;; do the operation with r and x. - (inst ,opinst y x)) + ,@(when commutative + `(((location= y r) + ;; y = r and the operation is commutative, so just + ;; do the operation with r and x. + (inst ,opinst y x)))) ((not (location= r y)) ;; x, y, and r are three different regs. So just ;; move r to x and do the operation on r. @@ -1994,8 +1995,9 @@ `(cond ((location= x r) (inst ,opinst x y)) - ((and ,commutative (location= y r)) - (inst ,opinst y x)) + ,@(when commutative + `(((location= y r) + (inst ,opinst y x)))) ((not (location= r y)) (inst ,movinst r x) (inst ,opinst r y)) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1cf38921444b05008021ac3… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1cf38921444b05008021ac3… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-336-1-fix-compiler-notes
by Raymond Toy (＠rtoy) 12 Jul '24

12 Jul '24

Raymond Toy pushed new branch issue-336-1-fix-compiler-notes at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-336-1-fix-compiler-… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-334-add-wiki-link-checker] Allow linkchecker to fail so pipeline will continue
by Raymond Toy (＠rtoy) 10 Jul '24

10 Jul '24

Raymond Toy pushed to branch issue-334-add-wiki-link-checker at cmucl / cmucl Commits: 534f2ae3 by Raymond Toy at 2024-07-10T15:12:09-07:00 Allow linkchecker to fail so pipeline will continue We don't want the link checker to stop the pipeline so allow it it fail. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -200,6 +200,9 @@ linkchecker: # Only the linux runner has markdown-link-check installed tags: - linux + # It's ok if this fails; we don't want to declare the entire + # pipeline as having failed. + allow_failure: true script: # Check links in the main repo - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/534f2ae3fec75e4d9bc7da7… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/534f2ae3fec75e4d9bc7da7… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-334-add-wiki-link-checker] Use the Linux runner for the link checker
by Raymond Toy (＠rtoy) 10 Jul '24

10 Jul '24

Raymond Toy pushed to branch issue-334-add-wiki-link-checker at cmucl / cmucl Commits: f1ddd73c by Raymond Toy at 2024-07-10T14:40:43-07:00 Use the Linux runner for the link checker Installed markdown-link-check on the Linux runner so we can run the link check there. This is useful because it lets us clone the wiki pages so we can check the links. (I hope; needs testing.) - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -197,9 +197,9 @@ osx:benchmark: # Checks links on the wiki pages whenever any wiki markdown pages change. linkchecker: stage: link-check - image: - name: ghcr.io/tcort/markdown-link-check:3.11.2 - entrypoint: ["/bin/sh", "-c"] + # Only the linux runner has markdown-link-check installed + tags: + - linux script: # Check links in the main repo - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f1ddd73c5c1866df5d4937d… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f1ddd73c5c1866df5d4937d… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-334-add-wiki-link-checker] Run linkchecker first, for now.
by Raymond Toy (＠rtoy) 10 Jul '24

10 Jul '24

Raymond Toy pushed to branch issue-334-add-wiki-link-checker at cmucl / cmucl Commits: bf0b507d by Raymond Toy at 2024-07-10T10:32:34-07:00 Run linkchecker first, for now. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -5,12 +5,12 @@ variables: stages: + - link-check - install - build - test - ansi-test - benchmark - - link-check cache: @@ -205,5 +205,4 @@ linkchecker: - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check # Clone the wiki pages and check the links there. - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git - - cd cmucl.wiki - - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check + - find cmucl.wiki -name \*.md -print0 | xargs -0 -n1 markdown-link-check View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/bf0b507d08dce66fd3b09be… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/bf0b507d08dce66fd3b09be… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-334-add-wiki-link-checker] Merge link checks into one (new) stage
by Raymond Toy (＠rtoy) 10 Jul '24

10 Jul '24

Raymond Toy pushed to branch issue-334-add-wiki-link-checker at cmucl / cmucl Commits: 9a413130 by Raymond Toy at 2024-07-10T08:33:44-07:00 Merge link checks into one (new) stage - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -10,6 +10,7 @@ stages: - test - ansi-test - benchmark + - link-check cache: @@ -193,24 +194,16 @@ osx:benchmark: - ../../snapshot/bin/lisp -load report # From https://github.com/tcort/markdown-link-check +# Checks links on the wiki pages whenever any wiki markdown pages change. linkchecker: - stage: test + stage: link-check image: name: ghcr.io/tcort/markdown-link-check:3.11.2 entrypoint: ["/bin/sh", "-c"] script: + # Check links in the main repo - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check - rules: - - changes: - - "**/*.md" - -# Checks links on the wiki pages whenever any wiki markdown pages change. -wikilinkchecker: - stage: test - image: - name: ghcr.io/tcort/markdown-link-check:3.11.2 - entrypoint: ["/bin/sh", "-c"] - script: + # Clone the wiki pages and check the links there. - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git - cd cmucl.wiki - - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check \ No newline at end of file + - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9a413130c848dcf7ba95da6… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/9a413130c848dcf7ba95da6… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-334-add-wiki-link-checker] 2 commits: Check the wiki pages too
by Raymond Toy (＠rtoy) 10 Jul '24

10 Jul '24

Raymond Toy pushed to branch issue-334-add-wiki-link-checker at cmucl / cmucl Commits: 287c0942 by Raymond Toy at 2024-07-10T08:18:10-07:00 Check the wiki pages too To do this clone the wiki repo and run the link checker on the wiki repo. - - - - - ef40043e by Raymond Toy at 2024-07-10T08:21:21-07:00 Use correct path to wiki repo - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -193,7 +193,6 @@ osx:benchmark: - ../../snapshot/bin/lisp -load report # From https://github.com/tcort/markdown-link-check -# Checks links on the wiki pages whenever any wiki markdown pages change. linkchecker: stage: test image: @@ -203,4 +202,15 @@ linkchecker: - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check rules: - changes: - - "**/*.md" \ No newline at end of file + - "**/*.md" + +# Checks links on the wiki pages whenever any wiki markdown pages change. +wikilinkchecker: + stage: test + image: + name: ghcr.io/tcort/markdown-link-check:3.11.2 + entrypoint: ["/bin/sh", "-c"] + script: + - git clone https://gitlab.common-lisp.net/cmucl/cmucl.wiki.git + - cd cmucl.wiki + - find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check \ No newline at end of file View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/fc4b12bee2957764774350… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/fc4b12bee2957764774350… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0