May 2025 - cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-401-file-position-setter-wrong] Add another file-position test
by Raymond Toy (＠rtoy) 08 May '25

08 May '25

Raymond Toy pushed to branch issue-401-file-position-setter-wrong at cmucl / cmucl Commits: a2c10e79 by Raymond Toy at 2025-05-08T08:18:42-07:00 Add another file-position test As mentioned in the comment for fd-stream-file-position, we have added a test for the case where the input buffer doesn't have enough octets to form a complete character. We create a file consisting of a single character followed by 128 characters that require 4 octets for utf-8 encoding. Hence the in-buffer (of length 512) only has a partial utf-8 character at the end. - - - - - 1 changed file: - tests/fd-streams.lisp Changes: ===================================== tests/fd-streams.lisp ===================================== @@ -65,3 +65,28 @@ (read-line s) (assert-true (file-position s 0)) (assert-equal (file-position s) 0)))) + +(define-test file-position.3 + (:tag :issues) + ;; Create a test file just longer than the internal in-buffer + ;; length. This tests the case where the in-buffer does not have + ;; enough octets to form a complete character. (See comment in + ;; fd-stream-file-position. + (let ((test-file (merge-pathnames #p"file-pos.txt" *test-path*))) + (with-open-file (s test-file + :external-format :utf-8 + :direction :output + :if-exists :supersede) + (write-char #\a s) + ;; STR is a string consisting of the single codepoint #x11000 + ;; which is 4 octets when encoded using utf-8. + (let ((str (lisp::codepoints-string '(#x11000)))) + (dotimes (k 128) + (write-string str s))) + (write-char #\newline s) + (write-string "zzzzz" s) + (write-char #\newline s)) + (with-open-file (s test-file :external-format :utf-8) + (read-line s) + (assert-true (file-position s 0)) + (assert-equal (file-position s) 0)))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a2c10e79c31425b24cdea49… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/a2c10e79c31425b24cdea49… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-401-file-position-setter-wrong] Add tests for file-position
by Raymond Toy (＠rtoy) 08 May '25

08 May '25

Raymond Toy pushed to branch issue-401-file-position-setter-wrong at cmucl / cmucl Commits: e7f7a9aa by Raymond Toy at 2025-05-08T07:57:10-07:00 Add tests for file-position - - - - - 1 changed file: - tests/fd-streams.lisp Changes: ===================================== tests/fd-streams.lisp ===================================== @@ -34,3 +34,34 @@ (setf s (open *test-file*)) (file-length s)) (delete-file *test-file*)))) + +(define-test file-position.1 + (:tag :issues) + ;; Create a short test file + (let ((test-file (merge-pathnames #p"file-pos.txt" *test-path*))) + (with-open-file (s test-file + :direction :output + :if-exists :supersede) + (write-string "aaaaaa" s) + (write-char #\newline s)) + (with-open-file (s test-file) + (read-line s) + (assert-true (file-position s 0)) + (assert-equal (file-position s) 0)))) + +(define-test file-position.2 + (:tag :issues) + ;; Create a test file just longer than the internal in-buffer length + ;; and the first line is more than 512 characters long. + (let ((test-file (merge-pathnames #p"file-pos.txt" *test-path*))) + (with-open-file (s test-file + :direction :output + :if-exists :supersede) + (write-string (make-string 512 :initial-element #\a) s) + (write-char #\newline s) + (write-string "zzzzz" s) + (write-char #\newline s)) + (with-open-file (s test-file) + (read-line s) + (assert-true (file-position s 0)) + (assert-equal (file-position s) 0)))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e7f7a9aad8981e3baf90492… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/e7f7a9aad8981e3baf90492… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-401-file-position-setter-wrong] 2 commits: Clean up debugging stuff
by Raymond Toy (＠rtoy) 08 May '25

08 May '25

Raymond Toy pushed to branch issue-401-file-position-setter-wrong at cmucl / cmucl Commits: bb4b550f by Raymond Toy at 2025-05-08T07:27:54-07:00 Clean up debugging stuff Remove additional prints and turn off original debugging stuff by uncommenting the `#+nil` stuff. - - - - - 7b351a33 by Raymond Toy at 2025-05-08T07:41:22-07:00 Fix typos introduced in previous commits - - - - - 1 changed file: - src/code/fd-stream.lisp Changes: ===================================== src/code/fd-stream.lisp ===================================== @@ -1699,7 +1699,7 @@ (posn errno) (unix:unix-lseek (fd-stream-fd stream) 0 unix:l_incr) (declare (type (or (integer 0) null) posn)) - ;;#+nil + #+nil (format t "lseek returns ~D ~D~%" posn errno) (cond (posn ;; Adjust for buffered output: @@ -1720,7 +1720,7 @@ (decf posn (- (fd-stream-ibuf-tail stream) (fd-stream-ibuf-head stream))) - ;;#+nil + #+nil (format t "Updated posn = ~D~%" posn) #+unicode (when (fd-stream-string-buffer stream) @@ -1737,14 +1737,14 @@ ;; octet-count doesn't use that. Hence, ;; subtract one from string-index and ;; string-buffer-len. - ;;#+nil + #+nil (progn (format t "~&ocount = ~D~%" ocount) (format t "posn = ~D~%" posn)) (loop for k of-type fixnum from (1- (fd-stream-string-index stream)) below (1- (fd-stream-string-buffer-len stream)) do (decf posn (aref ocount k))) - ;;#+nil + #+nil (progn (format t "new posn = ~D~%" posn) (format t "in-buffer-length = ~D~%" in-buffer-length) @@ -1760,23 +1760,19 @@ ;; string-buffer and no in-buffer, then the ibuf ;; tail and head pointers contain all the ;; information needed. - ;;#+nil + #+nil (progn (format t "in-buffer-length = ~D~%" in-buffer-length) (format t "in-length = ~D~%" (fd-stream-in-length stream)) (format t "fd-stream-in-index = ~D~%" (fd-stream-in-index stream)) (format t "posn = ~A~%" posn)) (decf posn (- (fd-stream-in-length stream) - (fd-stream-in-index stream))) - (format t "After inbuffer update posn = ~A~%" posn)) - ;;#+nil + (fd-stream-in-index stream)))) + #+nil (format t "fd-stream-unread = ~S~%" (fd-stream-unread stream)) (when (fd-stream-unread stream) ;;@@ (decf posn)) ;; Divide bytes by element size. - (format t "posn = ~A, size = ~A, trunc = ~A~%" - posn (fd-stream-element-size stream) - (truncate posn (fd-stream-element-size stream))) (truncate posn (fd-stream-element-size stream))) ((eq errno unix:espipe) nil) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/4b942f362924b4a6057480… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/4b942f362924b4a6057480… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-401-file-position-setter-wrong
by Raymond Toy (＠rtoy) 08 May '25

08 May '25

Raymond Toy pushed new branch issue-401-file-position-setter-wrong at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-401-file-position-s… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-400-unix-resolve-links] Add test for #400
by Raymond Toy (＠rtoy) 05 May '25

05 May '25

Raymond Toy pushed to branch issue-400-unix-resolve-links at cmucl / cmucl Commits: 2293f000 by Raymond Toy at 2025-05-05T10:23:00-07:00 Add test for #400 Based on test code from Philip Fominykh. Instead of using "/tmp", we create a tmp directory from the current directory which should work for any OS running CI or locally. - - - - - 1 changed file: - tests/issues.lisp Changes: ===================================== tests/issues.lisp ===================================== @@ -1153,3 +1153,16 @@ (assert-true (stream::find-external-format :646 nil)) (assert-true (eq (stream::find-external-format :646 nil) (stream::find-external-format :iso646-us nil)))) + +(define-test issue.400 + (:tag :issues) + (let* ((pl 50) + (nl 250) + (p (append (pathname-directory (ext:default-directory)) + (list "tmp") + (list (make-string pl :initial-element #\a)))) + (n (make-string nl :initial-element #\b)) + (pn (make-pathname :name n :directory p))) + (ensure-directories-exist pn) + (close (open pn :direction :output :if-exists :supersede)) + (assert-true (unix::unix-resolve-links (namestring pn))))) View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2293f000bc5e6f0eaf56a27… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/2293f000bc5e6f0eaf56a27… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-400-unix-resolve-links
by Raymond Toy (＠rtoy) 05 May '25

05 May '25

Raymond Toy pushed new branch issue-400-unix-resolve-links at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-400-unix-resolve-li… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-349-load-segment-with-rwx-permissions] Specify the correct path to the executable
by Raymond Toy (＠rtoy) 05 May '25

05 May '25

Raymond Toy pushed to branch issue-349-load-segment-with-rwx-permissions at cmucl / cmucl Commits: b7a3aa46 by Raymond Toy at 2025-05-05T09:18:31-07:00 Specify the correct path to the executable Need to prefix the executable path with "./" so `run-unit-tests.sh` can find it. - - - - - 1 changed file: - .gitlab-ci.yml Changes: ===================================== .gitlab-ci.yml ===================================== @@ -78,7 +78,7 @@ variables: - ./saved-lisp-executable --version # Run the unit tests with the executable, just to make sure the # executable works as expected. - - bin/run-unit-tests.sh -l saved-lisp-executable + - bin/run-unit-tests.sh -l ./saved-lisp-executable # Default configuration for running the benchmarks. .benchmark_template: &benchmark_configuration View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/b7a3aa4610be7744ec39d25… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/b7a3aa4610be7744ec39d25… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-349-load-segment-with-rwx-permissions
by Raymond Toy (＠rtoy) 05 May '25

05 May '25

Raymond Toy pushed new branch issue-349-load-segment-with-rwx-permissions at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-349-load-segment-wi… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0