Raymond Toy pushed to branch master at cmucl / cmucl
Commits:
51f730c2 by Raymond Toy at 2021-01-02T14:11:17-08:00
Remove PAGE_WRITE_PROTECT_CLEARED and MASK.
This macro and mask is only used once to set the bit (near line 498).
It's not read anywhere, so remove it.
Addresses #89.
- - - - -
c60c50da by Raymond Toy at 2021-01-02T22:35:29+00:00
Merge branch 'issue-89-remove-page-write-protect-cleared' into 'master'
Remove PAGE_WRITE_PROTECT_CLEARED and MASK.
See merge request cmucl/cmucl!57
- - - - -
2 changed files:
- src/lisp/gencgc.c
- src/lisp/gencgc.h
Changes:
=====================================
src/lisp/gencgc.c
=====================================
@@ -495,7 +495,6 @@ gc_write_barrier(void *addr)
/* Un-protect the page */
os_protect((os_vm_address_t) page_address(page_index), GC_PAGE_SIZE, OS_VM_PROT_ALL);
page_table[page_index].flags &= ~PAGE_WRITE_PROTECTED_MASK;
- page_table[page_index].flags |= PAGE_WRITE_PROTECT_CLEARED_MASK;
return 1;
}
=====================================
src/lisp/gencgc.h
=====================================
@@ -45,16 +45,6 @@ int gc_write_barrier(void *);
#define PAGE_WRITE_PROTECTED(page) \
(page_table[page].flags & PAGE_WRITE_PROTECTED_MASK)
-/*
- * This flag is set when the above write protect flag is clear by the
- * sigbus handler. This is useful for re-scavenging pages that are
- * written during a GC.
- */
-
-#define PAGE_WRITE_PROTECT_CLEARED_MASK 0x00000020
-#define PAGE_WRITE_PROTECT_CLEARED(page) \
- (page_table[page].flags & PAGE_WRITE_PROTECT_CLEARED_MASK)
-
/*
* Page allocated flag: 0 for a free page; 1 when allocated. If
* the page is free then the following slots are invalid - well
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/d1b59ff32243a8243c55f1…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/d1b59ff32243a8243c55f1…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch master at cmucl / cmucl
Commits:
d1b59ff3 by Raymond Toy at 2020-12-24T11:04:52-08:00
Clean up comment and remove custom COPT setting
Remove the comment about using -O1 for gcc 8.x. We can now work with
gcc 9.3 and later because we save the FPU state in
alloc_overflow_sse2. See commit
[8b08b800dc1c26d498fbc4054980c8d8bd761fe4].
- - - - -
1 changed file:
- src/lisp/Config.x86_linux
Changes:
=====================================
src/lisp/Config.x86_linux
=====================================
@@ -1,9 +1,6 @@
# -*- Mode: makefile -*-
include Config.x86_common
-# gcc 8.1.1 and 8.3.1 (and probably anything after 8.1.1?) won't
-# produce a working lisp with -O2. Just use -O1.
-COPT = -O2
CFLAGS += $(COPT)
CPPFLAGS += -m32 -D__NO_CTYPE -D_GNU_SOURCE
CFLAGS += -rdynamic -march=pentium4 -mfpmath=sse -mtune=generic
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d1b59ff32243a8243c55f12…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d1b59ff32243a8243c55f12…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch rtoy-refactor-ci-config at cmucl / cmucl
Commits:
ae2b154c by Raymond Toy at 2020-09-05T12:52:36-07:00
Add test.log to artifacts
Save the test.log from running our testsuite to the artifacts
- - - - -
1 changed file:
- .gitlab-ci.yml
Changes:
=====================================
.gitlab-ci.yml
=====================================
@@ -49,6 +49,7 @@ linux:test:
artifacts:
paths:
- ansi-test/test.out
+ - test.log
needs:
# Needs artifacts from install (ansi-test/) and build (dist/)
- job: linux:install
@@ -115,6 +116,7 @@ osx:test:
artifacts:
paths:
- ansi-test/test.out
+ - test.log
needs:
# Needs artifacts from install (ansi-test/) and build (dist/)
- job: osx:install
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ae2b154cdeac9b09541e692…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/ae2b154cdeac9b09541e692…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch rtoy-refactor-ci-config at cmucl / cmucl
Commits:
95678947 by Raymond Toy at 2020-09-05T11:41:11-07:00
Fix benchmark stage
We were cd'ing to the wrong directory (because we start at the root
of the build).
The stage for osx:benchmark was incorrectly set to test instead of
benchmark.
- - - - -
1 changed file:
- .gitlab-ci.yml
Changes:
=====================================
.gitlab-ci.yml
=====================================
@@ -73,7 +73,7 @@ linux:benchmark:
artifacts: true
- job: linux:build
script:
- - cd ../benchmarks/cl-bench
+ - cd benchmarks/cl-bench
- mkdir tmp
- CMUCL=../../snapshot/bin/lisp ./run-cmucl.sh
- CMUCL=../../dist/bin/lisp ./run-cmucl.sh
@@ -127,7 +127,7 @@ osx:test:
- grep 'No unexpected \(successes\|failures\)' test.out
osx:benchmark:
- stage: test
+ stage: benchmark
tags:
- osx
artifacts:
@@ -139,7 +139,7 @@ osx:benchmark:
artifacts: true
- job: osx:build
script:
- - cd ../benchmarks/cl-bench
+ - cd benchmarks/cl-bench
- mkdir tmp
- CMUCL=../../snapshot/bin/lisp ./run-cmucl.sh
- CMUCL=../../dist/bin/lisp ./run-cmucl.sh
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/956789478fdd540508f0b1e…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/956789478fdd540508f0b1e…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch rtoy-refactor-ci-config at cmucl / cmucl
Commits:
b2e80b1f by Raymond Toy at 2020-09-05T11:24:19-07:00
Update test and benchmark dependencies
Test stage needs the artifacts from the install and build stage
because it needs the ansi-test directory and the dist directory
Benchmark needs the same but because it needs the snapshot directory
and the dist directory so benchmarks can be run using the snapshot and
the latest build.
- - - - -
1 changed file:
- .gitlab-ci.yml
Changes:
=====================================
.gitlab-ci.yml
=====================================
@@ -50,8 +50,10 @@ linux:test:
paths:
- ansi-test/test.out
needs:
- - job: linux:build
+ # Needs artifacts from install (ansi-test/) and build (dist/)
+ - job: linux:install
artifacts: true
+ - job: linux:build
script:
- bin/run-tests.sh -l dist/bin/lisp 2>&1 | tee test.log
- cd ansi-test
@@ -66,8 +68,10 @@ linux:benchmark:
paths:
- benchmarks/cl-bench/results
needs:
- - job: linux:build
+ # Needs artifacts from install (snapshot/) and build (dist/)
+ - job: linux:install
artifacts: true
+ - job: linux:build
script:
- cd ../benchmarks/cl-bench
- mkdir tmp
@@ -112,8 +116,10 @@ osx:test:
paths:
- ansi-test/test.out
needs:
- - job: osx:build
+ # Needs artifacts from install (ansi-test/) and build (dist/)
+ - job: osx:install
artifacts: true
+ - job: osx:build
script:
- bin/run-tests.sh -l dist/bin/lisp 2>&1 | tee test.log
- cd ansi-test
@@ -128,8 +134,10 @@ osx:benchmark:
paths:
- benchmarks/cl-bench/results
needs:
- - job: osx:build
+ # Needs artifacts from install (snapshot/) and build (dist/)
+ - job: osx:install
artifacts: true
+ - job: osx:build
script:
- cd ../benchmarks/cl-bench
- mkdir tmp
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/b2e80b1f89749dbafada6f3…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/b2e80b1f89749dbafada6f3…
You're receiving this email because of your account on gitlab.common-lisp.net.