Raymond Toy pushed to branch master at cmucl / cmucl
Commits:
a85f2a01 by Raymond Toy at 2024-07-17T16:44:16+00:00
Address #336: Fix compiler warnings in srctran.lisp
- - - - -
ba2176ab by Raymond Toy at 2024-07-17T16:44:27+00:00
Merge branch 'issue-336-1-fix-compiler-notes' into 'master'
Address #336: Fix compiler warnings in srctran.lisp
See merge request cmucl/cmucl!233
- - - - -
2 changed files:
- src/compiler/srctran.lisp
- src/compiler/x86/float-sse2.lisp
Changes:
=====================================
src/compiler/srctran.lisp
=====================================
@@ -1809,8 +1809,7 @@
(round-it pos)))))))
(defun round-derive-type-quot (number-type divisor-type)
- (let* ((rem-type (rem-result-type number-type divisor-type))
- (number-interval (numeric-type->interval number-type))
+ (let* ((number-interval (numeric-type->interval number-type))
(divisor-interval (numeric-type->interval divisor-type)))
(let ((quot (round-quotient-bound
(interval-div number-interval
@@ -1819,9 +1818,7 @@
,(or (interval-high quot) '*))))))
(defun round-derive-type-rem (number-type divisor-type)
- (let* ((rem-type (rem-result-type number-type divisor-type))
- (number-interval (numeric-type->interval number-type))
- (divisor-interval (numeric-type->interval divisor-type)))
+ (let* ((rem-type (rem-result-type number-type divisor-type)))
(multiple-value-bind (class format)
(ecase rem-type
(integer
@@ -1835,13 +1832,6 @@
(values 'float nil))
(real
(values nil nil)))
- #+nil
- (when (member rem-type '(float single-float double-float
- #+long-float long-float
- #+double-double double-double-float))
- (setf rem (interval-func #'(lambda (x)
- (coerce x rem-type))
- rem)))
(make-numeric-type :class class
:format format
:low nil
=====================================
src/compiler/x86/float-sse2.lisp
=====================================
@@ -773,10 +773,11 @@
(inst ,opinst x (,ea y)))
(,stack-sc
(inst ,opinst x (,ea-stack y)))))
- ((and ,commutative (location= y r))
- ;; y = r and the operation is commutative, so just
- ;; do the operation with r and x.
- (inst ,opinst y x))
+ ,@(when commutative
+ `(((location= y r)
+ ;; y = r and the operation is commutative, so just
+ ;; do the operation with r and x.
+ (inst ,opinst y x))))
((not (location= r y))
;; x, y, and r are three different regs. So just
;; move r to x and do the operation on r.
@@ -1994,8 +1995,9 @@
`(cond
((location= x r)
(inst ,opinst x y))
- ((and ,commutative (location= y r))
- (inst ,opinst y x))
+ ,@(when commutative
+ `(((location= y r)
+ (inst ,opinst y x))))
((not (location= r y))
(inst ,movinst r x)
(inst ,opinst r y))
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5c8483f87814f4d2423fcc…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/5c8483f87814f4d2423fcc…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch issue-337-cross-compile-linux-x86-fails at cmucl / cmucl
Commits:
92732c62 by Raymond Toy at 2024-07-15T16:12:06-07:00
Need to save the cross-compiled lisp
Add xdist directory to artifacts so that the cross-compiled build can
be used for testing. Without this, the cross-test fails because it
can't find the lisp to use.
- - - - -
1 changed file:
- .gitlab-ci.yml
Changes:
=====================================
.gitlab-ci.yml
=====================================
@@ -56,6 +56,12 @@ linux:cross-build:
stage: build
tags:
- linux
+ artifacts:
+ paths:
+ - xdist/
+ - linux-2/*.log
+ - linux-3/*.log
+ - linux-4/*.log
needs:
- job: linux:install
artifacts: true
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/92732c62ca7118fa87c172c…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/92732c62ca7118fa87c172c…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch issue-337-cross-compile-linux-x86-fails at cmucl / cmucl
Commits:
d76be25f by Raymond Toy at 2024-07-15T14:40:25-07:00
Add CI to do cross-compile and run unit-tests
Do a cross-compile and then a native build to test the cross-compiler.
Then use that result (in `xdist/bin/lisp`) to run the unit tests.
These should work.
- - - - -
1 changed file:
- .gitlab-ci.yml
Changes:
=====================================
.gitlab-ci.yml
=====================================
@@ -52,6 +52,20 @@ linux:build:
# describe return something that make-dist.sh doesn't like.
- bin/make-dist.sh -V `git describe --dirty` -I dist linux-4
+linux:cross-build:
+ stage: build
+ tags:
+ - linux
+ needs:
+ - job: linux:install
+ artifacts: true
+ script:
+ - bin/create-target.sh xtarget
+ - bin/create-target.sh xcross
+ - bin/cross-build-world.sh -crl xtarget xcross src/tools/cross-scripts/cross-x86-x86.lisp snapshot/bin/lisp
+ - bin/build.sh $bootstrap -R -C "" -o xtarget/lisp/lisp
+ - bin/make-dist.sh -V `git describe --dirty` -I xdist linux-4
+
linux:test:
stage: test
tags:
@@ -67,6 +81,21 @@ linux:test:
script:
- bin/run-unit-tests.sh -l dist/bin/lisp 2>&1 | tee test.log
+linux:cross-test:
+ stage: test
+ tags:
+ - linux
+ artifacts:
+ paths:
+ - ansi-test/test.out
+ - cross-test.log
+ needs:
+ # Needs artifacts from build (dist/)
+ - job: linux:cross-build
+ artifacts: true
+ script:
+ - bin/run-unit-tests.sh -l xdist/bin/lisp 2>&1 | tee cross-test.log
+
linux:ansi-test:
stage: ansi-test
tags:
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d76be25f99317f2fd9df7aa…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/d76be25f99317f2fd9df7aa…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch issue-336-1-fix-compiler-notes at cmucl / cmucl
Commits:
1cf38921 by Raymond Toy at 2024-07-12T17:19:30-07:00
Fix note about unreachable code in float-sse2.lisp
The warning happens because we do `(and ,commutative ...)` where
`commutative` is a known value passed to the macro. When the value is
zero, we get the note since the rest of the `and` clause is known to
be unreachable.
Change this to handle the `commutative` and macro-expansion time to
add the clause only when `commutative` is true.
- - - - -
1 changed file:
- src/compiler/x86/float-sse2.lisp
Changes:
=====================================
src/compiler/x86/float-sse2.lisp
=====================================
@@ -773,10 +773,11 @@
(inst ,opinst x (,ea y)))
(,stack-sc
(inst ,opinst x (,ea-stack y)))))
- ((and ,commutative (location= y r))
- ;; y = r and the operation is commutative, so just
- ;; do the operation with r and x.
- (inst ,opinst y x))
+ ,@(when commutative
+ `(((location= y r)
+ ;; y = r and the operation is commutative, so just
+ ;; do the operation with r and x.
+ (inst ,opinst y x))))
((not (location= r y))
;; x, y, and r are three different regs. So just
;; move r to x and do the operation on r.
@@ -1994,8 +1995,9 @@
`(cond
((location= x r)
(inst ,opinst x y))
- ((and ,commutative (location= y r))
- (inst ,opinst y x))
+ ,@(when commutative
+ `(((location= y r)
+ (inst ,opinst y x))))
((not (location= r y))
(inst ,movinst r x)
(inst ,opinst r y))
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1cf38921444b05008021ac3…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/1cf38921444b05008021ac3…
You're receiving this email because of your account on gitlab.common-lisp.net.
Raymond Toy pushed to branch issue-334-add-wiki-link-checker at cmucl / cmucl
Commits:
534f2ae3 by Raymond Toy at 2024-07-10T15:12:09-07:00
Allow linkchecker to fail so pipeline will continue
We don't want the link checker to stop the pipeline so allow it it fail.
- - - - -
1 changed file:
- .gitlab-ci.yml
Changes:
=====================================
.gitlab-ci.yml
=====================================
@@ -200,6 +200,9 @@ linkchecker:
# Only the linux runner has markdown-link-check installed
tags:
- linux
+ # It's ok if this fails; we don't want to declare the entire
+ # pipeline as having failed.
+ allow_failure: true
script:
# Check links in the main repo
- find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/534f2ae3fec75e4d9bc7da7…
--
View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/534f2ae3fec75e4d9bc7da7…
You're receiving this email because of your account on gitlab.common-lisp.net.