- cmucl-cvs - mailman3.common-lisp.net

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Disable debugging prints
by Raymond Toy (＠rtoy) 23 Aug '22

23 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 834ff140 by Raymond Toy at 2022-08-23T15:29:31-07:00 Disable debugging prints - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -614,7 +614,7 @@ os_stat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_ return rc; } -#if 1 +#if 0 /* * Useful prints to see the actual size of the various * fields. Helpful for porting this to other OSes that we haven't View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/834ff140fb6080c2a7008d4… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/834ff140fb6080c2a7008d4… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Keep include files sorted
by Raymond Toy (＠rtoy) 23 Aug '22

23 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: bf5b52fa by Carl S. Shapiro at 2022-08-23T22:28:11+00:00 Keep include files sorted - - - - - 1 changed file: - src/lisp/os-common.c Changes: ===================================== src/lisp/os-common.c ===================================== @@ -10,8 +10,8 @@ #include <netdb.h> #include <stdio.h> #include <string.h> -#include <time.h> #include <sys/stat.h> +#include <time.h> #include "os.h" #include "internals.h" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/bf5b52faf340040fa9a53a8… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/bf5b52faf340040fa9a53a8… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Update pot file
by Raymond Toy (＠rtoy) 20 Aug '22

20 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 164bd106 by Raymond Toy at 2022-08-20T15:18:05-07:00 Update pot file The docstrings for unix-stat and friends have changed, so the pot file needs updating. - - - - - 1 changed file: - src/i18n/locale/cmucl-unix.pot Changes: ===================================== src/i18n/locale/cmucl-unix.pot ===================================== @@ -556,27 +556,6 @@ msgid "" "" msgstr "" -#: src/code/unix.lisp -msgid "" -"Unix-stat retrieves information about the specified\n" -" file returning them in the form of multiple values.\n" -" See the UNIX Programmer's Manual for a description\n" -" of the values returned. If the call fails, then NIL\n" -" and an error number is returned instead." -msgstr "" - -#: src/code/unix.lisp -msgid "" -"Unix-lstat is similar to unix-stat except the specified\n" -" file must be a symbolic link." -msgstr "" - -#: src/code/unix.lisp -msgid "" -"Unix-fstat is similar to unix-stat except the file is specified\n" -" by the file descriptor fd." -msgstr "" - #: src/code/unix.lisp msgid "The calling process." msgstr "" View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/164bd106c8aed710af34a30… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/164bd106c8aed710af34a30… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Set _LARGEFILE_SOURCE and _FILE_OFFSET_BITS here
by Raymond Toy (＠rtoy) 14 Aug '22

14 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: fdec8705 by Raymond Toy at 2022-08-14T08:34:55-07:00 Set _LARGEFILE_SOURCE and _FILE_OFFSET_BITS here Enable large file support by setting the c flags. Needed by os-common.c to support large files for os_stat and friends. - - - - - 2 changed files: - src/lisp/Config.x86_linux - src/lisp/Config.x86_linux_clang Changes: ===================================== src/lisp/Config.x86_linux ===================================== @@ -4,6 +4,7 @@ include Config.x86_common CFLAGS += $(COPT) CPPFLAGS += -m32 -D__NO_CTYPE CFLAGS += -rdynamic -march=pentium4 -mfpmath=sse -mtune=generic +CFLAGS += -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 UNDEFSYMPATTERN = -Xlinker -u -Xlinker & ASSEM_SRC += linux-stubs.S ===================================== src/lisp/Config.x86_linux_clang ===================================== @@ -9,6 +9,7 @@ CFLAGS += $(COPT) # (-mtune=pentium4), the first chip to have sse2; and finally generate # code assuming instructions can trap (-ftrapping-math). CFLAGS += -msse2 -mtune=pentium4 -ftrapping-math +CFLAGS += -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 UNDEFSYMPATTERN = -Xlinker -u -Xlinker & ASSEM_SRC += linux-stubs.S View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/fdec87055478c8f2d10a6c3… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/fdec87055478c8f2d10a6c3… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Fix some typos.
by Raymond Toy (＠rtoy) 14 Aug '22

14 Aug '22

Raymond Toy pushed to branch master at cmucl / cmucl Commits: f62f1e9e by Raymond Toy at 2022-08-14T08:09:53-07:00 Fix some typos. One was mentioned in !87. Found a few more typos so fixed those too. - - - - - 1 changed file: - src/general-info/release-21e.md Changes: ===================================== src/general-info/release-21e.md ===================================== @@ -1,10 +1,10 @@ # CMUCL 21e -## Work in prograss +## Work in progress The CMUCL project is pleased to announce the release of CMUCL 21e. This is a major release which contains numerous enhancements and bug -fixes from the 21a release. +fixes from the 21d release. CMUCL is a free, high performance implementation of the Common Lisp programming language which runs on most major Unix platforms. It @@ -39,15 +39,15 @@ public domain. * ~~#90~~ Some static symbols have been removed. This probably makes the fasl files incompatible with older versions. * ~~#91~~ Loop destructuring no longer incorrectly signals an error * ~~#95~~ Disassembler syntax of x86 je and movzx is incorrect - * ~~#97~~ Define and use ud2 instruction isntead of int3. Fixes single-stepping. + * ~~#97~~ Define and use ud2 instruction instead of int3. Fixes single-stepping. * ~~#98~~ fstpd is not an Intel instruction; disassemble as `fstp dword ptr [addr]` - * ~~#100~~ ldb prints out unicode base-chars correctly instead of just the low 8 bits. + * ~~#100~~ ldb prints out Unicode base-chars correctly instead of just the low 8 bits. * ~~#103~~ RANDOM-MT19937-UPDATE assembly routine still exists * ~~#104~~ Single-stepping broken (fixed via #97). * ~~#107~~ Replace u_int8_t with uint8_t * ~~#108~~ Update ASDF * ~~#112~~ CLX can't connect to X server via inet sockets - * ~~#113~~ REQUIRE on contribs can pull in the wrong things vai ASDF. + * ~~#113~~ REQUIRE on contribs can pull in the wrong things via ASDF. * ~~#121~~ Wrong column index in FILL-POINTER-OUTPUT-STREAM * ~~#122~~ gcc 11 can't build cmucl * ~~#127~~ Linux unix-getpwuid segfaults when given non-existent uid. View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f62f1e9ee9835281ee42b6f… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/f62f1e9ee9835281ee42b6f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] 2 commits: Fix #128: quit accepts an exit code
by Raymond Toy (＠rtoy) 14 Aug '22

14 Aug '22

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 9cf3916e by Raymond Toy at 2022-08-14T15:00:30+00:00 Fix #128: quit accepts an exit code - - - - - 3aec3f5e by Raymond Toy at 2022-08-14T15:00:31+00:00 Merge branch 'issue-128-quit-exit-code' into 'master' Fix #128: quit accepts an exit code Closes #128 See merge request cmucl/cmucl!87 - - - - - 3 changed files: - src/code/lispinit.lisp - src/general-info/release-21e.md - src/i18n/locale/cmucl.pot Changes: ===================================== src/code/lispinit.lisp ===================================== @@ -492,14 +492,15 @@ ;;; Quit gets us out, one way or another. -(defun quit (&optional recklessly-p) - "Terminates the current Lisp. Things are cleaned up unless Recklessly-P is - non-Nil." +(defun quit (&optional recklessly-p (code 0)) + "Terminates the current Lisp. Things are cleaned up unless + Recklessly-P is non-Nil. On quitting, Lisp sets the return code to + Code, defaulting to 0." (if recklessly-p - (unix:unix-exit 0) + (unix:unix-exit code) (progn (mapc (lambda (fn) (ignore-errors (funcall fn))) *cleanup-functions*) - (throw '%end-of-the-world 0)))) + (throw '%end-of-the-world code)))) #-mp ; Multi-processing version defined in multi-proc.lisp. ===================================== src/general-info/release-21e.md ===================================== @@ -51,6 +51,7 @@ public domain. * ~~#121~~ Wrong column index in FILL-POINTER-OUTPUT-STREAM * ~~#122~~ gcc 11 can't build cmucl * ~~#127~~ Linux unix-getpwuid segfaults when given non-existent uid. + * ~~#128~~ `QUIT` accepts an exit code * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -309,8 +309,9 @@ msgstr "" #: src/code/lispinit.lisp msgid "" -"Terminates the current Lisp. Things are cleaned up unless Recklessly-P is\n" -" non-Nil." +"Terminates the current Lisp. Things are cleaned up unless\n" +" Recklessly-P is non-Nil. On quitting, Lisp sets the return code to\n" +" Code, defaulting to 0." msgstr "" #: src/code/lispinit.lisp View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/88ca0184f219100c92888c… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/compare/88ca0184f219100c92888c… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-125-unix-stat-wrong] Address review comments
by Raymond Toy (＠rtoy) 14 Aug '22

14 Aug '22

Raymond Toy pushed to branch issue-125-unix-stat-wrong at cmucl / cmucl Commits: 6f0f8c05 by Raymond Toy at 2022-08-13T17:51:12-07:00 Address review comments In unix.lisp, use `c-call:long-long` and `c-call:unsigned-long-long` instead of `int64-t` and `u-int64-t`. Renamed functions from `unix_stat` to `os_stat`. In `os_stat` and friends, if the syscall fails, just return with the code instead of copying random stuff. - - - - - 2 changed files: - src/code/unix.lisp - src/lisp/os-common.c Changes: ===================================== src/code/unix.lisp ===================================== @@ -1337,37 +1337,37 @@ ;; to the stat function. fstat is different from stat and ;; lstat since it takes an fd for the first arg instead of ;; string. - `(with-alien ((dev u-int64-t) - (ino u-int64-t) + `(with-alien ((dev c-call:long-long) + (ino c-call:unsigned-long-long) (mode c-call:unsigned-int) - (nlink u-int64-t) + (nlink c-call:unsigned-long-long) (uid c-call:unsigned-int) (gid c-call:unsigned-int) - (rdev u-int64-t) - (size int64-t) - (atime int64-t) - (mtime int64-t) - (ctime int64-t) + (rdev c-call:unsigned-long-long) + (size c-call:long-long) + (atime c-call:long-long) + (mtime c-call:long-long) + (ctime c-call:long-long) (blksize c-call:long) - (blocks int64-t)) + (blocks c-call:long-long)) (let ((result (alien-funcall (extern-alien ,c-func-name (function int ,first-arg-type - (* u-int64-t) - (* u-int64-t) + (* c-call:long-long) + (* c-call:unsigned-long-long) (* c-call:unsigned-int) - (* u-int64-t) + (* c-call:unsigned-long-long) (* c-call:unsigned-int) (* c-call:unsigned-int) - (* u-int64-t) - (* int64-t) - (* int64-t) - (* int64-t) - (* int64-t) + (* c-call:unsigned-long-long) + (* c-call:long-long) + (* c-call:long-long) + (* c-call:long-long) + (* c-call:long-long) (* c-call:long) - (* int64-t))) + (* c-call:long-long))) ,first-arg (addr dev) (addr ino) @@ -1421,7 +1421,7 @@ (declare (type unix-pathname name)) (when (string= name "") (setf name ".")) - (call-stat "unix_stat" c-call:c-string (%name->file name))) + (call-stat "os_stat" c-call:c-string (%name->file name))) (defun unix-lstat (name) "Unix-lstat is similar to unix-stat except the specified @@ -1443,7 +1443,7 @@ st_blocks Number of blocks allocated. (Block size is implementation dependent.) " (declare (type unix-pathname name)) - (call-stat "unix_lstat" c-call:c-string (%name->file name))) + (call-stat "os_lstat" c-call:c-string (%name->file name))) (defun unix-fstat (fd) _N"Unix-fstat is similar to unix-stat except the file is specified @@ -1465,7 +1465,7 @@ st_blocks Number of blocks allocated. (Block size is implementation dependent.) " (declare (type unix-fd fd)) - (call-stat "unix_fstat" int fd))) + (call-stat "os_fstat" int fd))) (def-alien-type nil (struct rusage ===================================== src/lisp/os-common.c ===================================== @@ -5,12 +5,6 @@ */ -#ifdef __linux__ -/* Needed to get 64-bit objects for stat and friends on Linux. */ -#define _LARGEFILE_SOURCE -#define _FILE_OFFSET_BITS 64 -#endif - #include <errno.h> #include <math.h> #include <netdb.h> @@ -606,17 +600,21 @@ os_sleep(double seconds) * function that works across all OSes. */ int -unix_stat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, - unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, - int64_t *atime, int64_t *mtime, int64_t *ctime, - long *blksize, int64_t *blocks) +os_stat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, + unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, + int64_t *atime, int64_t *mtime, int64_t *ctime, + long *blksize, int64_t *blocks) { int rc; struct stat buf; rc = stat(path, &buf); -#if 0 + if (rc != 0) { + return rc; + } + +#if 1 /* * Useful prints to see the actual size of the various * fields. Helpful for porting this to other OSes that we haven't @@ -655,16 +653,20 @@ unix_stat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, } int -unix_fstat(int fd, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, - unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, - int64_t *atime, int64_t *mtime, int64_t *ctime, - long *blksize, int64_t *blocks) +os_fstat(int fd, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, + unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, + int64_t *atime, int64_t *mtime, int64_t *ctime, + long *blksize, int64_t *blocks) { int rc; struct stat buf; rc = fstat(fd, &buf); + if (rc != 0) { + return rc; + } + *dev = buf.st_dev; *ino = buf.st_ino; *mode = buf.st_mode; @@ -683,16 +685,20 @@ unix_fstat(int fd, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t } int -unix_lstat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, - unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, - int64_t *atime, int64_t *mtime, int64_t *ctime, - long *blksize, int64_t *blocks) +os_lstat(const char* path, u_int64_t *dev, u_int64_t *ino, unsigned int *mode, u_int64_t *nlink, + unsigned int *uid, unsigned int *gid, u_int64_t *rdev, int64_t *size, + int64_t *atime, int64_t *mtime, int64_t *ctime, + long *blksize, int64_t *blocks) { int rc; struct stat buf; rc = lstat(path, &buf); + if (rc != 0) { + return rc; + } + *dev = buf.st_dev; *ino = buf.st_ino; *mode = buf.st_mode; View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6f0f8c0501d22d6e63d237f… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/6f0f8c0501d22d6e63d237f… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][issue-128-quit-exit-code] Rename exit-code to code.
by Raymond Toy (＠rtoy) 14 Aug '22

14 Aug '22

Raymond Toy pushed to branch issue-128-quit-exit-code at cmucl / cmucl Commits: bfdd1d8c by Raymond Toy at 2022-08-13T17:20:01-07:00 Rename exit-code to code. Carl, offline, suggested renaming exit-code to just code. The docstring is also updated, along with the pot file because the docstring changed. Update the release notes as well. - - - - - 3 changed files: - src/code/lispinit.lisp - src/general-info/release-21e.md - src/i18n/locale/cmucl.pot Changes: ===================================== src/code/lispinit.lisp ===================================== @@ -492,15 +492,15 @@ ;;; Quit gets us out, one way or another. -(defun quit (&optional recklessly-p (exit-code 0)) +(defun quit (&optional recklessly-p (code 0)) "Terminates the current Lisp. Things are cleaned up unless Recklessly-P is non-Nil. On quitting, Lisp sets the return code to - exit-code, defaulting to 0." + Code, defaulting to 0." (if recklessly-p - (unix:unix-exit exit-code) + (unix:unix-exit code) (progn (mapc (lambda (fn) (ignore-errors (funcall fn))) *cleanup-functions*) - (throw '%end-of-the-world exit-code)))) + (throw '%end-of-the-world code)))) #-mp ; Multi-processing version defined in multi-proc.lisp. ===================================== src/general-info/release-21e.md ===================================== @@ -51,6 +51,7 @@ public domain. * ~~#121~~ Wrong column index in FILL-POINTER-OUTPUT-STREAM * ~~#122~~ gcc 11 can't build cmucl * ~~#127~~ Linux unix-getpwuid segfaults when given non-existent uid. + * ~~#128~~ `QUIT` accepts an exit code * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: ===================================== src/i18n/locale/cmucl.pot ===================================== @@ -311,7 +311,7 @@ msgstr "" msgid "" "Terminates the current Lisp. Things are cleaned up unless\n" " Recklessly-P is non-Nil. On quitting, Lisp sets the return code to\n" -" exit-code, defaulting to 0." +" Code, defaulting to 0." msgstr "" #: src/code/lispinit.lisp View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/bfdd1d8c039f13caf593472… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/bfdd1d8c039f13caf593472… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl] Pushed new branch issue-128-quit-exit-code
by Raymond Toy (＠rtoy) 12 Aug '22

12 Aug '22

Raymond Toy pushed new branch issue-128-quit-exit-code at cmucl / cmucl -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/tree/issue-128-quit-exit-code You're receiving this email because of your account on gitlab.common-lisp.net.

1 0

[Git][cmucl/cmucl][master] Update release notes
by Raymond Toy (＠rtoy) 08 Aug '22

08 Aug '22

Raymond Toy pushed to branch master at cmucl / cmucl Commits: 88ca0184 by Raymond Toy at 2022-08-08T10:44:47-07:00 Update release notes We've fixed bugs #122 and #127 now, so make a note of it. - - - - - 1 changed file: - src/general-info/release-21e.md Changes: ===================================== src/general-info/release-21e.md ===================================== @@ -49,6 +49,8 @@ public domain. * ~~#112~~ CLX can't connect to X server via inet sockets * ~~#113~~ REQUIRE on contribs can pull in the wrong things vai ASDF. * ~~#121~~ Wrong column index in FILL-POINTER-OUTPUT-STREAM + * ~~#122~~ gcc 11 can't build cmucl + * ~~#127~~ Linux unix-getpwuid segfaults when given non-existent uid. * Other changes: * Improvements to the PCL implementation of CLOS: * Changes to building procedure: View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/88ca0184f219100c92888cf… -- View it on GitLab: https://gitlab.common-lisp.net/cmucl/cmucl/-/commit/88ca0184f219100c92888cf… You're receiving this email because of your account on gitlab.common-lisp.net.

1 0